From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFEFDC4332D for ; Thu, 19 Mar 2020 08:14:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A494120663 for ; Thu, 19 Mar 2020 08:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A494120663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=proxmox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEqJv-0000SR-RT for qemu-devel@archiver.kernel.org; Thu, 19 Mar 2020 04:14:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42822) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEqJM-0008P7-5e for qemu-devel@nongnu.org; Thu, 19 Mar 2020 04:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEqJL-0000Q6-8x for qemu-devel@nongnu.org; Thu, 19 Mar 2020 04:13:52 -0400 Received: from proxmox-new.maurer-it.com ([212.186.127.180]:59588) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEqJL-0008OP-27 for qemu-devel@nongnu.org; Thu, 19 Mar 2020 04:13:51 -0400 Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 92FDB42101; Thu, 19 Mar 2020 09:13:39 +0100 (CET) Date: Thu, 19 Mar 2020 09:13:38 +0100 (CET) From: Dietmar Maurer To: "kwolf@redhat.com" , "qemu-devel@nongnu.org" Message-ID: <1577640273.5.1584605618249@webmail.proxmox.com> Subject: aio-context question MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.2-Rev22 X-Originating-Client: open-xchange-appsuite X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.186.127.180 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Dietmar Maurer Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" I just saw commit 30dd65f307b647eef8156c4a33bd007823ef85cb, and noticed that a similar pattern in drive_backup_prepare() and blockdev_backup_prepare(). The calls to bdrv_try_set_aio_context() seems useless, because we already do that later in backup_job_create/brdv_attach. But I am not 100%& sure?