From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0077DC2D0C2 for ; Tue, 31 Dec 2019 13:10:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9B54205ED for ; Tue, 31 Dec 2019 13:10:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OiQO0K6w" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9B54205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imHIG-0005KL-FO for qemu-devel@archiver.kernel.org; Tue, 31 Dec 2019 08:10:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:54888) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imHBr-0005Ao-Dh for qemu-devel@nongnu.org; Tue, 31 Dec 2019 08:04:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imHBq-0002SS-B4 for qemu-devel@nongnu.org; Tue, 31 Dec 2019 08:04:03 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:46393 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1imHBq-0002P3-35 for qemu-devel@nongnu.org; Tue, 31 Dec 2019 08:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577797441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZCfJe+G58JPj5ymxdgpn70J6sn4tllCO7EP5Gvx81s=; b=OiQO0K6wB1+1hFOfMqdCp5THYnOE1AskesSrUNdQw62gO31tmGkcd6KbYJR7BuE5q/HiMc 2mcjZmz3o3N6p6iGFHBY6OHkHldRdlTtAq1zYT1kDnxHOlctaQIvVAy9zY8Qy1xwmEBOFc 7Brv8vBYAOla1aT5cfeXLTrPd6U9cls= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-396-2MZ2jbVRO72pPqWQ-9qQiQ-1; Tue, 31 Dec 2019 08:04:00 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2223218031D0 for ; Tue, 31 Dec 2019 13:03:59 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9DE77620A6 for ; Tue, 31 Dec 2019 13:03:58 +0000 (UTC) From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH 11/86] hw:aspeed: drop warning and bogus ram_size fixup Date: Tue, 31 Dec 2019 14:02:55 +0100 Message-Id: <1577797450-88458-12-git-send-email-imammedo@redhat.com> In-Reply-To: <1577797450-88458-1-git-send-email-imammedo@redhat.com> References: <1577797450-88458-1-git-send-email-imammedo@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 2MZ2jbVRO72pPqWQ-9qQiQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" It was useless to try fixup ram_size and print warning on guest access to config register to begin with. Now previous patch made sure that SDMC can not be realized with invalid RAM size, so there is no case where warning and not used ram_size fixup could be triggered. So remove now dead code. Signed-off-by: Igor Mammedov --- hw/misc/aspeed_sdmc.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index b398e36..942b27a 100644 --- a/hw/misc/aspeed_sdmc.c +++ b/hw/misc/aspeed_sdmc.c @@ -219,17 +219,8 @@ static int aspeed_get_ram_feat(AspeedSDMCState *s) { AspeedSDMCClass *asc =3D ASPEED_SDMC_GET_CLASS(s); int ram_mb =3D s->ram_size >> 20; - gpointer val; + gpointer val =3D g_hash_table_lookup(asc->ram2feat, GINT_TO_POINTER(ra= m_mb)); =20 - if (g_hash_table_contains(asc->ram2feat, GINT_TO_POINTER(ram_mb))) { - val =3D g_hash_table_lookup(asc->ram2feat, GINT_TO_POINTER(ram_mb)= ); - return GPOINTER_TO_INT(val); - } - - warn_report("Invalid RAM size 0x%" PRIx64 ". Using default %dM", - s->ram_size, asc->fallback_ram_size); - s->ram_size =3D asc->fallback_ram_size << 20; - val =3D g_hash_table_lookup(asc->ram2feat, &asc->fallback_ram_size); return GPOINTER_TO_INT(val); } =20 --=20 2.7.4