From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 663B1C282DD for ; Wed, 8 Jan 2020 12:40:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F0B9206DA for ; Wed, 8 Jan 2020 12:40:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m+wiMyb8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F0B9206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAde-0006N9-VP for qemu-devel@archiver.kernel.org; Wed, 08 Jan 2020 07:40:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60308) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAWL-0003iU-Fw for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipAWK-0004HK-9e for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:09 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:40809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipAWK-0004Gj-30 for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:08 -0500 Received: by mail-wm1-x335.google.com with SMTP id t14so2304819wmi.5 for ; Wed, 08 Jan 2020 04:33:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rosgTXU7NuqW50rtytxejrl5MTYMCw63euXWmhTQ/DQ=; b=m+wiMyb8fphkXLN0I9PLhEl1eEr9pbC7K3mvoiS4DiKUTkuy2xJydGyegQQ9myq3dg /n4pJ5zLWljrjsCh48GN7uAabfG0CAC/oQKge9Go4kiHpl/EzVOtOhLHFgKgfDQWxDFA sKKfKUGjdsvGl1CW8aELKg90ynN2RBuW2y+1gD847lLoTA1S/Ajig/F6yP7Pi8H1x2T8 4YI1xPzA4++8NLnhdevi38/3sdN9XJaqeP6ysCFN1yKB589jLjqGwp671ORgAvmdAxBh 9ZJDQily4hHvxfRIMWPcdHJNRglJd4mJm6/g346lVsJlqRMfoIPaomAmXJWJzpzY+RSO 8qxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=rosgTXU7NuqW50rtytxejrl5MTYMCw63euXWmhTQ/DQ=; b=sc1Pl1lZF4QUyoqKtCb9AeY2ukmnjDPcbNpabFIccommu3nCFYvweDG6A7Y4/eDju4 9hxrhVoZR4FrU78m8AEzKCgdcYcISPjMpDPji+kTdPgNjuIZzSAUk9X9KIeMf+aIRMy9 1RQ+RtaD5zpk0evVMVsQeKgoSOglOIdwfeM0obADBRs0WMPkMvcRhr2UckRHDJ//vIU3 OzWc6YQ7F9xPnLX1+VGqnGbUf4Dt39FsV+tXWrytp/vVnsR1C4Bn52eca/hUlVEpl2Iv 0RYAXK6YU7pMHQuoYrJfZkWC3eP9QESzWH2ZrpQt4vJIGH3YXznkCGyNeBB9QVuvPgdW 9XeA== X-Gm-Message-State: APjAAAVksoS7ykE4sHsyFxprAKsoknTuO75sWDG4wqXttF+6Ggp7b0b0 Vd5qCM1WVGgVuIFgLhwNIRxlI2kk X-Google-Smtp-Source: APXvYqwft8YVYbtgH9fIxJ+ClV1SutL+5Pw9ND74+AU1CM0P25KR7R2b+uGmnp2CiKQlp1et4X33ag== X-Received: by 2002:a1c:a50e:: with SMTP id o14mr3528011wme.2.1578486786831; Wed, 08 Jan 2020 04:33:06 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id o4sm4037750wrw.97.2020.01.08.04.33.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2020 04:33:06 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 10/38] hw/intc/i8259: Fix Kconfig dependency on ISA bus Date: Wed, 8 Jan 2020 13:32:27 +0100 Message-Id: <1578486775-52247-11-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1578486775-52247-1-git-send-email-pbonzini@redhat.com> References: <1578486775-52247-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé The 8259 Interrupt Controller sits on a ISA bus. Add the missing dependency to fix: LINK x86_64-softmmu/qemu-system-x86_64 /usr/bin/ld: ../hw/intc/i8259_common.o: in function `pic_common_realize': hw/intc/i8259_common.c:84: undefined reference to `isa_register_ioport' /usr/bin/ld: hw/intc/i8259_common.c:86: undefined reference to `isa_register_ioport' /usr/bin/ld: ../hw/intc/i8259_common.o: in function `i8259_init_chip': hw/intc/i8259_common.c:97: undefined reference to `isa_create' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:206: qemu-system-x86_64] Error 1 Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20191231183216.6781-3-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- hw/intc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig index 10a680b..a189d6f 100644 --- a/hw/intc/Kconfig +++ b/hw/intc/Kconfig @@ -3,6 +3,7 @@ config HEATHROW_PIC config I8259 bool + select ISA_BUS config PL190 bool -- 1.8.3.1