From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33413C282DD for ; Wed, 8 Jan 2020 12:53:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAF9B206F0 for ; Wed, 8 Jan 2020 12:53:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mmGI9Fcu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAF9B206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAqO-00089Y-KW for qemu-devel@archiver.kernel.org; Wed, 08 Jan 2020 07:53:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60699) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipAWl-0004Mu-En for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipAWk-0004aU-CR for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:35 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:33839) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipAWk-0004a9-6a for qemu-devel@nongnu.org; Wed, 08 Jan 2020 07:33:34 -0500 Received: by mail-wr1-x42b.google.com with SMTP id t2so3239710wrr.1 for ; Wed, 08 Jan 2020 04:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8UTL2P0i77cpbG9WgGJIiLpRG//RBVj09gdW5qz0I7M=; b=mmGI9Fcu75W2Jk1JspvBkG3FOkI+So/7SWMV/JaSsK5F6nRz0qB5usNydujaOO6D+R o+tBHpoVvFdkx2yJwITG8KaphmJUDpcpwqbKzTqvGG/VQB/QKbD7CEsIO3eXL+qdsoWk 5KMI/AfnEm+2w0lx1n42q+EwtMwG5kkoQ4wft8fYHKXOI4x0NT+Mj9+KUCuXsW1JN91l Aw4Gbd3BYb39u98Q+KUDr2piynow0mMlvwstTHPKrtAVRUVG6jDuFPACTuvqsLckDh6T 3AXLZir49gkHY1swtYZqXOARTNwxH4uK9hJ6FvXbjkpPy2dmVweMgh2y7ZVgFcyBmX/4 Z0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=8UTL2P0i77cpbG9WgGJIiLpRG//RBVj09gdW5qz0I7M=; b=fZv4tTVDYgnpSd4jaXmWozXRxQt16dlptKxyEeM+PMSCWxaayKBcuCl54qORPdYre2 klpy3vj4JHPbXOj8ro+3QMem8feexu9M1DAt6ZblnmVbhgnPZFoG5EMtrK3pbIGQ6J7R Fsds2RrXH91eqPHjF0JS+W3LtgtdVa5KV8HF+P+nMzLfOIwv9Jz9Jl0lL9UXnwlCr75+ Xm1s40B3jOYsFHeKqh+o7pEDmwtNDrniH4FAKFWK7CLQ+XAA1TO+htu23tQAG+zFOPwx /ebPUnV6TJHvB5AabgRpl89OJWu52qhzPltwwyvbEQmWPqclW1ArN64kQwYF9EGEFEc9 8rNw== X-Gm-Message-State: APjAAAU6uK5Va69WItrqPdtaDCmxY/2Pa8UoKE3RQE3812Rt/6nemIPy gxOcDg0Ag8Tm34lwoUkoT3uvWU6E X-Google-Smtp-Source: APXvYqwGEF5qhrQE+5Jqv/0caK4snd5KntTxb+eio3plZGR6zDxoWQYFa6vdapx+0zlU/jS7XU5KRQ== X-Received: by 2002:a05:6000:1288:: with SMTP id f8mr4354857wrx.66.1578486812959; Wed, 08 Jan 2020 04:33:32 -0800 (PST) Received: from 640k.lan ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id o4sm4037750wrw.97.2020.01.08.04.33.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2020 04:33:32 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 33/38] virtio-console: Explicit we ignore some QEMUChrEvent in IOEventHandler Date: Wed, 8 Jan 2020 13:32:50 +0100 Message-Id: <1578486775-52247-34-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1578486775-52247-1-git-send-email-pbonzini@redhat.com> References: <1578486775-52247-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42b X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé The Chardev events are listed in the QEMUChrEvent enum. To be able to use this enum in the IOEventHandler typedef, we need to explicit all the events ignored by this frontend, to silent the following GCC warning: CC hw/char/virtio-console.o hw/char/virtio-console.c: In function ‘chr_event’: hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_BREAK’ not handled in switch [-Werror=switch] 154 | switch (event) { | ^~~~~~ hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_IN’ not handled in switch [-Werror=switch] hw/char/virtio-console.c:154:5: error: enumeration value ‘CHR_EVENT_MUX_OUT’ not handled in switch [-Werror=switch] cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Reviewed-by: Marc-André Lureau Message-Id: <20191218172009.8868-11-philmd@redhat.com> Signed-off-by: Paolo Bonzini --- hw/char/virtio-console.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c index c13649f..cbb304d 100644 --- a/hw/char/virtio-console.c +++ b/hw/char/virtio-console.c @@ -162,6 +162,11 @@ static void chr_event(void *opaque, int event) } virtio_serial_close(port); break; + case CHR_EVENT_BREAK: + case CHR_EVENT_MUX_IN: + case CHR_EVENT_MUX_OUT: + /* Ignore */ + break; } } -- 1.8.3.1