From: Filip Bozuta <Filip.Bozuta@rt-rk.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, berrange@redhat.com, arnd@arndb.de,
richard.henderson@linaro.org, laurent@vivier.eu,
jcmvbkbc@gmail.com, amarkovic@wavecomp.com, philmd@redhat.com
Subject: [PATCH v8 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl()
Date: Wed, 15 Jan 2020 20:36:47 +0100 [thread overview]
Message-ID: <1579117007-7565-14-git-send-email-Filip.Bozuta@rt-rk.com> (raw)
In-Reply-To: <1579117007-7565-1-git-send-email-Filip.Bozuta@rt-rk.com>
Function "do_ioctl()" located in file "syscall.c" was missing
an option for TYPE_LONG and TYPE_ULONG. This caused some ioctls
to not be recognised because they had the third argument that was
of type 'long' or 'unsigned long'.
For example:
Since implemented ioctls RTC_IRQP_SET and RTC_EPOCH_SET
are of type IOW(writing type) that have unsigned long as
their third argument, they were not recognised in QEMU
before the changes of this patch.
Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com>
---
linux-user/syscall.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a3993a2..2ba2c5c 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5176,6 +5176,8 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg)
break;
case TYPE_PTRVOID:
case TYPE_INT:
+ case TYPE_LONG:
+ case TYPE_ULONG:
ret = get_errno(safe_ioctl(fd, ie->host_cmd, arg));
break;
case TYPE_PTR:
--
2.7.4
next prev parent reply other threads:[~2020-01-15 19:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 19:36 [PATCH v8 00/13] linux-user: Add support for real time clock and Filip Bozuta
2020-01-15 19:36 ` [PATCH v8 01/13] linux-user: Add support for enabling/disabling RTC features using ioctls Filip Bozuta
2020-01-22 14:18 ` Laurent Vivier
2020-01-15 19:36 ` [PATCH v8 02/13] linux-user: Add support for getting/setting RTC time and alarm " Filip Bozuta
2020-01-22 14:19 ` Laurent Vivier
2020-01-15 19:36 ` [PATCH v8 03/13] linux-user: Add support for getting/setting RTC periodic interrupt and epoch " Filip Bozuta
2020-01-22 14:19 ` Laurent Vivier
2020-01-15 19:36 ` [PATCH v8 04/13] linux-user: Add support for getting/setting RTC wakeup alarm " Filip Bozuta
2020-01-22 14:20 ` Laurent Vivier
2020-01-15 19:36 ` [PATCH v8 05/13] linux-user: Add support for getting/setting RTC PLL correction " Filip Bozuta
2020-01-22 14:20 ` Laurent Vivier
2020-01-15 19:36 ` [PATCH v8 06/13] linux-user: Add support for read/clear RTC voltage low detector " Filip Bozuta
2020-01-22 14:21 ` Laurent Vivier
2020-01-15 19:36 ` [PATCH v8 07/13] linux-user: Add support for getting alsa timer version and id Filip Bozuta
2020-01-15 19:36 ` [PATCH v8 08/13] linux-user: Add support for setting alsa timer enhanced read using ioctl Filip Bozuta
2020-01-15 19:36 ` [PATCH v8 09/13] linux-user: Add support for getting/setting specified alsa timer parameters using ioctls Filip Bozuta
2020-01-15 19:36 ` [PATCH v8 10/13] linux-user: Add support for selecting alsa timer using ioctl Filip Bozuta
2020-01-15 19:36 ` [PATCH v8 11/13] linux-user: Add support for getting/setting selected alsa timer parameters using ioctls Filip Bozuta
2020-01-15 19:36 ` [PATCH v8 12/13] linux-user: Add support for selected alsa timer instructions " Filip Bozuta
2020-01-15 19:36 ` Filip Bozuta [this message]
2020-01-15 21:55 ` [PATCH v8 13/13] linux-user: Add support for TYPE_LONG and TYPE_ULONG in do_ioctl() Laurent Vivier
2020-01-22 14:17 ` Laurent Vivier
2020-02-18 20:28 ` [PATCH v8 00/13] linux-user: Add support for real time clock and Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579117007-7565-14-git-send-email-Filip.Bozuta@rt-rk.com \
--to=filip.bozuta@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=arnd@arndb.de \
--cc=berrange@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).