From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1
Date: Tue, 31 Jan 2017 18:27:10 -0500 [thread overview]
Message-ID: <157b55c5-2927-5f4e-0c43-820abd75a6d2@redhat.com> (raw)
In-Reply-To: <87wpdbw2ki.fsf@dusky.pond.sub.org>
On 31/01/2017 12:40, Markus Armbruster wrote:
>>
>> #define QEMU_NORETURN __attribute__ ((__noreturn__))
>>
>> -#if QEMU_GNUC_PREREQ(3, 4)
>> #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
>> -#else
>> -#define QEMU_WARN_UNUSED_RESULT
>> -#endif
> Should we inline this macro?
>
>>
>> -#if QEMU_GNUC_PREREQ(4, 0)
>> #define QEMU_SENTINEL __attribute__((sentinel))
>> -#else
>> -#define QEMU_SENTINEL
>> -#endif
> Likewise.
Why, since we don't do that for QEMU_NORETURN, QEMU_PACKED, etc.?
Paolo
next prev parent reply other threads:[~2017-01-31 23:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 16:14 [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 Peter Maydell
2017-01-31 16:55 ` Daniel P. Berrange
2017-01-31 16:58 ` Peter Maydell
2017-01-31 23:27 ` Paolo Bonzini
2017-01-31 17:40 ` Markus Armbruster
2017-01-31 18:00 ` Peter Maydell
2017-01-31 18:11 ` Daniel P. Berrange
2017-01-31 18:32 ` Peter Maydell
2017-01-31 19:02 ` Markus Armbruster
2017-01-31 18:58 ` Markus Armbruster
2017-01-31 23:27 ` Paolo Bonzini [this message]
2017-02-01 6:49 ` Markus Armbruster
2017-02-02 1:09 ` Paolo Bonzini
2017-02-02 10:17 ` Markus Armbruster
2017-04-21 9:08 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157b55c5-2927-5f4e-0c43-820abd75a6d2@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).