From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFfMH-00019T-GG for qemu-devel@nongnu.org; Mon, 26 Jan 2015 03:49:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFfME-0001uQ-Q1 for qemu-devel@nongnu.org; Mon, 26 Jan 2015 03:49:21 -0500 Received: from mail.nologin.es ([62.82.228.235]:51605 helo=nologin.es) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFfME-0001qG-BT for qemu-devel@nongnu.org; Mon, 26 Jan 2015 03:49:18 -0500 From: Javier Celaya Date: Mon, 26 Jan 2015 09:48:53 +0100 Message-ID: <158031087.SthlJV7jIF@javinlg> In-Reply-To: <54C27602.5070500@redhat.com> References: <1508539.cfTQauU1Ry@javinlg> <17343709.DGNVESbVIr@javinlg> <54C27602.5070500@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart1898311.ApF91tA4bB" Content-Transfer-Encoding: 7Bit Subject: Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , spice-devel Cc: devel@flexvm.es, Gerd Hoffmann , Anthony Liguori , qemu-devel@nongnu.org This is a multi-part message in MIME format. --nextPart1898311.ApF91tA4bB Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sorry, I forgot to patch the command-line help. Hope it helps. El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribi=F3: > On 01/23/2015 07:06 AM, Javier Celaya wrote: > > Hello, this is the patch with the version check. Christophe, can yo= u check > > that the version is the correct one? > >=20 > >=20 > >=20 > > Recently, SPICE included the lz4 compression algorithm. This patch = adds > > a command line option to select it. > > --- > >=20 > > ui/spice-core.c | 3 +++ > > 1 file changed, 3 insertions(+) > >=20 > > diff --git a/ui/spice-core.c b/ui/spice-core.c > > index 6467fa4..dadcae9 100644 > > --- a/ui/spice-core.c > > +++ b/ui/spice-core.c > > @@ -359,6 +359,9 @@ static const char *compression_names[] =3D { > >=20 > > [ SPICE_IMAGE_COMPRESS_QUIC ] =3D "quic", > > [ SPICE_IMAGE_COMPRESS_GLZ ] =3D "glz", > > [ SPICE_IMAGE_COMPRESS_LZ ] =3D "lz", > >=20 > > +#if SPICE_SERVER_VERSION >=3D 0x000c07 > > + [ SPICE_IMAGE_COMPRESS_LZ4 ] =3D "lz4", >=20 > How is libvirt going to introspect whether the command line supports > this option? Is there some QMP command that lists the set of valid > compression formats understood by a given qemu binary? --nextPart1898311.ApF91tA4bB Content-Disposition: attachment; filename="0001-Add-lz4-compression-option-for-SPICE.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-Add-lz4-compression-option-for-SPICE.patch" >>From 26864da931603791c70c570b9b46f21657ebcaec Mon Sep 17 00:00:00 2001 From: Javier Celaya Date: Wed, 7 Jan 2015 11:53:24 +0100 Subject: [PATCH] Add lz4 compression option for SPICE. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. --- qemu-options.hx | 4 ++-- ui/spice-core.c | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 22cf3b9..f5c54ba 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -953,7 +953,7 @@ DEF("spice", HAS_ARG, QEMU_OPTION_spice, " [,tls-channel=[main|display|cursor|inputs|record|playback]]\n" " [,plaintext-channel=[main|display|cursor|inputs|record|playback]]\n" " [,sasl][,password=][,disable-ticketing]\n" - " [,image-compression=[auto_glz|auto_lz|quic|glz|lz|off]]\n" + " [,image-compression=[auto_glz|auto_lz|quic|glz|lz|lz4|off]]\n" " [,jpeg-wan-compression=[auto|never|always]]\n" " [,zlib-glz-wan-compression=[auto|never|always]]\n" " [,streaming-video=[off|all|filter]][,disable-copy-paste]\n" @@ -1028,7 +1028,7 @@ channels. The special name "default" can be used to set the default mode. For channels which are not explicitly forced into one mode the spice client is allowed to pick tls/plaintext as he pleases. -@item image-compression=[auto_glz|auto_lz|quic|glz|lz|off] +@item image-compression=[auto_glz|auto_lz|quic|glz|lz|lz4|off] Configure image compression (lossless). Default is auto_glz. diff --git a/ui/spice-core.c b/ui/spice-core.c index 6467fa4..dadcae9 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -359,6 +359,9 @@ static const char *compression_names[] = { [ SPICE_IMAGE_COMPRESS_QUIC ] = "quic", [ SPICE_IMAGE_COMPRESS_GLZ ] = "glz", [ SPICE_IMAGE_COMPRESS_LZ ] = "lz", +#if SPICE_SERVER_VERSION >= 0x000c07 + [ SPICE_IMAGE_COMPRESS_LZ4 ] = "lz4", +#endif }; #define parse_compression(_name) \ parse_name(_name, "image compression", \ -- 1.9.3 --nextPart1898311.ApF91tA4bB--