From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 412E6C27C53 for ; Thu, 20 Jun 2024 02:49:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sK7qZ-0000LN-VD; Wed, 19 Jun 2024 22:48:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sK7qW-0000I0-I6 for qemu-devel@nongnu.org; Wed, 19 Jun 2024 22:48:20 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sK7qU-0006k1-8b for qemu-devel@nongnu.org; Wed, 19 Jun 2024 22:48:19 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-705c739b878so1175052b3a.1 for ; Wed, 19 Jun 2024 19:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718851696; x=1719456496; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A8pSmz1Mo9Hb1eoGtaIX7FxiMbjYzcDmeVvWVqMFm1M=; b=ydD08ZoOOd9a3i5M4+OheAiS+2MpGD+EwghNdfEb27nAHtcmr6PbhkvCA2NLfRCLmD SydAJAsFWgh35RZy454b5WvqGohUxxQeQYX0CSG83Eti/hwmdrLBmLVq42TuQk7YZ1WA ktxFgmBIhubZoLhGQyE+v04Ih9EOzVSpJCpPOmQisG/+mcnKbbs6MLa+WoQdIiiKVilr xx1mq/riN1FBjKbkrnNy7qUacYJqrOEhe3M49zbD2uhMEZs3Jf+RyCdqUDKrEMjjB4QM rEhoXM0d7CGBsyDTpHA4am95RqewNglDr69tnZxZWQYnsek/Cnj8xGv6J3GxywUAzq6C MdXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718851696; x=1719456496; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A8pSmz1Mo9Hb1eoGtaIX7FxiMbjYzcDmeVvWVqMFm1M=; b=PBsU4sBGDjJLy3qVqO2ivOi0/Ok22t4Zhg390113AH1uCcrxKDSxEUFjEjcxBhTRvJ njpN99ejRHnKlce875aYPIGLpuw7Nw1MqjvrfF/zCEdSJnDofObgifzI7lbWvJSBiMzy F1HJxc2V/wMii2XEyjd1j/iQLkFrjOBrLND4u7FGgSdaWsg6Sog0n3Y/k2g2JWlDHDCn 7uK7v4NhoFvzYDXJQRr+notLKULgwKIvc3hi493eeTsbO9u+bM8Ll6xbUrrcI1zgBEe4 vGdqlFNBoRU0FNFXK7N5UCDSCcU6NBBlBkZeGVLLeOSlTwY2YowCtWAu5/46eRsQ23jz 7smw== X-Forwarded-Encrypted: i=1; AJvYcCWHDYr1l9pehj5BX/ixXKIchxSa08TGS4KihwaazVfQHxbh4XMB/I4zroBVOu+fRrCGAY5f/c7bTjsbCiQiUCc/AJ8B5+I= X-Gm-Message-State: AOJu0Yw8iGE2MkpFy0nRYSAVO3cBxXbDLnNk7sCOFMYEu9rvDmpTyu+T l9NCrWDPQPywkS581CKFs2+8Cj7IutLb+W3xOK0cEqjngahAuQw6HI83MEghycw= X-Google-Smtp-Source: AGHT+IE8n840oSp3OQ46rKjT5PQ+SAqe+DC6ISXS+z+i4WqZWa/VnyUIPMgiiM/AkYAZ7RnoFOwZaQ== X-Received: by 2002:a05:6a20:3b98:b0:1b8:af57:7bba with SMTP id adf61e73a8af0-1bcba179d0dmr5627353637.15.1718851695995; Wed, 19 Jun 2024 19:48:15 -0700 (PDT) Received: from [192.168.0.4] ([71.212.132.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-706352ea4f0sm1830146b3a.211.2024.06.19.19.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jun 2024 19:48:15 -0700 (PDT) Message-ID: <1580f5f3-968e-4aed-916b-d3d5b5ee0cc7@linaro.org> Date: Wed, 19 Jun 2024 19:48:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 1/5] accel/tcg: Avoid unnecessary call overhead from qemu_plugin_vcpu_mem_cb To: Max Chou , qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: Paolo Bonzini , Palmer Dabbelt , Alistair Francis , Bin Meng , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei References: <20240613175122.1299212-1-max.chou@sifive.com> <20240613175122.1299212-2-max.chou@sifive.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240613175122.1299212-2-max.chou@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/13/24 10:51, Max Chou wrote: > If there are not any QEMU plugin memory callback functions, checking > before calling the qemu_plugin_vcpu_mem_cb function can reduce the > function call overhead. > > Signed-off-by: Max Chou > --- > accel/tcg/ldst_common.c.inc | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~