From: no-reply@patchew.org
To: ysato@users.sourceforge.jp
Cc: philmd@redhat.com, richard.henderson@linaro.org,
qemu-devel@nongnu.org, ysato@users.sourceforge.jp
Subject: Re: [PATCH v30 00/22] Add RX archtecture support
Date: Wed, 12 Feb 2020 07:08:08 -0800 (PST) [thread overview]
Message-ID: <158152008751.15549.4309594566013312966@a1bbccc8075a> (raw)
In-Reply-To: <20200212130311.127515-1-ysato@users.sourceforge.jp>
Patchew URL: https://patchew.org/QEMU/20200212130311.127515-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: 20200212130311.127515-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200212130311.127515-1-ysato@users.sourceforge.jp -> patchew/20200212130311.127515-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
742aed2 qemu-doc.texi: Add RX section.
f8dc41e BootLinuxConsoleTest: Test the RX-Virt machine
37414e6 Add rx-softmmu
6bad46f hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
b6f9774 hw/rx: Honor -accel qtest
38bc73d hw/rx: RX Target hardware definition
f224df0 hw/char: RX62N serial communication interface (SCI)
ccd39c6 hw/timer: RX62N internal timer modules
3999489 hw/intc: RX62N interrupt controller (ICUa)
aa8d683 target/rx: Dump bytes for each insn during disassembly
8215d23 target/rx: Collect all bytes during disassembly
595382d target/rx: Emit all disassembly in one prt()
c722e15 target/rx: Use prt_ldmi for XCHG_mr disassembly
be31b82 target/rx: Replace operand with prt_ldmi in disassembler
90b054c target/rx: Disassemble rx_index_addr into a string
f2802e4 target/rx: RX disassembler
cb4c947 target/rx: CPU definition
5782455 target/rx: TCG helper
5435b95 target/rx: TCG translation
92c8a93 hw/registerfields.h: Add 8bit and 16bit register macros
ca806d1 qemu/bitops.h: Add extract8 and extract16
5239516 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 5239516cc8f1 (MAINTAINERS: Add RX)
2/22 Checking commit ca806d1ba65e (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 92c8a93e24b2 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 5435b951d5f6 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 5782455eda42 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit cb4c94748de8 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit f2802e4c7970 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 90b054c90463 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit be31b8271561 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit c722e1591484 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 595382d7f38d (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 8215d23159cd (target/rx: Collect all bytes during disassembly)
13/22 Checking commit aa8d68395ec1 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 399948948c03 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit ccd39c643aa0 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit f224df014e23 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 38bc73d05b17 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+ $
ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into $
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 2 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit b6f9774f8996 (hw/rx: Honor -accel qtest)
19/22 Checking commit 6bad46f6bb12 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 37414e62f6b4 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 83 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit f8dc41e6173c (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 742aed21ef10 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200212130311.127515-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
next prev parent reply other threads:[~2020-02-12 15:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 13:02 [PATCH v30 00/22] Add RX archtecture support Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 01/22] MAINTAINERS: Add RX Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 02/22] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 03/22] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 04/22] target/rx: TCG translation Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 05/22] target/rx: TCG helper Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 06/22] target/rx: CPU definition Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 07/22] target/rx: RX disassembler Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 08/22] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 09/22] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2020-02-12 13:02 ` [PATCH v30 10/22] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 11/22] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 12/22] target/rx: Collect all bytes during disassembly Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 13/22] target/rx: Dump bytes for each insn " Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 14/22] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 15/22] hw/timer: RX62N internal timer modules Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 16/22] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 17/22] hw/rx: RX Target hardware definition Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 18/22] hw/rx: Honor -accel qtest Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 19/22] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 20/22] Add rx-softmmu Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 21/22] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
2020-02-12 13:03 ` [PATCH v30 22/22] qemu-doc.texi: Add RX section Yoshinori Sato
2020-02-12 13:22 ` [PATCH v30 00/22] Add RX archtecture support no-reply
2020-02-12 13:39 ` no-reply
2020-02-12 13:55 ` no-reply
2020-02-12 14:43 ` no-reply
2020-02-12 14:57 ` no-reply
2020-02-12 15:08 ` no-reply [this message]
2020-02-12 15:15 ` no-reply
2020-02-12 15:25 ` no-reply
2020-02-12 15:52 ` no-reply
2020-02-12 16:03 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158152008751.15549.4309594566013312966@a1bbccc8075a \
--to=no-reply@patchew.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).