From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C2ABC35DF5 for ; Tue, 25 Feb 2020 12:49:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB15220726 for ; Tue, 25 Feb 2020 12:49:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NR+2lnAl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB15220726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Ze2-00083P-0S for qemu-devel@archiver.kernel.org; Tue, 25 Feb 2020 07:49:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Z02-0003Ko-Gb for qemu-devel@nongnu.org; Tue, 25 Feb 2020 07:07:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6Z01-0003Pi-GO for qemu-devel@nongnu.org; Tue, 25 Feb 2020 07:07:42 -0500 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:44963) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6Z01-0003PD-A2 for qemu-devel@nongnu.org; Tue, 25 Feb 2020 07:07:41 -0500 Received: by mail-wr1-x432.google.com with SMTP id m16so14393964wrx.11 for ; Tue, 25 Feb 2020 04:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4Z/yNtPxigyaL8YUlyqEJe5pD5b0faME2lrPsUwrRk4=; b=NR+2lnAlHnwLhEQhDEiPM1ULw8LYIiZWe2DEER8cx2lrbajx7VSfhV5GSslhffpl84 s1yIXPJJK/mDA4RGF0W56bdvew1xF/fUxy+uBMLEPXoXXHNw+6QyQYQ3c9yy9guvNeq8 QJss8MrEVk3Mjh5HCtJDa/DdMhhFT5LaCVI9m7AyBYWmonV0t1YJwK0112E37ngb0oyl eJ4CfMTE2PYsXVMgRDYAvapwsaFxNg5bwI8gzMByn1e299CeaN7XVbdqR0SdQPDf1f1y yl3XCfG45aFMigAMMHOjX4jA7wSzniOlx3uI/7NC+IGti2/6QPu5KXu38F34EENEHXK+ VKnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=4Z/yNtPxigyaL8YUlyqEJe5pD5b0faME2lrPsUwrRk4=; b=VTfbNy/c4BLqGmKhrtsDMcXPUaMbV6fl5Gw6NZj2XsplWjmSsYXjvU/8X+tDzm9KYo JOy7JtChqdnpWktTYs7oEaeYtuCLydgYagKG67WojR6koAuEknuaPLbllku7f9Wnc2UK Tldym8ZODCmzf54W2Cn3WOFnPqAKNqd8mWnOpTejTpzGcoeRagMRXOgkzUPMrslgrG+O x7TIMbTPZPzQPaEfGHC1FuIrv7LsH8L/FvyIinZs796YMUWxCVW12W+E9ZxM6HjeemaS c7vhakda9SzfYFrRElQXDD84pfA5z3s/jFU2VUGfK7NShV7Gn6Mxq1m87vwP4x23vxX+ gEoQ== X-Gm-Message-State: APjAAAWmQsWsr5BOxknh38iIn06BEo++VTnuZtFT0ntc/xY58kMZYGaw vOeVxzE/kP54IK5oslUjAFnYqnMc X-Google-Smtp-Source: APXvYqwPoLtsG8KjWDJSVnKHRM0rlDisKHgHUbNmmgSN5kmQ64aPtL04YC4+hj+wYkb8rRNYrjZlEA== X-Received: by 2002:a5d:4f01:: with SMTP id c1mr22068183wru.384.1582632460117; Tue, 25 Feb 2020 04:07:40 -0800 (PST) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id h13sm22709423wrw.54.2020.02.25.04.07.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Feb 2020 04:07:38 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 106/136] hw/m68k: Use memory_region_init_rom() with read-only regions Date: Tue, 25 Feb 2020 13:07:04 +0100 Message-Id: <1582632454-16491-4-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1582631466-13880-1-git-send-email-pbonzini@redhat.com> References: <1582631466-13880-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::432 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200224205533.23798-9-philmd@redhat.com> Supersedes: <20200221173049.18134-1-philmd@redhat.com> --- hw/m68k/q800.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index 1e32363..8083326 100644 --- a/hw/m68k/q800.c +++ b/hw/m68k/q800.c @@ -402,13 +402,12 @@ static void q800_init(MachineState *machine) uint8_t *ptr; /* allocate and load BIOS */ rom = g_malloc(sizeof(*rom)); - memory_region_init_ram(rom, NULL, "m68k_mac.rom", MACROM_SIZE, + memory_region_init_rom(rom, NULL, "m68k_mac.rom", MACROM_SIZE, &error_abort); if (bios_name == NULL) { bios_name = MACROM_FILENAME; } filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); - memory_region_set_readonly(rom, true); memory_region_add_subregion(get_system_memory(), MACROM_ADDR, rom); /* Load MacROM binary */ -- 1.8.3.1