From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CE0C35DE1 for ; Tue, 25 Feb 2020 12:35:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D15ED218AC for ; Tue, 25 Feb 2020 12:35:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FOXAv+ho" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D15ED218AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6ZQX-0004EE-UE for qemu-devel@archiver.kernel.org; Tue, 25 Feb 2020 07:35:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52491) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Z08-0003RG-Df for qemu-devel@nongnu.org; Tue, 25 Feb 2020 07:07:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6Z07-0003Sp-BY for qemu-devel@nongnu.org; Tue, 25 Feb 2020 07:07:48 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:41247) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j6Z07-0003RE-42 for qemu-devel@nongnu.org; Tue, 25 Feb 2020 07:07:47 -0500 Received: by mail-wr1-x433.google.com with SMTP id v4so1568155wrs.8 for ; Tue, 25 Feb 2020 04:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JmVYAUKx6B4rcfz1Vmk6J2gsBKmOvTNh7f2tEhi9Rek=; b=FOXAv+hoW1Pd3+NWBe598EfNlATXYOAa1/rERLk4SEfQy9EsMGklE3YH1lVMzMikj1 16rw0GjiTWvNsws4M+AvRP5sW8T7sOG3Mw8L3LNIfMGhaS9tZowSb1KF7f3tgFl1hixm 80srAaJ+EGOnExjLMphtLhOGXlZOQgt8ivD9EN2rDUdu6a5lt7FNkR8PBvXUmx8rNq5U 4OW28fKDp/JRwerw1TCLBjRusPT5iOs2TMwjb9h8tkfqzxP/iTD35dkbRw3jt4HHglGA ZJPaPZF+Hw2dsRXACOajrIFEhbPLKA7EMELTZhIxjMdHn+9JjGP0vU1ecFJsJoViZWN4 LEFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JmVYAUKx6B4rcfz1Vmk6J2gsBKmOvTNh7f2tEhi9Rek=; b=bEgx2wSizMwb6xft2r7i9rF1Zlwa/9V7BGhxaf0UM+R6ah922NAXvWldhe61QdV8Mu Rvt8/0ffVWv6OJJ85kvlI8uRGXQGbj5UScs94rhvb/bH9SFlz2D+gkp8DK0/fdFspqey zwXtNqgPs7vNodjhPM5A8vjlXLn+W150wXvjS1LSxwsoxqNuh9NoZjKouxHODRmL9knn LSJPUylIDagUFdH7kzpDEGyVUyxiM+c84i4DzJHLhbnYc9zhgNIlUYYjnpA6Z0RsBc/t 4VLiYi611jCRULRT10DW6BQuCFxqmC8xT/1acN1uVrwloSYmsyfGiyL9CHS8wKWoUqeV HoFQ== X-Gm-Message-State: APjAAAUxr9+x+XoV7ZB5bDh06z5Mk/odDZ3F/bPsY9kCxVR/WBisgwNQ tGdUUY91mAD6etTQStMBtN22lpQj X-Google-Smtp-Source: APXvYqxCFrilPWDeAc1Pn+tAIpRQY1PWLo/xRDsczKzQX1sCEuxYmMRDOqEm6vTzVgi/tU38B9qXrw== X-Received: by 2002:adf:ef4c:: with SMTP id c12mr74495277wrp.203.1582632463895; Tue, 25 Feb 2020 04:07:43 -0800 (PST) Received: from 640k.localdomain ([93.56.166.5]) by smtp.gmail.com with ESMTPSA id h13sm22709423wrw.54.2020.02.25.04.07.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Feb 2020 04:07:43 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 110/136] hw/riscv: Use memory_region_init_rom() with read-only regions Date: Tue, 25 Feb 2020 13:07:08 +0100 Message-Id: <1582632454-16491-8-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1582631466-13880-1-git-send-email-pbonzini@redhat.com> References: <1582631466-13880-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::433 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20200224205533.23798-13-philmd@redhat.com> Supersedes: <20200221173049.18134-1-philmd@redhat.com> --- hw/riscv/sifive_e.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index 8a6b034..6f6360a 100644 --- a/hw/riscv/sifive_e.c +++ b/hw/riscv/sifive_e.c @@ -208,9 +208,8 @@ static void riscv_sifive_e_soc_realize(DeviceState *dev, Error **errp) memmap[SIFIVE_E_PWM2].base, memmap[SIFIVE_E_PWM2].size); /* Flash memory */ - memory_region_init_ram(&s->xip_mem, NULL, "riscv.sifive.e.xip", - memmap[SIFIVE_E_XIP].size, &error_fatal); - memory_region_set_readonly(&s->xip_mem, true); + memory_region_init_rom(&s->xip_mem, NULL, "riscv.sifive.e.xip", + memmap[SIFIVE_E_XIP].size, &error_fatal); memory_region_add_subregion(sys_mem, memmap[SIFIVE_E_XIP].base, &s->xip_mem); } -- 1.8.3.1