qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Huacai Chen <chenhc@lemote.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: kvm@vger.kernel.org, Huacai Chen <chenhuacai@gmail.com>,
	qemu-devel@nongnu.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
	linux-mips@vger.kernel.org, Fuxin Zhang <zhangfx@lemote.com>,
	Huacai Chen <chenhc@lemote.com>,
	Mike Rapoport <rppt@linux.ibm.com>
Subject: [PATCH 01/15] mips: define pud_index() regardless of page table folding
Date: Mon, 13 Apr 2020 15:30:10 +0800	[thread overview]
Message-ID: <1586763024-12197-2-git-send-email-chenhc@lemote.com> (raw)
In-Reply-To: <1586763024-12197-1-git-send-email-chenhc@lemote.com>

From: Mike Rapoport <rppt@linux.ibm.com>

Commit 31168f033e37 ("mips: drop __pXd_offset() macros that duplicate
pXd_index() ones") is correct that pud_index() & __pud_offset() are the
same when pud_index() is actually provided, however it does not take into
account the __PAGETABLE_PUD_FOLDED case. This has broken MIPS KVM
compilation because it relied on availability of pud_index().

Define pud_index() regardless of page table folded. It will evaluate to
actual index for 4-level pagetables and to 0 for folded PUD level.

Link: https://lore.kernel.org/lkml/20200331154749.5457-1-pbonzini@redhat.com
Tested-by: Bibo Mao <maobibo@loongson.cn>
Tested-by: Huacai Chen <chenhc@lemote.com>
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
[Huacai: Add Tested-by and take this patch into my series, because my
         series can't build an available kernel if without this patch.]
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 arch/mips/include/asm/pgtable-64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/include/asm/pgtable-64.h b/arch/mips/include/asm/pgtable-64.h
index f92716c..ee5dc0c 100644
--- a/arch/mips/include/asm/pgtable-64.h
+++ b/arch/mips/include/asm/pgtable-64.h
@@ -172,6 +172,8 @@
 
 extern pte_t invalid_pte_table[PTRS_PER_PTE];
 
+#define pud_index(address)	(((address) >> PUD_SHIFT) & (PTRS_PER_PUD - 1))
+
 #ifndef __PAGETABLE_PUD_FOLDED
 /*
  * For 4-level pagetables we defines these ourselves, for 3-level the
@@ -210,8 +212,6 @@ static inline void p4d_clear(p4d_t *p4dp)
 	p4d_val(*p4dp) = (unsigned long)invalid_pud_table;
 }
 
-#define pud_index(address)	(((address) >> PUD_SHIFT) & (PTRS_PER_PUD - 1))
-
 static inline unsigned long p4d_page_vaddr(p4d_t p4d)
 {
 	return p4d_val(p4d);
-- 
2.7.0



  reply	other threads:[~2020-04-13  7:22 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13  7:30 [PATCH 0/15] KVM: MIPS: Add Loongson-3 support (Host Side) Huacai Chen
2020-04-13  7:30 ` Huacai Chen [this message]
2020-04-13  7:30 ` [PATCH 02/15] KVM: MIPS: Define KVM_ENTRYHI_ASID to cpu_asid_mask(&boot_cpu_data) Huacai Chen
2020-04-21 19:56   ` Sasha Levin
2020-04-22  4:40     ` chen huacai
2020-04-13  7:30 ` [PATCH 03/15] KVM: MIPS: Fix VPN2_MASK definition for variable cpu_vmbits Huacai Chen
2020-04-21 19:56   ` Sasha Levin
2020-04-22  4:40     ` chen huacai
2020-04-13  7:30 ` [PATCH 04/15] KVM: MIPS: Increase KVM_MAX_VCPUS and KVM_USER_MEM_SLOTS to 16 Huacai Chen
2020-04-13  7:30 ` [PATCH 05/15] KVM: MIPS: Add EVENTFD support which is needed by VHOST Huacai Chen
2020-04-13  7:30 ` [PATCH 06/15] KVM: MIPS: Use lddir/ldpte instructions to lookup gpa_mm.pgd Huacai Chen
2020-04-13  7:30 ` [PATCH 07/15] KVM: MIPS: Introduce and use cpu_guest_has_ldpte Huacai Chen
2020-04-13  7:30 ` [PATCH 08/15] KVM: MIPS: Use root tlb to control guest's CCA for Loongson-3 Huacai Chen
2020-04-13  7:30 ` [PATCH 09/15] KVM: MIPS: Let indexed cacheops cause guest exit on Loongson-3 Huacai Chen
2020-04-13  7:30 ` [PATCH 10/15] KVM: MIPS: Add more types of virtual interrupts Huacai Chen
2020-04-13  7:30 ` [PATCH 11/15] KVM: MIPS: Add Loongson-3 Virtual IPI interrupt support Huacai Chen
2020-04-13  7:30 ` [PATCH 12/15] KVM: MIPS: Add CPUCFG emulation for Loongson-3 Huacai Chen
2020-04-13  7:30 ` [PATCH 13/15] KVM: MIPS: Add CONFIG6 and DIAG registers emulation Huacai Chen
2020-04-13 11:19   ` Jiaxun Yang
2020-04-19  9:58     ` Huacai Chen
2020-04-13  7:30 ` [PATCH 14/15] KVM: MIPS: Add more MMIO load/store instructions emulation Huacai Chen
2020-04-13  7:30 ` [PATCH 15/15] KVM: MIPS: Enable KVM support for Loongson-3 Huacai Chen
2020-04-13  8:18 ` [PATCH 0/15] KVM: MIPS: Add Loongson-3 support (Host Side) Jiaxun Yang
2020-04-13  9:20   ` Huacai Chen
2020-04-14  1:40   ` maobibo
2020-04-14  4:44     ` Jiaxun Yang
2020-04-19  9:42       ` Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1586763024-12197-2-git-send-email-chenhc@lemote.com \
    --to=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=jiaxun.yang@flygoat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rppt@linux.ibm.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=zhangfx@lemote.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).