From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4FE4C2BA19 for ; Wed, 15 Apr 2020 11:47:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD95B214D8 for ; Wed, 15 Apr 2020 11:47:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD95B214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bitdefender.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOgWB-0004zp-Qj for qemu-devel@archiver.kernel.org; Wed, 15 Apr 2020 07:47:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52447) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOgVV-0004aQ-EA for qemu-devel@nongnu.org; Wed, 15 Apr 2020 07:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOgVS-0001kv-QW for qemu-devel@nongnu.org; Wed, 15 Apr 2020 07:47:03 -0400 Received: from mx01.bbu.dsd.mx.bitdefender.com ([91.199.104.161]:60074) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOgVS-0001kD-Jd for qemu-devel@nongnu.org; Wed, 15 Apr 2020 07:47:02 -0400 Received: from smtp.bitdefender.com (smtp01.buh.bitdefender.com [10.17.80.75]) by mx01.bbu.dsd.mx.bitdefender.com (Postfix) with ESMTPS id 5E7BD306E47C; Wed, 15 Apr 2020 14:47:00 +0300 (EEST) Received: from localhost (unknown [91.199.104.27]) by smtp.bitdefender.com (Postfix) with ESMTPSA id 448DB301B931; Wed, 15 Apr 2020 14:47:00 +0300 (EEST) From: Adalbert =?iso-8859-2?b?TGF643I=?= Subject: Re: [RFC PATCH v1 03/26] char-socket: fix the client mode when created through QMP To: =?iso-8859-1?q?Marc-Andr=E9?= Lureau In-Reply-To: References: <20200415005938.23895-1-alazar@bitdefender.com> <20200415005938.23895-4-alazar@bitdefender.com> Date: Wed, 15 Apr 2020 14:47:26 +0300 Message-ID: <15869512460.BE82bEee.22517@host> User-agent: void Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 91.199.104.161 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 15 Apr 2020 12:37:34 +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Wed, Apr 15, 2020 at 3:00 AM Adalbert Laz=C4=83r wrote: > > > > qmp_chardev_open_socket() ignores the absence of the 'server' argumen= t > > and always switches to listen/server mode. > > > > CC: "Marc-Andr=C3=A9 Lureau" > > CC: Paolo Bonzini > > Signed-off-by: Adalbert Laz=C4=83r > > --- > > chardev/char-socket.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > > index 9b2deb0125..fd0106ab85 100644 > > --- a/chardev/char-socket.c > > +++ b/chardev/char-socket.c > > @@ -1310,7 +1310,7 @@ static void qmp_chardev_open_socket(Chardev *ch= r, > > SocketChardev *s =3D SOCKET_CHARDEV(chr); > > ChardevSocket *sock =3D backend->u.socket.data; > > bool do_nodelay =3D sock->has_nodelay ? sock->nodelay : fals= e; > > - bool is_listen =3D sock->has_server ? sock->server : true= ; > > + bool is_listen =3D sock->has_server ? sock->server : fals= e; >=20 > I don't understand what you mean. It defaults to server mode. We can't > change that. First of all, thanks for your comments. I understand that a chardev socket is either in client mode or in server mode. If the 'server' parameter is not used, the socket is put in client mode. At least this is the behavior when the socket is created by parsing the command line. But, when created through QMP, without the 'server' par= ameter, the socket is put in server mode. Until this moment, I did not think that we can use "server=3Dno" through = QMP :)) So, yes. We may create the socket in client mode through QMP without this= patch. >=20 > > bool is_telnet =3D sock->has_telnet ? sock->telnet : fals= e; > > bool is_tn3270 =3D sock->has_tn3270 ? sock->tn3270 : fals= e; > > bool is_waitconnect =3D sock->has_wait ? sock->wait : fals= e; > > >=20 >=20 > --=20 > Marc-Andr=C3=A9 Lureau >=20