From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4140CC2BB55 for ; Wed, 15 Apr 2020 12:30:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 149AB2078A for ; Wed, 15 Apr 2020 12:30:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 149AB2078A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bitdefender.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOhBc-0003Tl-9d for qemu-devel@archiver.kernel.org; Wed, 15 Apr 2020 08:30:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57600) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOh9a-0001jC-QG for qemu-devel@nongnu.org; Wed, 15 Apr 2020 08:28:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOh9Z-0005Ed-EU for qemu-devel@nongnu.org; Wed, 15 Apr 2020 08:28:30 -0400 Received: from mx01.bbu.dsd.mx.bitdefender.com ([91.199.104.161]:32774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOh9Z-0005E9-7h for qemu-devel@nongnu.org; Wed, 15 Apr 2020 08:28:29 -0400 Received: from smtp.bitdefender.com (smtp02.buh.bitdefender.net [10.17.80.76]) by mx01.bbu.dsd.mx.bitdefender.com (Postfix) with ESMTPS id 28F40306E47C; Wed, 15 Apr 2020 15:28:27 +0300 (EEST) Received: from localhost (unknown [89.136.169.210]) by smtp.bitdefender.com (Postfix) with ESMTPSA id 0FAE1305B7A0; Wed, 15 Apr 2020 15:28:27 +0300 (EEST) From: Adalbert =?iso-8859-2?b?TGF643I=?= Subject: Re: [RFC PATCH v1 04/26] char-socket: add 'reconnecting' property To: =?iso-8859-1?q?Marc-Andr=E9?= Lureau In-Reply-To: References: <20200415005938.23895-1-alazar@bitdefender.com> <20200415005938.23895-5-alazar@bitdefender.com> Date: Wed, 15 Apr 2020 15:28:53 +0300 Message-ID: <15869537330.eB2a5.30082@host> User-agent: void Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 91.199.104.161 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 15 Apr 2020 12:46:57 +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Wed, Apr 15, 2020 at 3:03 AM Adalbert Laz=C4=83r wrote: > > > > This is used by the VM introspection object to check if the connectio= n > > will be reestablished in case it disconnects from some reason. > > > > The closing of the socket is used by any of the three parties involve= d, > > KVM, the introspection tool and QEMU (eg. on force-reset), to signal > > the other parties that the session is over. As such, it is very impor= tant > > that the socket will reconnect. > > > > CC: "Marc-Andr=C3=A9 Lureau" > > CC: Paolo Bonzini > > Signed-off-by: Adalbert Laz=C4=83r > > --- > > chardev/char-socket.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/chardev/char-socket.c b/chardev/char-socket.c > > index fd0106ab85..22ab242748 100644 > > --- a/chardev/char-socket.c > > +++ b/chardev/char-socket.c > > @@ -1492,6 +1492,13 @@ char_socket_get_connected(Object *obj, Error *= *errp) > > return s->state =3D=3D TCP_CHARDEV_STATE_CONNECTED; > > } > > > > +static bool char_socket_get_reconnecting(Object *obj, Error **errp) > > +{ > > + SocketChardev *s =3D SOCKET_CHARDEV(obj); > > + > > + return s->reconnect_time > 0; > > +} > > + > > static int tcp_chr_reconnect_time(Chardev *chr, int secs) > > { > > SocketChardev *s =3D SOCKET_CHARDEV(chr); > > @@ -1528,6 +1535,10 @@ static void char_socket_class_init(ObjectClass= *oc, void *data) > > > > object_class_property_add_bool(oc, "connected", char_socket_get_= connected, > > NULL, &error_abort); > > + > > + object_class_property_add_bool(oc, "reconnecting", > > + char_socket_get_reconnecting, > > + NULL, &error_abort); >=20 > That may be misleading, as the socket connection may be established > and this will return true if reconnect_time > 0. Why not have a > "reconnect-time" property instead? >=20 Sure. Thanks.