From: Bin Meng <bmeng.cn@gmail.com>
To: Alistair Francis <Alistair.Francis@wdc.com>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Palmer Dabbelt <palmerdabbelt@google.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Bin Meng <bin.meng@windriver.com>, Anup Patel <Anup.Patel@wdc.com>
Subject: [PATCH 4/5] riscv/spike: Change the default bios to use generic platform image
Date: Fri, 1 May 2020 08:50:53 -0700 [thread overview]
Message-ID: <1588348254-7241-5-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1588348254-7241-1-git-send-email-bmeng.cn@gmail.com>
From: Bin Meng <bin.meng@windriver.com>
To keep sync with other RISC-V machines, change the default bios
to use generic platform image.
While we are here, add some comments to mention that keeping ELF
files here was intentional.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
hw/riscv/spike.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
index d0c4843..6f26fcf 100644
--- a/hw/riscv/spike.c
+++ b/hw/riscv/spike.c
@@ -45,10 +45,15 @@
#include <libfdt.h>
+/*
+ * Not like other RISC-V machines that use plain binary bios images,
+ * keeping ELF files here was intentional because BIN files don't work
+ * for the Spike machine as HTIF emulation depends on ELF parsing.
+ */
#if defined(TARGET_RISCV32)
-# define BIOS_FILENAME "opensbi-riscv32-spike-fw_jump.elf"
+# define BIOS_FILENAME "opensbi-riscv32-generic-fw_jump.elf"
#else
-# define BIOS_FILENAME "opensbi-riscv64-spike-fw_jump.elf"
+# define BIOS_FILENAME "opensbi-riscv64-generic-fw_jump.elf"
#endif
static const struct MemmapEntry {
--
2.7.4
next prev parent reply other threads:[~2020-05-01 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 15:50 [PATCH 0/5] riscv: Switch to use generic platform of opensbi bios images Bin Meng
2020-05-01 15:50 ` [PATCH 1/5] roms/opensbi: Update to support building bios images for generic platform Bin Meng
2020-05-03 4:38 ` Anup Patel
2020-05-04 7:16 ` Bin Meng
2020-05-04 7:51 ` Anup Patel
2020-05-04 8:00 ` Bin Meng
2020-05-04 8:04 ` Bin Meng
2020-05-04 8:16 ` Anup Patel
2020-05-04 15:51 ` Alistair Francis
2020-05-06 10:00 ` Bin Meng
2020-05-01 15:50 ` [PATCH 2/5] gitlab-ci/opensbi: Update GitLab CI to build " Bin Meng
2020-05-03 4:40 ` Anup Patel
2020-05-01 15:50 ` [PATCH 3/5] riscv: Use pre-built bios image of generic platform for virt & sifive_u Bin Meng
2020-05-03 4:43 ` Anup Patel
2020-05-04 15:53 ` Alistair Francis
2020-05-01 15:50 ` Bin Meng [this message]
2020-05-03 4:41 ` [PATCH 4/5] riscv/spike: Change the default bios to use generic platform image Anup Patel
2020-05-04 15:54 ` Alistair Francis
2020-05-01 15:50 ` [PATCH 5/5] riscv: Suppress the error report for QEMU testing with riscv_find_firmware() Bin Meng
2020-05-03 4:44 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588348254-7241-5-git-send-email-bmeng.cn@gmail.com \
--to=bmeng.cn@gmail.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=bin.meng@windriver.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmerdabbelt@google.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).