From: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: aleksandar.qemu.devel@gmail.com
Subject: [PULL 19/21] hw/mips: Implement the kvm_type() hook in MachineClass
Date: Sun, 7 Jun 2020 21:46:23 +0200 [thread overview]
Message-ID: <1591559185-31287-20-git-send-email-aleksandar.qemu.devel@gmail.com> (raw)
In-Reply-To: <1591559185-31287-1-git-send-email-aleksandar.qemu.devel@gmail.com>
From: Huacai Chen <zltjiangshi@gmail.com>
MIPS has two types of KVM: TE & VZ, and TE is the default type. Now we
can't create a VZ guest in QEMU because it lacks the kvm_type() hook in
MachineClass. Besides, libvirt uses a null-machine to detect the kvm
capability, so by default it will return "KVM not supported" on a VZ
platform. Thus, null-machine also need the kvm_type() hook.
Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Co-developed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Message-Id: <1591065557-9174-2-git-send-email-chenhc@lemote.com>
---
include/hw/mips/mips.h | 3 +++
hw/core/null-machine.c | 4 ++++
hw/mips/common.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++
hw/core/Makefile.objs | 2 +-
hw/mips/Makefile.objs | 2 +-
5 files changed, 64 insertions(+), 2 deletions(-)
create mode 100644 hw/mips/common.c
diff --git a/include/hw/mips/mips.h b/include/hw/mips/mips.h
index 0af4c3d..2ac0580 100644
--- a/include/hw/mips/mips.h
+++ b/include/hw/mips/mips.h
@@ -20,4 +20,7 @@ void rc4030_dma_write(void *dma, uint8_t *buf, int len);
DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr);
+/* common.c */
+int mips_kvm_type(MachineState *machine, const char *vm_type);
+
#endif
diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
index cb47d9d..94a36f9 100644
--- a/hw/core/null-machine.c
+++ b/hw/core/null-machine.c
@@ -17,6 +17,7 @@
#include "sysemu/sysemu.h"
#include "exec/address-spaces.h"
#include "hw/core/cpu.h"
+#include "hw/mips/mips.h"
static void machine_none_init(MachineState *mch)
{
@@ -50,6 +51,9 @@ static void machine_none_machine_init(MachineClass *mc)
mc->max_cpus = 1;
mc->default_ram_size = 0;
mc->default_ram_id = "ram";
+#ifdef TARGET_MIPS
+ mc->kvm_type = mips_kvm_type;
+#endif
}
DEFINE_MACHINE("none", machine_none_machine_init)
diff --git a/hw/mips/common.c b/hw/mips/common.c
new file mode 100644
index 0000000..fd7e10a
--- /dev/null
+++ b/hw/mips/common.c
@@ -0,0 +1,55 @@
+/*
+ * Common MIPS routines
+ *
+ * Copyright (C) 2020 Huacai Chen <chenhc@lemote.com>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <https://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <linux/kvm.h>
+#include "qemu/osdep.h"
+#include "qemu-common.h"
+#include "hw/boards.h"
+#include "hw/mips/mips.h"
+#include "sysemu/kvm_int.h"
+
+#ifndef CONFIG_KVM
+
+int mips_kvm_type(MachineState *machine, const char *vm_type)
+{
+ return 0;
+}
+
+#else
+
+int mips_kvm_type(MachineState *machine, const char *vm_type)
+{
+ int r;
+ KVMState *s = KVM_STATE(machine->accelerator);
+
+ r = kvm_check_extension(s, KVM_CAP_MIPS_VZ);
+ if (r > 0) {
+ return KVM_VM_MIPS_VZ;
+ }
+
+ r = kvm_check_extension(s, KVM_CAP_MIPS_TE);
+ if (r > 0) {
+ return KVM_VM_MIPS_TE;
+ }
+
+ return -1;
+}
+
+#endif
diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
index 1d540ed..b5672f4 100644
--- a/hw/core/Makefile.objs
+++ b/hw/core/Makefile.objs
@@ -17,11 +17,11 @@ common-obj-$(CONFIG_SOFTMMU) += vm-change-state-handler.o
common-obj-$(CONFIG_SOFTMMU) += qdev-properties-system.o
common-obj-$(CONFIG_SOFTMMU) += sysbus.o
common-obj-$(CONFIG_SOFTMMU) += machine.o
-common-obj-$(CONFIG_SOFTMMU) += null-machine.o
common-obj-$(CONFIG_SOFTMMU) += loader.o
common-obj-$(CONFIG_SOFTMMU) += machine-hmp-cmds.o
common-obj-$(CONFIG_SOFTMMU) += numa.o
common-obj-$(CONFIG_SOFTMMU) += clock-vmstate.o
+obj-$(CONFIG_SOFTMMU) += null-machine.o
obj-$(CONFIG_SOFTMMU) += machine-qmp-cmds.o
common-obj-$(CONFIG_EMPTY_SLOT) += empty_slot.o
diff --git a/hw/mips/Makefile.objs b/hw/mips/Makefile.objs
index 739e2b7..3b3e6ea 100644
--- a/hw/mips/Makefile.objs
+++ b/hw/mips/Makefile.objs
@@ -1,4 +1,4 @@
-obj-y += addr.o mips_int.o
+obj-y += addr.o common.o mips_int.o
obj-$(CONFIG_R4K) += r4k.o
obj-$(CONFIG_MALTA) += gt64xxx_pci.o malta.o
obj-$(CONFIG_MIPSSIM) += mipssim.o
--
2.7.4
next prev parent reply other threads:[~2020-06-07 19:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 19:46 [PULL 00/21] MIPS queue for June 7th, 2020 Aleksandar Markovic
2020-06-07 19:46 ` [PULL 01/21] mailmap: Change email address of Filip Bozuta Aleksandar Markovic
2020-06-07 19:46 ` [PULL 02/21] mailmap: Change email address of Stefan Brankovic Aleksandar Markovic
2020-06-07 19:46 ` [PULL 03/21] target/mips: fpu: Demacro ADD.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 04/21] target/mips: fpu: Demacro SUB.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 05/21] target/mips: fpu: Demacro MUL.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 06/21] target/mips: fpu: Demacro DIV.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 07/21] target/mips: fpu: Remove now unused macro FLOAT_BINOP Aleksandar Markovic
2020-06-07 19:46 ` [PULL 08/21] target/mips: fpu: Demacro MADD.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 09/21] target/mips: fpu: Demacro MSUB.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 10/21] target/mips: fpu: Demacro NMADD.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 11/21] target/mips: fpu: Demacro NMSUB.<D|S|PS> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 12/21] target/mips: fpu: Remove now unused UNFUSED_FMA and FLOAT_FMA macros Aleksandar Markovic
2020-06-07 19:46 ` [PULL 13/21] target/mips: fpu: Demacro CLASS.<D|S> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 14/21] target/mips: fpu: Remove now unused FLOAT_CLASS macro Aleksandar Markovic
2020-06-07 19:46 ` [PULL 15/21] target/mips: fpu: Demacro RINT.<D|S> Aleksandar Markovic
2020-06-07 19:46 ` [PULL 16/21] target/mips: fpu: Remove now unused FLOAT_RINT macro Aleksandar Markovic
2020-06-07 19:46 ` [PULL 17/21] target/mips: fpu: Name better paired-single variables Aleksandar Markovic
2020-06-07 19:46 ` [PULL 18/21] target/mips: fpu: Refactor conversion from ieee to mips exception flags Aleksandar Markovic
2020-06-07 19:46 ` Aleksandar Markovic [this message]
2020-06-07 19:46 ` [PULL 20/21] target/mips: Add Loongson-3 CPU definition Aleksandar Markovic
2020-06-07 19:46 ` [PULL 21/21] target/mips: Enable hardware page table walker and CMGCR features for P5600 Aleksandar Markovic
2020-06-07 20:28 ` [PULL 00/21] MIPS queue for June 7th, 2020 no-reply
2020-06-08 9:41 ` Aleksandar Markovic
2020-06-08 13:05 ` Peter Maydell
2020-06-08 13:17 ` Aleksandar Markovic
2020-06-09 15:44 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591559185-31287-20-git-send-email-aleksandar.qemu.devel@gmail.com \
--to=aleksandar.qemu.devel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).