Re: [PATCH 05/10] colo-compare: fix missing compare_seq initialization

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 10/14/20 9:25 AM, Zhang Chen wrote:
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
> 

Please include:

Fixes: f449c9e549c ("colo: compare the packet based on the tcp sequence 
number")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> Reviewed-by: Zhang Chen <chen.zhang@intel.com>
> ---
>   net/colo.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/net/colo.c b/net/colo.c
> index a6c66d829a..ef00609848 100644
> --- a/net/colo.c
> +++ b/net/colo.c
> @@ -133,14 +133,11 @@ void reverse_connection_key(ConnectionKey *key)
>   
>   Connection *connection_new(ConnectionKey *key)
>   {
> -    Connection *conn = g_slice_new(Connection);
> +    Connection *conn = g_slice_new0(Connection);
>   
>       conn->ip_proto = key->ip_proto;
>       conn->processing = false;
> -    conn->offset = 0;
>       conn->tcp_state = TCPS_CLOSED;
> -    conn->pack = 0;
> -    conn->sack = 0;
>       g_queue_init(&conn->primary_list);
>       g_queue_init(&conn->secondary_list);
>   
>