* [PATCH] tcg/riscv: Remove superfluous breaks
@ 2020-07-13 0:33 Yi Wang
2020-07-13 16:16 ` Alistair Francis
2020-07-13 16:21 ` Alistair Francis
0 siblings, 2 replies; 3+ messages in thread
From: Yi Wang @ 2020-07-13 0:33 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
---
tcg/riscv/tcg-target.inc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 2bc0ba7..3c11ab8 100644
--- a/tcg/riscv/tcg-target.inc.c
+++ b/tcg/riscv/tcg-target.inc.c
@@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
break;
case R_RISCV_JAL:
return reloc_jimm20(code_ptr, (tcg_insn_unit *)value);
- break;
case R_RISCV_CALL:
return reloc_call(code_ptr, (tcg_insn_unit *)value);
- break;
default:
tcg_abort();
}
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg/riscv: Remove superfluous breaks
2020-07-13 0:33 [PATCH] tcg/riscv: Remove superfluous breaks Yi Wang
@ 2020-07-13 16:16 ` Alistair Francis
2020-07-13 16:21 ` Alistair Francis
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2020-07-13 16:16 UTC (permalink / raw)
To: Yi Wang
Cc: xue.zhihong, wang.liang82, qemu-devel@nongnu.org Developers,
Liao Pingfang
On Sun, Jul 12, 2020 at 5:30 PM Yi Wang <wang.yi59@zte.com.cn> wrote:
>
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> tcg/riscv/tcg-target.inc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
> index 2bc0ba7..3c11ab8 100644
> --- a/tcg/riscv/tcg-target.inc.c
> +++ b/tcg/riscv/tcg-target.inc.c
> @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
> break;
> case R_RISCV_JAL:
> return reloc_jimm20(code_ptr, (tcg_insn_unit *)value);
> - break;
> case R_RISCV_CALL:
> return reloc_call(code_ptr, (tcg_insn_unit *)value);
> - break;
> default:
> tcg_abort();
> }
> --
> 2.9.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tcg/riscv: Remove superfluous breaks
2020-07-13 0:33 [PATCH] tcg/riscv: Remove superfluous breaks Yi Wang
2020-07-13 16:16 ` Alistair Francis
@ 2020-07-13 16:21 ` Alistair Francis
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2020-07-13 16:21 UTC (permalink / raw)
To: Yi Wang
Cc: xue.zhihong, wang.liang82, qemu-devel@nongnu.org Developers,
Liao Pingfang
On Sun, Jul 12, 2020 at 5:30 PM Yi Wang <wang.yi59@zte.com.cn> wrote:
>
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> tcg/riscv/tcg-target.inc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
> index 2bc0ba7..3c11ab8 100644
> --- a/tcg/riscv/tcg-target.inc.c
> +++ b/tcg/riscv/tcg-target.inc.c
> @@ -502,10 +502,8 @@ static bool patch_reloc(tcg_insn_unit *code_ptr, int type,
> break;
> case R_RISCV_JAL:
> return reloc_jimm20(code_ptr, (tcg_insn_unit *)value);
> - break;
> case R_RISCV_CALL:
> return reloc_call(code_ptr, (tcg_insn_unit *)value);
> - break;
> default:
> tcg_abort();
> }
> --
> 2.9.5
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-13 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 0:33 [PATCH] tcg/riscv: Remove superfluous breaks Yi Wang
2020-07-13 16:16 ` Alistair Francis
2020-07-13 16:21 ` Alistair Francis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).