* [PATCH] target/openrisc: Remove superfluous breaks
@ 2020-07-13 0:34 Yi Wang
2020-07-13 6:21 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2020-07-13 0:34 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
---
target/openrisc/sys_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
index d9fe6c5..d9691d0 100644
--- a/target/openrisc/sys_helper.c
+++ b/target/openrisc/sys_helper.c
@@ -289,10 +289,8 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, target_ulong rd,
case TO_SPR(5, 1): /* MACLO */
return (uint32_t)env->mac;
- break;
case TO_SPR(5, 2): /* MACHI */
return env->mac >> 32;
- break;
case TO_SPR(8, 0): /* PMR */
return env->pmr;
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/openrisc: Remove superfluous breaks
2020-07-13 0:34 [PATCH] target/openrisc: Remove superfluous breaks Yi Wang
@ 2020-07-13 6:21 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13 6:21 UTC (permalink / raw)
To: Yi Wang, qemu-devel; +Cc: xue.zhihong, wang.liang82, Liao Pingfang
Hi,
On 7/13/20 2:34 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
This patch (and various other you posted recently) misses your
S-o-b tag, see:
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
When reposting with your S-o-b please amend:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/openrisc/sys_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
> index d9fe6c5..d9691d0 100644
> --- a/target/openrisc/sys_helper.c
> +++ b/target/openrisc/sys_helper.c
> @@ -289,10 +289,8 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env, target_ulong rd,
>
> case TO_SPR(5, 1): /* MACLO */
> return (uint32_t)env->mac;
> - break;
> case TO_SPR(5, 2): /* MACHI */
> return env->mac >> 32;
> - break;
>
> case TO_SPR(8, 0): /* PMR */
> return env->pmr;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-13 6:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-13 0:34 [PATCH] target/openrisc: Remove superfluous breaks Yi Wang
2020-07-13 6:21 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).