* Re: [PATCH] hw/riscv: sifive_e: Correct debug block size
2020-07-16 9:30 [PATCH] hw/riscv: sifive_e: Correct debug block size Bin Meng
@ 2020-07-16 9:51 ` no-reply
2020-07-21 15:12 ` Alistair Francis
1 sibling, 0 replies; 3+ messages in thread
From: no-reply @ 2020-07-16 9:51 UTC (permalink / raw)
To: bmeng.cn
Cc: qemu-riscv, sagark, kbastian, palmerdabbelt, qemu-devel,
Alistair.Francis
Patchew URL: https://patchew.org/QEMU/1594891856-15474-1-git-send-email-bmeng.cn@gmail.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-centos7 V=1 NETWORK=1
time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1
=== TEST SCRIPT END ===
TEST check-unit: tests/test-crypto-secret
TEST check-unit: tests/test-char
**
ERROR:/tmp/qemu-test/src/tests/test-char.c:1204:char_serial_test: 'chr' should not be NULL
ERROR test-char - Bail out! ERROR:/tmp/qemu-test/src/tests/test-char.c:1204:char_serial_test: 'chr' should not be NULL
make: *** [check-unit] Error 1
make: *** Waiting for unfinished jobs....
TEST iotest-qcow2: 024
TEST iotest-qcow2: 025
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=4acf2b673efd49f38d448937426344fa', '-u', '1003', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew2/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-67pgfqfg/src/docker-src.2020-07-16-05.36.33.26653:/var/tmp/qemu:z,ro', 'qemu/centos7', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=4acf2b673efd49f38d448937426344fa
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-67pgfqfg/src'
make: *** [docker-run-test-quick@centos7] Error 2
real 15m23.263s
user 0m8.643s
The full log is available at
http://patchew.org/logs/1594891856-15474-1-git-send-email-bmeng.cn@gmail.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hw/riscv: sifive_e: Correct debug block size
2020-07-16 9:30 [PATCH] hw/riscv: sifive_e: Correct debug block size Bin Meng
2020-07-16 9:51 ` no-reply
@ 2020-07-21 15:12 ` Alistair Francis
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2020-07-21 15:12 UTC (permalink / raw)
To: Bin Meng
Cc: open list:RISC-V, Sagar Karandikar, Bastian Koppelmann,
Palmer Dabbelt, qemu-devel@nongnu.org Developers,
Alistair Francis
On Thu, Jul 16, 2020 at 2:31 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Currently the debug region size is set to 0x100, but according to
> FE310-G000 and FE310-G002 manuals:
>
> FE310-G000: 0x100 - 0xFFF
> FE310-G002: 0x0 - 0xFFF
>
> Change the size to 0x1000 that applies to both.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/riscv/sifive_e.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c
> index 7bb97b4..c8b0604 100644
> --- a/hw/riscv/sifive_e.c
> +++ b/hw/riscv/sifive_e.c
> @@ -54,7 +54,7 @@ static const struct MemmapEntry {
> hwaddr base;
> hwaddr size;
> } sifive_e_memmap[] = {
> - [SIFIVE_E_DEBUG] = { 0x0, 0x100 },
> + [SIFIVE_E_DEBUG] = { 0x0, 0x1000 },
> [SIFIVE_E_MROM] = { 0x1000, 0x2000 },
> [SIFIVE_E_OTP] = { 0x20000, 0x2000 },
> [SIFIVE_E_CLINT] = { 0x2000000, 0x10000 },
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread