From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <dgilbert@redhat.com>
Cc: zhang.zhanghailiang@huawei.com, linyilu@huawei.com,
qemu-devel@nongnu.org, alex.chen@huawei.com,
ann.zhuangyanying@huawei.com, fangying1@huawei.com
Subject: [RFC PATCH 7/8] migration/dirtyrate: Implement calculate_dirtyrate() function
Date: Sat, 25 Jul 2020 11:11:08 +0800 [thread overview]
Message-ID: <1595646669-109310-8-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1595646669-109310-1-git-send-email-zhengchuan@huawei.com>
From: Zheng Chuan <zhengchuan@huawei.com>
Implement calculate_dirtyrate() function.
Signed-off-by: Zheng Chuan <zhengchuan@huawei.com>
Signed-off-by: YanYing Zhang <ann.zhuangyanying@huawei.com>
---
migration/dirtyrate.c | 53 +++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 47 insertions(+), 6 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 00abfa7..d87e16d 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -161,6 +161,21 @@ alloc_block_dirty_info(int *block_index,
return block_dinfo;
}
+static void free_block_dirty_info(struct block_dirty_info *infos, int count)
+{
+ int i;
+
+ if (!infos) {
+ return;
+ }
+
+ for (i = 0; i < count; i++) {
+ g_free(infos[i].sample_page_vfn);
+ g_free(infos[i].hash_result);
+ }
+ g_free(infos);
+}
+
static int ram_block_skip(RAMBlock *block)
{
if (!strstr(qemu_ram_get_idstr(block), "ram-node") &&
@@ -278,12 +293,6 @@ static int compare_block_hash_info(struct block_dirty_info *info, int block_inde
return 0;
}
-
-static void calculate_dirtyrate(struct dirtyrate_config config, int64_t time)
-{
- /* todo */
-}
-
/*
* There are multithread will write/read *calculating_dirty_rate_stage*,
* we can protect only one thread write/read it by libvirt api.
@@ -320,6 +329,38 @@ static int64_t get_sample_gap_period(struct dirtyrate_config config)
return msec;
}
+static void calculate_dirtyrate(struct dirtyrate_config config, int64_t time)
+{
+ struct block_dirty_info *block_dinfo = NULL;
+ int block_index = 0;
+ int64_t msec = time;
+ int64_t initial_time;
+
+ rcu_register_thread();
+ reset_dirtyrate_stat();
+ initial_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
+ rcu_read_lock();
+ if (record_block_hash_info(config, &block_dinfo, &block_index) < 0) {
+ goto out;
+ }
+ rcu_read_unlock();
+
+ msec = block_sample_gap_period(msec, initial_time);
+
+ rcu_read_lock();
+ if (compare_block_hash_info(block_dinfo, block_index) < 0) {
+ goto out;
+ }
+
+ update_dirtyrate(msec);
+
+out:
+ rcu_read_unlock();
+ free_block_dirty_info(block_dinfo, block_index + 1);
+ rcu_unregister_thread();
+}
+
+
void *get_dirtyrate_thread(void *arg)
{
struct dirtyrate_config config = *(struct dirtyrate_config *)arg;
--
1.8.3.1
next prev parent reply other threads:[~2020-07-25 3:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 3:11 [RFC PATCH 0/8] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-07-25 3:11 ` [RFC PATCH 1/8] migration/dirtyrate: Add get_dirtyrate_thread() function Chuan Zheng
2020-08-04 16:23 ` Dr. David Alan Gilbert
2020-08-06 7:36 ` Zheng Chuan
2020-07-25 3:11 ` [RFC PATCH 2/8] migration/dirtyrate: Add block_dirty_info to store dirtypage info Chuan Zheng
2020-08-04 16:28 ` Dr. David Alan Gilbert
2020-08-06 7:37 ` Zheng Chuan
2020-08-06 16:59 ` Dr. David Alan Gilbert
2020-08-07 6:19 ` Zheng Chuan
2020-07-25 3:11 ` [RFC PATCH 3/8] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-08-04 16:44 ` Dr. David Alan Gilbert
2020-07-25 3:11 ` [RFC PATCH 4/8] migration/dirtyrate: Record hash results for each ramblock Chuan Zheng
2020-08-04 17:00 ` Dr. David Alan Gilbert
2020-08-06 7:37 ` Zheng Chuan
2020-07-25 3:11 ` [RFC PATCH 5/8] migration/dirtyrate: Compare hash results for recorded ramblock Chuan Zheng
2020-08-04 17:29 ` Dr. David Alan Gilbert
2020-08-11 8:42 ` Zheng Chuan
2020-07-25 3:11 ` [RFC PATCH 6/8] migration/dirtyrate: Implement get_sample_gap_period() and block_sample_gap_period() Chuan Zheng
2020-08-04 17:52 ` Dr. David Alan Gilbert
2020-07-25 3:11 ` Chuan Zheng [this message]
2020-08-04 17:57 ` [RFC PATCH 7/8] migration/dirtyrate: Implement calculate_dirtyrate() function Dr. David Alan Gilbert
2020-07-25 3:11 ` [RFC PATCH 8/8] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-08-04 16:28 ` Eric Blake
2020-08-06 7:37 ` Zheng Chuan
2020-08-04 16:34 ` Eric Blake
2020-08-04 18:02 ` Dr. David Alan Gilbert
2020-08-04 16:19 ` [RFC PATCH 0/8] *** A Method for evaluating dirty page rate *** Dr. David Alan Gilbert
2020-08-06 7:36 ` Zheng Chuan
2020-08-06 16:58 ` Dr. David Alan Gilbert
2020-08-07 6:13 ` Zheng Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1595646669-109310-8-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=dgilbert@redhat.com \
--cc=fangying1@huawei.com \
--cc=linyilu@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).