From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>
Cc: zhang.zhanghailiang@huawei.com, linyilu@huawei.com,
qemu-devel@nongnu.org, alex.chen@huawei.com,
ann.zhuangyanying@huawei.com, fangying1@huawei.com
Subject: [PATCH v2 03/10] migration/dirtyrate: Add dirtyrate statistics series functions
Date: Fri, 14 Aug 2020 17:32:06 +0800 [thread overview]
Message-ID: <1597397532-68043-4-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1597397532-68043-1-git-send-email-zhengchuan@huawei.com>
From: Zheng Chuan <zhengchuan@huawei.com>
Add dirtyrate statistics to record/update dirtyrate info.
Signed-off-by: Zheng Chuan <zhengchuan@huawei.com>
---
migration/dirtyrate.c | 30 ++++++++++++++++++++++++++++++
migration/dirtyrate.h | 10 ++++++++++
2 files changed, 40 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index bb0ebe9..8708090 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -24,6 +24,7 @@
#include "dirtyrate.h"
CalculatingDirtyRateState CalculatingState = CAL_DIRTY_RATE_INIT;
+static struct DirtyRateStat dirty_stat;
static int dirty_rate_set_state(int new_state)
{
@@ -40,6 +41,35 @@ static int dirty_rate_set_state(int new_state)
return 0;
}
+static void reset_dirtyrate_stat(void)
+{
+ dirty_stat.total_dirty_samples = 0;
+ dirty_stat.total_sample_count = 0;
+ dirty_stat.total_block_mem_MB = 0;
+ dirty_stat.dirty_rate = 0;
+}
+
+static void update_dirtyrate_stat(struct RamblockDirtyInfo *info)
+{
+ dirty_stat.total_dirty_samples += info->sample_dirty_count;
+ dirty_stat.total_sample_count += info->sample_pages_count;
+ /* size of 4K pages in MB */
+ dirty_stat.total_block_mem_MB += info->ramblock_pages / 256;
+}
+
+static void update_dirtyrate(uint64_t msec)
+{
+ uint64_t dirty_rate;
+ unsigned int total_dirty_samples = dirty_stat.total_dirty_samples;
+ unsigned int total_sample_count = dirty_stat.total_sample_count;
+ size_t total_block_mem_MB = dirty_stat.total_block_mem_MB;
+
+ dirty_rate = total_dirty_samples * total_block_mem_MB *
+ 1000 / (total_sample_count * msec);
+
+ dirty_stat.dirty_rate = dirty_rate;
+}
+
static void calculate_dirtyrate(struct DirtyRateConfig config)
{
/* todo */
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index 9650566..af57c80 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -57,6 +57,16 @@ struct RamblockDirtyInfo {
uint8_t *hash_result; /* array of hash result for sampled pages */
};
+/*
+ * Store calculate statistics for each measure.
+ */
+struct DirtyRateStat {
+ unsigned int total_dirty_samples; /* total dirty pages for this measure */
+ unsigned int total_sample_count; /* total sampled pages for this measure */
+ size_t total_block_mem_MB; /* size of sampled pages in MB */
+ int64_t dirty_rate; /* dirty rate for this measure */
+};
+
void *get_dirtyrate_thread(void *arg);
#endif
--
1.8.3.1
next prev parent reply other threads:[~2020-08-14 10:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 9:32 [PATCH v2 00/10] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 01/10] migration/dirtyrate: Add get_dirtyrate_thread() function Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 02/10] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info Chuan Zheng
2020-08-14 9:32 ` Chuan Zheng [this message]
2020-08-14 9:32 ` [PATCH v2 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 05/10] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 06/10] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period() Chuan Zheng
2020-08-14 9:32 ` [PATCH v2 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
-- strict thread matches above, loose matches on Subject: below --
2020-08-15 2:22 [PATCH v2 00/10] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-15 2:22 ` [PATCH v2 03/10] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597397532-68043-4-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fangying1@huawei.com \
--cc=linyilu@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).