From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>
Cc: zhang.zhanghailiang@huawei.com, linyilu@huawei.com,
qemu-devel@nongnu.org, alex.chen@huawei.com,
ann.zhuangyanying@huawei.com, fangying1@huawei.com
Subject: [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page
Date: Mon, 17 Aug 2020 11:20:28 +0800 [thread overview]
Message-ID: <1597634433-18809-6-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1597634433-18809-1-git-send-email-zhengchuan@huawei.com>
Record hash results for each sampled page.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: YanYing Zhuang <ann.zhuangyanying@huawei.com>
---
migration/dirtyrate.c | 144 ++++++++++++++++++++++++++++++++++++++++++++++++++
migration/dirtyrate.h | 7 +++
2 files changed, 151 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index c4304ef..62b6f69 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -25,6 +25,7 @@
#include "dirtyrate.h"
CalculatingDirtyRateState CalculatingState = CAL_DIRTY_RATE_INIT;
+static unsigned long int qcrypto_hash_len = QCRYPTO_HASH_LEN;
static struct DirtyRateStat dirty_stat;
static int dirty_rate_set_state(int new_state)
@@ -71,6 +72,149 @@ static void update_dirtyrate(uint64_t msec)
dirty_stat.dirty_rate = dirty_rate;
}
+/*
+ * get hash result for the sampled memory with length of 4K byte in ramblock,
+ * which starts from ramblock base address.
+ */
+static int get_ramblock_vfn_hash(struct RamblockDirtyInfo *info,
+ unsigned long vfn, uint8_t **md)
+{
+ struct iovec iov_array;
+ int ret = 0;
+ int nkey = 1;
+ size_t hash_len = qcrypto_hash_len;
+
+ iov_array.iov_base = info->ramblock_addr +
+ vfn * DIRTYRATE_SAMPLE_PAGE_SIZE;
+ iov_array.iov_len = DIRTYRATE_SAMPLE_PAGE_SIZE;
+
+ if (qcrypto_hash_bytesv(QCRYPTO_HASH_ALG_MD5,
+ &iov_array, nkey,
+ md, &hash_len, NULL) < 0) {
+ ret = -1;
+ }
+
+ return ret;
+}
+
+static int save_ramblock_hash(struct RamblockDirtyInfo *info)
+{
+ unsigned int sample_pages_count;
+ uint8_t *md = NULL;
+ int i;
+ int ret = -1;
+ GRand *rand = g_rand_new();
+
+ sample_pages_count = info->sample_pages_count;
+
+ /* ramblock size less than one page, return success to skip this ramblock */
+ if (unlikely(info->ramblock_pages == 0 || sample_pages_count == 0)) {
+ ret = 0;
+ goto out;
+ }
+
+ info->hash_result = g_try_malloc0_n(sample_pages_count,
+ sizeof(uint8_t) * qcrypto_hash_len);
+ if (!info->hash_result) {
+ ret = -1;
+ goto out;
+ }
+
+ info->sample_page_vfn = g_try_malloc0_n(sample_pages_count,
+ sizeof(unsigned long));
+ if (!info->sample_page_vfn) {
+ g_free(info->hash_result);
+ ret = -1;
+ goto out;
+ }
+
+ for (i = 0; i < sample_pages_count; i++) {
+ md = info->hash_result + i * qcrypto_hash_len;
+ info->sample_page_vfn[i] = g_rand_int_range(rand, 0,
+ info->ramblock_pages - 1);
+ ret = get_ramblock_vfn_hash(info, info->sample_page_vfn[i], &md);
+ if (ret < 0) {
+ goto out;
+ }
+ }
+ ret = 0;
+
+out:
+ g_rand_free(rand);
+ return ret;
+}
+
+static void get_ramblock_dirty_info(RAMBlock *block,
+ struct RamblockDirtyInfo *info,
+ struct DirtyRateConfig *config)
+{
+ uint64_t sample_pages_per_gigabytes = config->sample_pages_per_gigabytes;
+
+ /* Right shift 30 bits to calc block size in GB */
+ info->sample_pages_count = (qemu_ram_get_used_length(block)
+ * sample_pages_per_gigabytes) >> 30;
+
+ /* Right shift 12 bits to calc page count in 4KB */
+ info->ramblock_pages = qemu_ram_get_used_length(block) >> 12;
+ info->ramblock_addr = qemu_ram_get_host_addr(block);
+ strcpy(info->idstr, qemu_ram_get_idstr(block));
+}
+
+static struct RamblockDirtyInfo *
+alloc_ramblock_dirty_info(int *block_index,
+ struct RamblockDirtyInfo *block_dinfo)
+{
+ struct RamblockDirtyInfo *info = NULL;
+ int index = *block_index;
+
+ if (!block_dinfo) {
+ block_dinfo = g_try_new(struct RamblockDirtyInfo, 1);
+ index = 0;
+ } else {
+ index++;
+ block_dinfo = g_try_realloc(block_dinfo, (index + 1) *
+ sizeof(struct RamblockDirtyInfo));
+ }
+ if (!block_dinfo) {
+ return NULL;
+ }
+
+ info = &block_dinfo[index];
+ memset(info, 0, sizeof(struct RamblockDirtyInfo));
+
+ *block_index = index;
+ return block_dinfo;
+}
+
+static int record_ramblock_hash_info(struct RamblockDirtyInfo **block_dinfo,
+ struct DirtyRateConfig config,
+ int *block_index)
+{
+ struct RamblockDirtyInfo *info = NULL;
+ struct RamblockDirtyInfo *dinfo = NULL;
+ RAMBlock *block = NULL;
+ int index = 0;
+
+ RAMBLOCK_FOREACH_MIGRATABLE(block) {
+ dinfo = alloc_ramblock_dirty_info(&index, dinfo);
+ if (dinfo == NULL) {
+ return -1;
+ }
+ info = &dinfo[index];
+ get_ramblock_dirty_info(block, info, &config);
+ if (save_ramblock_hash(info) < 0) {
+ *block_dinfo = dinfo;
+ *block_index = index;
+ return -1;
+ }
+ }
+
+ *block_dinfo = dinfo;
+ *block_index = index;
+
+ return 0;
+}
+
static void calculate_dirtyrate(struct DirtyRateConfig config)
{
/* todo */
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index af57c80..0812b16 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -20,10 +20,17 @@
#define DIRTYRATE_DEFAULT_SAMPLE_PAGES 256
/*
+ * Sample page size 4K as default.
+ */
+#define DIRTYRATE_SAMPLE_PAGE_SIZE 4096
+
+/*
* Record ramblock idstr
*/
#define RAMBLOCK_INFO_MAX_LEN 256
+#define QCRYPTO_HASH_LEN 16
+
/* Take 1s as default for calculation duration */
#define DEFAULT_FETCH_DIRTYRATE_TIME_SEC 1
--
1.8.3.1
next prev parent reply other threads:[~2020-08-17 3:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 3:20 [PATCH v3 00/10] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-17 3:19 ` no-reply
2020-08-17 3:20 ` [PATCH v3 01/10] migration/dirtyrate: Add get_dirtyrate_thread() function Chuan Zheng
2020-08-20 16:11 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-17 3:20 ` [PATCH v3 02/10] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info Chuan Zheng
2020-08-20 16:20 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-21 12:08 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 03/10] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-08-20 16:28 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-17 3:20 ` [PATCH v3 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-08-20 16:31 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` Chuan Zheng [this message]
2020-08-20 17:30 ` [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page Dr. David Alan Gilbert
2020-08-20 17:51 ` Daniel P. Berrangé
2020-08-20 17:55 ` Dr. David Alan Gilbert
2020-08-21 12:22 ` Zheng Chuan
2020-08-21 12:30 ` Daniel P. Berrangé
2020-08-21 12:39 ` Dr. David Alan Gilbert
2020-08-21 13:07 ` Zheng Chuan
2020-08-22 6:25 ` Zheng Chuan
2020-08-24 8:57 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 06/10] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-08-20 17:36 ` Dr. David Alan Gilbert
2020-08-21 12:01 ` Zheng Chuan
2020-08-21 12:12 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-08-20 17:39 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period() Chuan Zheng
2020-08-20 17:52 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-08-20 17:57 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-17 3:20 ` [PATCH v3 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-08-20 17:17 ` Eric Blake
2020-08-20 18:00 ` Dr. David Alan Gilbert
2020-08-21 10:00 ` Zheng Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597634433-18809-6-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fangying1@huawei.com \
--cc=linyilu@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).