From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>
Cc: zhang.zhanghailiang@huawei.com, linyilu@huawei.com,
qemu-devel@nongnu.org, alex.chen@huawei.com,
ann.zhuangyanying@huawei.com, fangying1@huawei.com
Subject: [PATCH v3 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()
Date: Mon, 17 Aug 2020 11:20:31 +0800 [thread overview]
Message-ID: <1597634433-18809-9-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1597634433-18809-1-git-send-email-zhengchuan@huawei.com>
Implement get_sample_page_period() and set_sample_page_period() to
sleep specific time between sample actions.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: YanYing Zhuang <ann.zhuangyanying@huawei.com>
---
migration/dirtyrate.c | 24 ++++++++++++++++++++++++
migration/dirtyrate.h | 2 ++
2 files changed, 26 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 6f30f67..4bbfcc3 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -28,6 +28,30 @@ CalculatingDirtyRateState CalculatingState = CAL_DIRTY_RATE_INIT;
static unsigned long int qcrypto_hash_len = QCRYPTO_HASH_LEN;
static struct DirtyRateStat dirty_stat;
+static int64_t set_sample_page_period(int64_t msec, int64_t initial_time)
+{
+ int64_t current_time;
+
+ current_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
+ if ((current_time - initial_time) >= msec) {
+ msec = current_time - initial_time;
+ } else {
+ g_usleep((msec + initial_time - current_time) * 1000);
+ }
+
+ return msec;
+}
+
+static int64_t get_sample_page_period(int64_t sec)
+{
+ if (sec <= MIN_FETCH_DIRTYRATE_TIME_SEC ||
+ sec > MAX_FETCH_DIRTYRATE_TIME_SEC) {
+ sec = DEFAULT_FETCH_DIRTYRATE_TIME_SEC;
+ }
+
+ return sec;
+}
+
static int dirty_rate_set_state(int new_state)
{
int old_state = CalculatingState;
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index fce2e3b..86d8fa0 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -38,6 +38,8 @@
/* Take 1s as default for calculation duration */
#define DEFAULT_FETCH_DIRTYRATE_TIME_SEC 1
+#define MIN_FETCH_DIRTYRATE_TIME_SEC 0
+#define MAX_FETCH_DIRTYRATE_TIME_SEC 60
struct DirtyRateConfig {
uint64_t sample_pages_per_gigabytes; /* sample pages per GB */
--
1.8.3.1
next prev parent reply other threads:[~2020-08-17 3:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 3:20 [PATCH v3 00/10] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-08-17 3:19 ` no-reply
2020-08-17 3:20 ` [PATCH v3 01/10] migration/dirtyrate: Add get_dirtyrate_thread() function Chuan Zheng
2020-08-20 16:11 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-17 3:20 ` [PATCH v3 02/10] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info Chuan Zheng
2020-08-20 16:20 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-21 12:08 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 03/10] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-08-20 16:28 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-17 3:20 ` [PATCH v3 04/10] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-08-20 16:31 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 05/10] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-08-20 17:30 ` Dr. David Alan Gilbert
2020-08-20 17:51 ` Daniel P. Berrangé
2020-08-20 17:55 ` Dr. David Alan Gilbert
2020-08-21 12:22 ` Zheng Chuan
2020-08-21 12:30 ` Daniel P. Berrangé
2020-08-21 12:39 ` Dr. David Alan Gilbert
2020-08-21 13:07 ` Zheng Chuan
2020-08-22 6:25 ` Zheng Chuan
2020-08-24 8:57 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 06/10] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-08-20 17:36 ` Dr. David Alan Gilbert
2020-08-21 12:01 ` Zheng Chuan
2020-08-21 12:12 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 07/10] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-08-20 17:39 ` Dr. David Alan Gilbert
2020-08-17 3:20 ` Chuan Zheng [this message]
2020-08-20 17:52 ` [PATCH v3 08/10] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period() Dr. David Alan Gilbert
2020-08-17 3:20 ` [PATCH v3 09/10] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-08-20 17:57 ` Dr. David Alan Gilbert
2020-08-21 9:59 ` Zheng Chuan
2020-08-17 3:20 ` [PATCH v3 10/10] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-08-20 17:17 ` Eric Blake
2020-08-20 18:00 ` Dr. David Alan Gilbert
2020-08-21 10:00 ` Zheng Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597634433-18809-9-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=ann.zhuangyanying@huawei.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=fangying1@huawei.com \
--cc=linyilu@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).