From: Bibo Mao <maobibo@loongson.cn>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 04/17] target/loongarch: Add header file cpu-mmu.h
Date: Mon, 28 Jul 2025 11:08:28 +0800 [thread overview]
Message-ID: <15991dbb-1ef1-e73c-01fb-ff0819674756@loongson.cn> (raw)
In-Reply-To: <97316cdc-03c6-4f7f-aab9-d1064dcb77a7@linaro.org>
On 2025/7/26 上午9:16, Richard Henderson wrote:
> On 7/24/25 15:37, Bibo Mao wrote:
>> +enum {
>> + TLBRET_MATCH = 0,
>> + TLBRET_BADADDR = 1,
>> + TLBRET_NOMATCH = 2,
>> + TLBRET_INVALID = 3,
>> + TLBRET_DIRTY = 4,
>> + TLBRET_RI = 5,
>> + TLBRET_XI = 6,
>> + TLBRET_PE = 7,
>> +};
>
> For a follow-up patch, name this enumeration and use it instead of 'int'.
> It would make it self-documenting what a function is computing.
Sure, will remove these assigned sentence and use default enumeration
value in new patch.
Regards
Bibo Mao
>
>
> r~
next prev parent reply other threads:[~2025-07-28 3:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 1:37 [PATCH v3 00/17] target/loongarch: Enhancement about tcg mmu Bibo Mao
2025-07-25 1:37 ` [PATCH v3 01/17] target/loongarch: Move some function definition to kvm directory Bibo Mao
2025-07-25 23:37 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 02/17] target/loongarch: Define function loongarch_cpu_post_init as static Bibo Mao
2025-07-25 23:38 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 03/17] target/loongarch: Set page size in TLB misc with STLB Bibo Mao
2025-07-25 1:37 ` [PATCH v3 04/17] target/loongarch: Add header file cpu-mmu.h Bibo Mao
2025-07-26 1:10 ` Richard Henderson
2025-07-26 1:16 ` Richard Henderson
2025-07-28 3:08 ` Bibo Mao [this message]
2025-07-25 1:37 ` [PATCH v3 05/17] target/loongarch: Add common function loongarch_check_pte() Bibo Mao
2025-07-26 1:19 ` Richard Henderson
2025-07-28 3:15 ` Bibo Mao
2025-07-28 5:07 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 06/17] target/loongarch: Use loongarch_check_pte() with page table walking Bibo Mao
2025-07-26 1:20 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 07/17] target/loongarch: Add parameter mmu_context with loongarch_page_table_walker Bibo Mao
2025-07-26 1:31 ` Richard Henderson
2025-07-28 3:16 ` Bibo Mao
2025-07-25 1:37 ` [PATCH v3 08/17] target/loongarch: Add parameter mmu_context with loongarch_map_tlb_entry Bibo Mao
2025-07-25 1:37 ` [PATCH v3 09/17] target/loongarch: Add parameter mmu_context with loongarch_get_addr_from_tlb Bibo Mao
2025-07-25 1:37 ` [PATCH v3 10/17] target/loongarch: Add parameter mmu_context with loongarch_map_address Bibo Mao
2025-07-25 1:37 ` [PATCH v3 11/17] target/loongarch: Add parameter mmu_context with get_physical_address Bibo Mao
2025-07-25 1:37 ` [PATCH v3 12/17] target/loongarch: Track user mode address accessed in kernel mode Bibo Mao
2025-07-25 1:37 ` [PATCH v3 13/17] target/loongarch: Use correct address when flush tlb Bibo Mao
2025-07-26 1:45 ` Richard Henderson
2025-07-28 3:22 ` Bibo Mao
2025-07-28 5:09 ` Richard Henderson
2025-07-28 6:05 ` Bibo Mao
2025-07-25 1:37 ` [PATCH v3 14/17] target/loongarch: Use mmu idx bitmap method " Bibo Mao
2025-07-25 1:47 ` [PATCH v3 15/17] target/loongarch: Add parameter tlb pointer with fill_tlb_entry Bibo Mao
2025-07-26 1:47 ` Richard Henderson
2025-07-25 1:47 ` [PATCH v3 16/17] target/loongarch: Reduce TLB flush with helper_tlbwr Bibo Mao
2025-07-25 1:48 ` [PATCH v3 17/17] target/loongarch: Update TLB index selection method Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15991dbb-1ef1-e73c-01fb-ff0819674756@loongson.cn \
--to=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).