From: Finn Thain <fthain@linux-m68k.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Greg Kurz" <groug@kaod.org>,
qemu-ppc@nongnu.org, "Laurent Vivier" <Laurent@vivier.eu>
Subject: Re: [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements
Date: Tue, 23 Nov 2021 09:34:06 +1100 (AEDT) [thread overview]
Message-ID: <159c1cb-eec0-d689-1df7-8fcfdc2e5c25@linux-m68k.org> (raw)
In-Reply-To: <CAFEAcA-h2B3JELSrQs0dP3shqPNDe2NDMqCqT5oGoOjjM6mzRw@mail.gmail.com>
On Mon, 22 Nov 2021, Peter Maydell wrote:
> On Sat, 20 Nov 2021 at 23:40, Finn Thain <fthain@linux-m68k.org> wrote:
> > Anyway, thanks for taking the time to write. A competent reviewer has to
> > do much more than that, but I'm not paying for competence so I suppose I'm
> > asking too much.
>
> Please dial back the aggressive tone here, Finn: this kind of
> thing is way out of line. We're all trying to help improve QEMU here,
> and sniping at Mark is not constructive.
>
Peter, you seem to have misunderstood what I wrote. What I said was not
sniping. "Incompetent" was my conclusion after I judiciously rejected
"malicious". Here's what I mean by incompetent.
CONTRIBUTOR: Here's a patch.
MAINTAINER: I personally don't like that pattern. End of story.
CONTRIBUTOR: I don't think I'll contribute further to this project.
[Everyone loses.]
Now, here's what I would consider "competent":
CONTRIBUTOR: Here's a patch.
MAINTAINER: That pattern (I've quoted it to help further the discussion)
is widely deprecated. You should use a different pattern instead. [Or read
this reference. Or refer to this code.]
CONTRIBUTOR: OK, I see that this really is a problem, and I see that there
really is a better way. However, the antipattern is already part of
existing code, and my changes don't worsen the problem, and don't require
that the problem persist.
MAINTAINER: You're right. My bad (I'm new to this). Since I never bothered
to fix the existing antipattern, and no-one else thought it was worth
fixing either, clearly it's not that important, and I should not have
sought to veto your work, which is substantially unrelated, and beneficial
either way.
CONTRIBUTOR: No problem.
[Everyone wins.]
Finally, here's the background for you to ponder, in case you would like
to intervene to produce a better outcome. (I think you are potentially
well positioned for that.)
https://lore.kernel.org/qemu-devel/cover.1629799776.git.fthain@linux-m68k.org/
https://lore.kernel.org/qemu-devel/cover.1632437396.git.fthain@linux-m68k.org/
prev parent reply other threads:[~2021-11-22 22:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 22:49 [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements Finn Thain
2021-09-23 22:49 ` [PATCH v1 6/9] hw/mos6522: Call mos6522_update_irq() when appropriate Finn Thain
2021-09-23 22:49 ` [PATCH v1 3/9] hw/mos6522: Remove redundant mos6522_timer1_update() calls Finn Thain
2021-09-23 22:49 ` [PATCH v1 2/9] hw/mos6522: Remove get_counter_value() methods and functions Finn Thain
2021-09-23 22:49 ` [PATCH v1 1/9] hw/mos6522: Remove get_load_time() " Finn Thain
2021-09-23 22:49 ` [PATCH v1 4/9] hw/mos6522: Rename timer callback functions Finn Thain
2021-09-23 22:49 ` [PATCH v1 5/9] hw/mos6522: Fix initial timer counter reload Finn Thain
2021-09-23 22:49 ` [PATCH v1 9/9] hw/mos6522: Implement oneshot mode Finn Thain
2021-09-23 22:49 ` [PATCH v1 7/9] hw/mos6522: Avoid using discrepant QEMU clock values Finn Thain
2021-09-23 22:49 ` [PATCH v1 8/9] hw/mos6522: Synchronize timer interrupt and timer counter Finn Thain
2021-11-17 3:03 ` [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements Finn Thain
2021-11-18 11:13 ` Mark Cave-Ayland
2021-11-19 8:39 ` Finn Thain
2021-11-20 21:53 ` Mark Cave-Ayland
2021-11-20 23:38 ` Finn Thain
2021-11-22 17:00 ` Peter Maydell
2021-11-22 22:34 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159c1cb-eec0-d689-1df7-8fcfdc2e5c25@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=Laurent@vivier.eu \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).