From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59446)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1ZDCSV-0004XD-Aa
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 10:05:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1ZDCST-0000zQ-Ss
	for qemu-devel@nongnu.org; Thu, 09 Jul 2015 10:05:51 -0400
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Programmingkid <programmingkidx@gmail.com>
In-Reply-To: <559E4070.6040700@redhat.com>
Date: Thu, 9 Jul 2015 10:05:41 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <15C0A91D-073C-4CD0-8563-FABFB463395F@gmail.com>
References: <F11A2BB4-9674-46A0-8ED0-352A8AEEA7F9@gmail.com>
	<559E4070.6040700@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] raw-posix.c: Make physical devices usable
	in QEMU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Qemu-block <qemu-block@nongnu.org>


On Jul 9, 2015, at 5:35 AM, Laurent Vivier wrote:

>=20
>=20
> On 07/07/2015 19:33, Programmingkid wrote:
>> Make physical devices like a USB flash drive or a CDROM drive work in
>> QEMU. With
>> this patch I can use a USB flash drive like a hard drive. Before this
>> patch,=20
>> QEMU would just quit with a message like "resource busy". Now it =
handles
>> issues
>> like these for the user. This patch unmounts volumes of physical =
devices
>> before
>> using them in QEMU. When QEMU quits, the physical devices are mounted =
again
>> for the user. The user can find out which device files to use for =
their
>> physical
>> devices by running the mount command in the terminal. This patch =
makes
>> "qemu-system-ppc -cdrom /dev/cdrom" work again on Mac OS X.
>>=20
>> Signed-off-by: John Arbuckle <programmingkidx@gmail.com
>> <mailto:programmingkidx@gmail.com>>
>=20
> Two comments:
> - you should not mix several fixes in one patch (raw block device
> management, partition seek, unmount/mount cdrom...)

I consider this patch one fix with several related changes.=20

> - according to Stefan answer, I think you should not unmount the CDROM
> but you should inform the user he must unmount it manually to be able =
to
> use it.

Having the user unmount the CDROM manually isn't as user friendly as
having QEMU doing it for him or her.=20=