From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF4B6C433E2 for ; Fri, 11 Sep 2020 13:30:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C90222266 for ; Fri, 11 Sep 2020 13:30:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=anisinha-ca.20150623.gappssmtp.com header.i=@anisinha-ca.20150623.gappssmtp.com header.b="y4p/OinW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C90222266 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anisinha.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGj7v-0003V3-UG for qemu-devel@archiver.kernel.org; Fri, 11 Sep 2020 09:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGj7F-0002ni-D5 for qemu-devel@nongnu.org; Fri, 11 Sep 2020 09:29:25 -0400 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]:40109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGj7D-0000jh-6Q for qemu-devel@nongnu.org; Fri, 11 Sep 2020 09:29:25 -0400 Received: by mail-pj1-x1043.google.com with SMTP id gf14so1699617pjb.5 for ; Fri, 11 Sep 2020 06:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version; bh=fwbLn7wAQazJPXTKzz+017cWKEIrWQegJdenVz1XPW4=; b=y4p/OinWNn8mi5q8ZizrdFYy2coHg8cXZZBWIi4GNbOo6spGYDB0zcmDxhroQecZCp TYPP4kCONoRT51iDy8hJRazhCGKIXTUYXSZMLdgXKYYywj/2KIQrP/wiZlNcJI2iEVuA s0D8L/a7x/9NUlC6zQbV8XzeZws9R8HIWV31VcQxmJKJFevDRzThX4nYh7D3oZKebNbi 7ra8yQVxgclYx8quL+EHe2nxIQiKi/+e9YZbJH7GRgQfDj/LQQh6tEO3WvenoiVTpWU8 fa27PwS9W/enOHTXoru+V5xE11poxmar9nkCzygAiSF+tCra/kk0SOCrQZb4VpYtWLwg 9Yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version; bh=fwbLn7wAQazJPXTKzz+017cWKEIrWQegJdenVz1XPW4=; b=YoCp/d/2LC3t83xSTWjw/3/UEY2Kue2Bx9RIiQ999ZK6E+RdVmIiIkHYW1W4CxcKbr yEJ3EkoyUw3cpfb63vcBIEED3mD9HDFn/+RHQpacSZMuKL3eRttjooG36yz/wVkfdrQx YMsrtyys/NtWGuix6teqL3vYdZl9/egyK8huNVcT+eJptX/fOwdT8DzYCixaBF/MGhRU 1wDjrDHmdqh4OvZ3KfZ/QibHy4sgDI/QhqrvgqRGpTlvEgB75bFopvUG2xcwvNW/KJOG trLb6CpUAZMfQEgcx2hatcvwmpt1TkQOoRVPy2N6TyeAmgA1rBcwYqKeqkgOone4WO1X dFLA== X-Gm-Message-State: AOAM533kmfg0BXSeenb63qcvuSFm/uVkhOw3ZNh+Hsgect7SiQ0ZirkB 4yGcYsVMp1g2novEv7DPdTP5oQ== X-Google-Smtp-Source: ABdhPJzvsfhb0SPJH9f2bn2qwPB1grOVmBJ9ye8ofuZJ90Ndoq8dxmcEe9hQU1fgEoHLoAk9L4o/zA== X-Received: by 2002:a17:90a:9708:: with SMTP id x8mr2330243pjo.213.1599830961291; Fri, 11 Sep 2020 06:29:21 -0700 (PDT) Received: from [192.168.1.3] ([115.96.135.201]) by smtp.gmail.com with ESMTPSA id h12sm2441405pfo.68.2020.09.11.06.29.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Sep 2020 06:29:20 -0700 (PDT) Date: Fri, 11 Sep 2020 18:59:05 +0530 From: Ani Sinha To: Igor Mammedov Message-ID: <15acb705-2056-48ee-b9c5-0e878ccfac18@Spark> In-Reply-To: <20200911144509.6c16d081@redhat.com> References: <20200905103520.12626-1-ani@anisinha.ca> <20200905103520.12626-3-ani@anisinha.ca> <448ada27-1a94-44ed-89fa-001a70213ad7@Spark> <20200911144509.6c16d081@redhat.com> Subject: Re: [PATCH v1 2/3] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag X-Readdle-Message-ID: 15acb705-2056-48ee-b9c5-0e878ccfac18@Spark MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="5f5b7ba9_66334873_198f" Received-SPF: none client-ip=2607:f8b0:4864:20::1043; envelope-from=ani@anisinha.ca; helo=mail-pj1-x1043.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , jusual@redhat.com, qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --5f5b7ba9_66334873_198f Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sep 11, 2020, 18:15 +0530, Igor Mammedov , wrot= e: > On Thu, 10 Sep 2020 22:34:20 +0530 > Ani Sinha wrote: > > > On Sep 5, 2020, 16:05 +0530, Ani Sinha , wrote: > > > This change adds a new unit test for the global flag > > > 'acpi-pci-hotplug-with-bridge-support' which is available for cold = plugged pci > > > bridges in i440fx. The flag can be used to turn off acpi based hotp= lug support > > > for all the slots of the pci bus. > > > > > > Tested on the upstream qemu master branch on top of tag v5.1.0 > > > > Can someone please review this=3F > Hi, > Are there other patches of yours, > that should be applied/reviewed before this one=3F Yes please see =E2=80=9Ci440fx/acpi: Do not add hotplug related amls for cold plugged br= idges=E2=80=9D > > > > > > Signed-off-by: Ani Sinha > > > > > > > > > --- > > > tests/qtest/bios-tables-test.c =7C 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tabl= es-test.c > > > index a2c0070306..e52a36e775 100644 > > > --- a/tests/qtest/bios-tables-test.c > > > +++ b/tests/qtest/bios-tables-test.c > > > =40=40 -723,6 +723,20 =40=40 static void test=5Facpi=5Fpiix4=5Froot= =5Fhotplug(void) > > > free=5Ftest=5Fdata(&data); > > > =7D > > > > > > +static void test=5Facpi=5Fpiix4=5Fbridge=5Fhotplug(void) > > > +=7B > > > + test=5Fdata data; > > > + > > > + memset(&data, 0, sizeof(data)); > > > + data.machine =3D MACHINE=5FPC; > > > + data.variant =3D =22.hpbridge=22; > > > + data.required=5Fstruct=5Ftypes =3D base=5Frequired=5Fstruct=5Ftyp= es; > > > + data.required=5Fstruct=5Ftypes=5Flen =3D ARRAY=5FSIZE(base=5Frequ= ired=5Fstruct=5Ftypes); > > > + test=5Facpi=5Fone(=22-global PIIX4=5FPM.acpi-pci-hotplug-with-bri= dge-support=3Doff =22 > > > + =22-device pci-bridge,chassis=5Fnr=3D1=22, &data); > > > + free=5Ftest=5Fdata(&data); > > > +=7D > > > + > > > static void test=5Facpi=5Fq35=5Ftcg(void) > > > =7B > > > test=5Fdata data; > > > =40=40 -1117,6 +1131,7 =40=40 int main(int argc, char *argv=5B=5D) > > > qtest=5Fadd=5Ffunc(=22acpi/piix4=22, test=5Facpi=5Fpiix4=5Ftcg); > > > qtest=5Fadd=5Ffunc(=22acpi/piix4/bridge=22, test=5Facpi=5Fpiix4=5Ft= cg=5Fbridge); > > > qtest=5Fadd=5Ffunc(=22acpi/piix4/hotplug=22, test=5Facpi=5Fpiix4=5F= root=5Fhotplug); > > > + qtest=5Fadd=5Ffunc(=22acpi/piix4/brhotplug=22, test=5Facpi=5Fpiix= 4=5Fbridge=5Fhotplug); > > > qtest=5Fadd=5Ffunc(=22acpi/q35=22, test=5Facpi=5Fq35=5Ftcg); > > > qtest=5Fadd=5Ffunc(=22acpi/q35/bridge=22, test=5Facpi=5Fq35=5Ftcg=5F= bridge); > > > qtest=5Fadd=5Ffunc(=22acpi/q35/mmio64=22, test=5Facpi=5Fq35=5Ftcg=5F= mmio64); > > > -- > > > 2.17.1 > > > > --5f5b7ba9_66334873_198f Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
On Sep 11, 2020, 18:15 +0530, Igor Mammedov <ima= mmedo=40redhat.com>, wrote:
On Thu, 10 Sep 2020 22:34:20 +05= 30
Ani Sinha <ani=40anisinha.ca&= gt; wrote:

On Sep 5, 2020, 16:05 +0530, Ani= Sinha <ani=40anisinha.ca>, wrote:
This change adds a new unit test= for the global flag
'acpi-pci-hotplug-with-bridge-su= pport' which is available for cold plugged pci
bridges in i440fx. The flag can = be used to turn off acpi based hotplug support
for all the slots of the pci bus= .

Tested on the upstream qemu mast= er branch on top of tag v5.1.0

Can someone please review this=3F=
Hi,
Are there other patches of yours= ,
that should be applied/reviewed = before this one=3F

Yes please see

=E2=80=9Ci440fx/acpi: Do not add hotplug related amls for cold plugged br= idges=E2=80=9D



Signed-off-by: Ani Sinha <ani= =40anisinha.ca>


---
tests/qtest/bios-tables-test.c =7C= 15 +++++++++++++++
1 file changed, 15 insertions(+)=

diff --git a/tests/qtest/bios-ta= bles-test.c b/tests/qtest/bios-tables-test.c
index a2c0070306..e52a36e775 100= 644
--- a/tests/qtest/bios-tables-te= st.c
+++ b/tests/qtest/bios-tables-te= st.c
=40=40 -723,6 +723,20 =40=40 sta= tic void test=5Facpi=5Fpiix4=5Froot=5Fhotplug(void)
free=5Ftest=5Fdata(&data);
=7D

+static void test=5Facpi=5Fpiix4= =5Fbridge=5Fhotplug(void)
+=7B
+ test=5Fdata data;
=
+
+ memset(&data, 0, sizeof(da= ta));
+ data.machine =3D MACHINE=5FPC;=
+ data.variant =3D =22.hpbridge=22= ;
+ data.required=5Fstruct=5Ftypes= =3D base=5Frequired=5Fstruct=5Ftypes;
+ data.required=5Fstruct=5Ftypes= =5Flen =3D ARRAY=5FSIZE(base=5Frequired=5Fstruct=5Ftypes);
+ test=5Facpi=5Fone(=22-global P= IIX4=5FPM.acpi-pci-hotplug-with-bridge-support=3Doff =22
+ =22-device pci-bridge,chassis=5F= nr=3D1=22, &data);
+ free=5Ftest=5Fdata(&data);=
+=7D
+
static void test=5Facpi=5Fq35=5F= tcg(void)
=7B
test=5Fdata data;
=40=40 -1117,6 +1131,7 =40=40 in= t main(int argc, char *argv=5B=5D)
qtest=5Fadd=5Ffunc(=22acpi/piix4= =22, test=5Facpi=5Fpiix4=5Ftcg);
qtest=5Fadd=5Ffunc(=22acpi/piix4= /bridge=22, test=5Facpi=5Fpiix4=5Ftcg=5Fbridge);
qtest=5Fadd=5Ffunc(=22acpi/piix4= /hotplug=22, test=5Facpi=5Fpiix4=5Froot=5Fhotplug);
+ qtest=5Fadd=5Ffunc(=22acpi/pii= x4/brhotplug=22, test=5Facpi=5Fpiix4=5Fbridge=5Fhotplug);
qtest=5Fadd=5Ffunc(=22acpi/q35=22= , test=5Facpi=5Fq35=5Ftcg);
qtest=5Fadd=5Ffunc(=22acpi/q35/b= ridge=22, test=5Facpi=5Fq35=5Ftcg=5Fbridge);
qtest=5Fadd=5Ffunc(=22acpi/q35/m= mio64=22, test=5Facpi=5Fq35=5Ftcg=5Fmmio64);
--
2.17.1


--5f5b7ba9_66334873_198f--