Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

On 1/15/19 12:51 PM, Ed Maste wrote:
> On Tue, 15 Jan 2019 at 13:42, Ed Maste <emaste@freebsd.org> wrote:
>>
>> From: Ed Maste <emaste@freebsd.org>
> 
> I'm not sure what part of the path between `git send-email` and the
> list moved this From: into the message body, but it's not intentional.

It doesn't hurt. 'git am' prefers the From: in the message body over the
From: from the message headers, if the two differ, because that is the
only way some people have to get git to record their commits correctly
due to the list having to rewrite their headers to avoid the mail being
rejected from over-strict SPF settings.  In your case, the two lines
look identical (the list didn't rewrite your header From: to work around
SPF); but it may be due to your 'git config format.from' settings.

> If someone's going to pick up this patch please edit the commit
> message.

'git am' already does it automatically.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]