From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH] hw/acpi: refactor acpi hp modules so that targets can just use what they need
Date: Fri, 20 Aug 2021 17:59:16 +0200 [thread overview]
Message-ID: <15eb786a-31a3-67e8-cc4e-4db8dd949144@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2108202110430.624345@anisinha-lenovo>
On 8/20/21 5:43 PM, Ani Sinha wrote:
> On Thu, 19 Aug 2021, Philippe Mathieu-Daudé wrote:
>> On 8/12/21 9:14 AM, Ani Sinha wrote:
>
>>> + return;
>>
>> I suppose if you replace all 'return' by 'g_assert_not_reached()'
>> both issues reproducers crash?
>>
>> Your patch is not incorrect, and indeed fixes the issues, but
>> I feel we are going backward now allowing call which should
>> never be there in the first place.
>>
>
> Linux kernel does something like this all over the place. They simply
> replace functions with NOOPS when they are not allowed for a
> configuration. They do this relying on preprocessor macros ofcourse!
>
> It will be hard to do anythiung better without rearchitecting the modules.
Which is why this situation is unsolved since various years <:)
> That would have significant impact particularly on x86.
I don't believe so, the rework has to be done at the machine creation,
no change during runtime.
next prev parent reply other threads:[~2021-08-20 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 7:14 [PATCH] hw/acpi: refactor acpi hp modules so that targets can just use what they need Ani Sinha
2021-08-12 13:22 ` Ani Sinha
2021-08-12 13:49 ` Philippe Mathieu-Daudé
2021-08-12 15:27 ` Ani Sinha
2021-08-18 11:46 ` Ani Sinha
2021-08-19 11:06 ` Philippe Mathieu-Daudé
2021-08-19 12:52 ` Ani Sinha
2021-08-20 15:43 ` Ani Sinha
2021-08-20 15:59 ` Philippe Mathieu-Daudé [this message]
2021-09-01 12:19 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15eb786a-31a3-67e8-cc4e-4db8dd949144@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=ani@anisinha.ca \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).