* [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin
@ 2023-09-18 6:25 Philippe Mathieu-Daudé
2023-09-18 6:31 ` Philippe Mathieu-Daudé
2023-09-18 6:35 ` Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-09-18 6:25 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Paolo Bonzini, Laurent Vivier,
Philippe Mathieu-Daudé
Do not run this test on Darwin, otherwise we get:
qemu-system-arm: -netdev dgram,id=st0,remote.type=inet,remote.host=230.0.0.1,remote.port=1234: can't add socket to multicast group 230.0.0.1: Can't assign requested address
Broken pipe
../../tests/qtest/libqtest.c:191: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0)
Abort trap: 6
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
tests/qtest/netdev-socket.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
index 8eed54801f..3fc2ac26d0 100644
--- a/tests/qtest/netdev-socket.c
+++ b/tests/qtest/netdev-socket.c
@@ -401,7 +401,7 @@ static void test_dgram_inet(void)
qtest_quit(qts0);
}
-#ifndef _WIN32
+#if !defined(_WIN32) && !defined(CONFIG_DARWIN)
static void test_dgram_mcast(void)
{
QTestState *qts;
@@ -414,7 +414,9 @@ static void test_dgram_mcast(void)
qtest_quit(qts);
}
+#endif
+#ifndef _WIN32
static void test_dgram_unix(void)
{
QTestState *qts0, *qts1;
@@ -511,7 +513,7 @@ int main(int argc, char **argv)
if (has_ipv4) {
qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
-#ifndef _WIN32
+#if !defined(_WIN32) && !defined(CONFIG_DARWIN)
qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
#endif
}
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin
2023-09-18 6:25 [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin Philippe Mathieu-Daudé
@ 2023-09-18 6:31 ` Philippe Mathieu-Daudé
2023-09-18 6:35 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-09-18 6:31 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: Thomas Huth, Paolo Bonzini, Jason Wang
I just noticed Jason wasn't Cc'ed. Assuming this test belongs
to "Network device backends", Cc'ing him. (Should we add the
test entry in MAINTAINERS?)
On 18/9/23 08:25, Philippe Mathieu-Daudé wrote:
> Do not run this test on Darwin, otherwise we get:
>
> qemu-system-arm: -netdev dgram,id=st0,remote.type=inet,remote.host=230.0.0.1,remote.port=1234: can't add socket to multicast group 230.0.0.1: Can't assign requested address
> Broken pipe
> ../../tests/qtest/libqtest.c:191: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0)
> Abort trap: 6
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/qtest/netdev-socket.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> index 8eed54801f..3fc2ac26d0 100644
> --- a/tests/qtest/netdev-socket.c
> +++ b/tests/qtest/netdev-socket.c
> @@ -401,7 +401,7 @@ static void test_dgram_inet(void)
> qtest_quit(qts0);
> }
>
> -#ifndef _WIN32
> +#if !defined(_WIN32) && !defined(CONFIG_DARWIN)
> static void test_dgram_mcast(void)
> {
> QTestState *qts;
> @@ -414,7 +414,9 @@ static void test_dgram_mcast(void)
>
> qtest_quit(qts);
> }
> +#endif
>
> +#ifndef _WIN32
> static void test_dgram_unix(void)
> {
> QTestState *qts0, *qts1;
> @@ -511,7 +513,7 @@ int main(int argc, char **argv)
> if (has_ipv4) {
> qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
> qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
> -#ifndef _WIN32
> +#if !defined(_WIN32) && !defined(CONFIG_DARWIN)
> qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
> #endif
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin
2023-09-18 6:25 [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin Philippe Mathieu-Daudé
2023-09-18 6:31 ` Philippe Mathieu-Daudé
@ 2023-09-18 6:35 ` Thomas Huth
2023-09-18 10:43 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2023-09-18 6:35 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Paolo Bonzini, Laurent Vivier
On 18/09/2023 08.25, Philippe Mathieu-Daudé wrote:
> Do not run this test on Darwin, otherwise we get:
>
> qemu-system-arm: -netdev dgram,id=st0,remote.type=inet,remote.host=230.0.0.1,remote.port=1234: can't add socket to multicast group 230.0.0.1: Can't assign requested address
> Broken pipe
> ../../tests/qtest/libqtest.c:191: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0)
> Abort trap: 6
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> tests/qtest/netdev-socket.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
> index 8eed54801f..3fc2ac26d0 100644
> --- a/tests/qtest/netdev-socket.c
> +++ b/tests/qtest/netdev-socket.c
> @@ -401,7 +401,7 @@ static void test_dgram_inet(void)
> qtest_quit(qts0);
> }
>
> -#ifndef _WIN32
> +#if !defined(_WIN32) && !defined(CONFIG_DARWIN)
> static void test_dgram_mcast(void)
> {
> QTestState *qts;
> @@ -414,7 +414,9 @@ static void test_dgram_mcast(void)
>
> qtest_quit(qts);
> }
> +#endif
>
> +#ifndef _WIN32
> static void test_dgram_unix(void)
> {
> QTestState *qts0, *qts1;
> @@ -511,7 +513,7 @@ int main(int argc, char **argv)
> if (has_ipv4) {
> qtest_add_func("/netdev/stream/inet/ipv4", test_stream_inet_ipv4);
> qtest_add_func("/netdev/dgram/inet", test_dgram_inet);
> -#ifndef _WIN32
> +#if !defined(_WIN32) && !defined(CONFIG_DARWIN)
> qtest_add_func("/netdev/dgram/mcast", test_dgram_mcast);
> #endif
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
I'll queue this for my next pull request.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin
2023-09-18 6:35 ` Thomas Huth
@ 2023-09-18 10:43 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-09-18 10:43 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: Paolo Bonzini, Laurent Vivier, Jason Wang
On 18/9/23 08:35, Thomas Huth wrote:
> On 18/09/2023 08.25, Philippe Mathieu-Daudé wrote:
>> Do not run this test on Darwin, otherwise we get:
>>
>> qemu-system-arm: -netdev
>> dgram,id=st0,remote.type=inet,remote.host=230.0.0.1,remote.port=1234:
>> can't add socket to multicast group 230.0.0.1: Can't assign requested
>> address
>> Broken pipe
>> ../../tests/qtest/libqtest.c:191: kill_qemu() tried to terminate
>> QEMU process but encountered exit status 1 (expected 0)
>> Abort trap: 6
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> tests/qtest/netdev-socket.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> I'll queue this for my next pull request.
Great, thank you Thomas!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-18 10:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 6:25 [PATCH] tests/qtest/netdev-socket: Do not test multicast on Darwin Philippe Mathieu-Daudé
2023-09-18 6:31 ` Philippe Mathieu-Daudé
2023-09-18 6:35 ` Thomas Huth
2023-09-18 10:43 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).