From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>,
Dmitry Frolov <frolov@swemel.ru>,
jonathan.cameron@huawei.com, fan.ni@samsung.com,
qemu-devel@nongnu.org
Cc: sdl.qemu@linuxtesting.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [PATCH] hw/cxl: Fix out of bound array access
Date: Thu, 14 Sep 2023 14:59:00 +0200 [thread overview]
Message-ID: <15f6d627-b88a-f6a0-abb8-70ec5198fd45@linaro.org> (raw)
In-Reply-To: <79f03e2f-4cc9-fd44-1101-0dd8a398ff42@tls.msk.ru>
On 14/9/23 14:38, Michael Tokarev wrote:
> 14.09.2023 15:37, Michael Tokarev:
>> 13.09.2023 13:10, Dmitry Frolov wrote:
>>> According to cxl_interleave_ways_enc(),
>>> fw->num_targets is allowed to be up to 16.
>>> This also corresponds to CXL specs.
>>> So, the fw->target_hbs[] array is iterated from 0 to 15.
>>> But it is staticaly declared of length 8.
>>> Thus, out of bound array access may occur.
>>>
>>> Fixes: c28db9e000 ("hw/pci-bridge: Make PCIe and CXL PXB Devices
>>> inherit from TYPE_PXB_DEV")
>>>
>>> Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
>>
>> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
>> (with the extra empty line removed :)
>
> Also,
>
> Cc: qemu-stable@nongnu.org
>
> for stable-8.1.
[not related to this particular patch]
Maybe this can help if we specify the releases range as a comment
in the Cc tag, for example here:
Cc: qemu-stable@nongnu.org # v8.1
and if it were a range:
Cc: qemu-stable@nongnu.org # v6.2 to v8.0
Michael would that help? If so feel free to modify
docs/devel/stable-process.rst :)
Regards,
Phil.
next prev parent reply other threads:[~2023-09-14 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 10:10 [PATCH] hw/cxl: Fix out of bound array access Dmitry Frolov
2023-09-13 11:02 ` Jonathan Cameron via
2023-09-13 11:36 ` Philippe Mathieu-Daudé
2023-09-13 13:22 ` [PATCH v2] " Dmitry Frolov
2023-09-13 16:58 ` Jonathan Cameron via
2023-09-13 16:56 ` [PATCH] " Jonathan Cameron via
2023-09-14 7:06 ` [PATCH v3] " Dmitry Frolov
2023-09-14 12:36 ` Michael Tokarev
2023-09-14 12:37 ` [PATCH] " Michael Tokarev
2023-09-14 12:38 ` Michael Tokarev
2023-09-14 12:59 ` Philippe Mathieu-Daudé [this message]
2023-09-14 13:16 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15f6d627-b88a-f6a0-abb8-70ec5198fd45@linaro.org \
--to=philmd@linaro.org \
--cc=fan.ni@samsung.com \
--cc=frolov@swemel.ru \
--cc=jonathan.cameron@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=sdl.qemu@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).