From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>,
<berrange@redhat.com>
Cc: zhengchuan@huawei.com, zhang.zhanghailiang@huawei.com,
liq3ea@gmail.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com,
alex.chen@huawei.com
Subject: [PATCH v10 09/12] migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid()
Date: Wed, 16 Sep 2020 14:22:04 +0800 [thread overview]
Message-ID: <1600237327-33618-10-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1600237327-33618-1-git-send-email-zhengchuan@huawei.com>
Implement is_sample_period_valid() to check if the sample period is vaild and
do set_sample_page_period() to sleep specific time between sample actions.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
---
migration/dirtyrate.c | 24 ++++++++++++++++++++++++
migration/dirtyrate.h | 6 ++++++
2 files changed, 30 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index ede8063..ef77483 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -27,6 +27,30 @@
static int CalculatingState = DIRTY_RATE_STATUS_UNSTARTED;
static struct DirtyRateStat DirtyStat;
+static int64_t set_sample_page_period(int64_t msec, int64_t initial_time)
+{
+ int64_t current_time;
+
+ current_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
+ if ((current_time - initial_time) >= msec) {
+ msec = current_time - initial_time;
+ } else {
+ g_usleep((msec + initial_time - current_time) * 1000);
+ }
+
+ return msec;
+}
+
+static bool is_sample_period_valid(int64_t sec)
+{
+ if (sec < MIN_FETCH_DIRTYRATE_TIME_SEC ||
+ sec > MAX_FETCH_DIRTYRATE_TIME_SEC) {
+ return false;
+ }
+
+ return true;
+}
+
static int dirtyrate_set_state(int *state, int old_state, int new_state)
{
assert(new_state < DIRTY_RATE_STATUS__MAX);
diff --git a/migration/dirtyrate.h b/migration/dirtyrate.h
index faaf9da..8f9bc80 100644
--- a/migration/dirtyrate.h
+++ b/migration/dirtyrate.h
@@ -29,6 +29,12 @@
*/
#define MIN_RAMBLOCK_SIZE 128
+/*
+ * Take 1s as minimum time for calculation duration
+ */
+#define MIN_FETCH_DIRTYRATE_TIME_SEC 1
+#define MAX_FETCH_DIRTYRATE_TIME_SEC 60
+
struct DirtyRateConfig {
uint64_t sample_pages_per_gigabytes; /* sample pages per GB */
int64_t sample_period_seconds; /* time duration between two sampling */
--
1.8.3.1
next prev parent reply other threads:[~2020-09-16 6:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:21 [PATCH v10 00/12] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-09-16 6:21 ` [PATCH v10 01/12] migration/dirtyrate: setup up query-dirtyrate framwork Chuan Zheng
2020-09-16 6:21 ` [PATCH v10 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status Chuan Zheng
2020-09-16 6:21 ` [PATCH v10 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info Chuan Zheng
2020-09-16 6:21 ` [PATCH v10 04/12] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 07/12] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-09-16 14:49 ` Li Qiang
2020-09-16 6:22 ` [PATCH v10 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-09-16 6:22 ` Chuan Zheng [this message]
2020-09-16 6:22 ` [PATCH v10 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-09-17 9:08 ` Dr. David Alan Gilbert
2020-09-23 18:17 ` Eric Blake
2020-09-23 19:03 ` Dr. David Alan Gilbert
2020-09-24 8:42 ` Zheng Chuan
2020-09-16 6:22 ` [PATCH v10 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug Chuan Zheng
2020-09-17 9:15 ` [PATCH v10 00/12] *** A Method for evaluating dirty page rate *** Dr. David Alan Gilbert
2020-09-17 9:22 ` Zheng Chuan
2020-09-17 9:38 ` Dr. David Alan Gilbert
2020-09-17 10:21 ` Zheng Chuan
2020-09-23 18:04 ` Dr. David Alan Gilbert
2020-09-23 18:18 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600237327-33618-10-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=liq3ea@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiexiangyou@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).