From: Chuan Zheng <zhengchuan@huawei.com>
To: <quintela@redhat.com>, <eblake@redhat.com>, <dgilbert@redhat.com>,
<berrange@redhat.com>
Cc: zhengchuan@huawei.com, zhang.zhanghailiang@huawei.com,
liq3ea@gmail.com, qemu-devel@nongnu.org, xiexiangyou@huawei.com,
alex.chen@huawei.com
Subject: [PATCH v10 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status
Date: Wed, 16 Sep 2020 14:21:57 +0800 [thread overview]
Message-ID: <1600237327-33618-3-git-send-email-zhengchuan@huawei.com> (raw)
In-Reply-To: <1600237327-33618-1-git-send-email-zhengchuan@huawei.com>
add DirtyRateStatus to denote calculating status.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
---
migration/dirtyrate.c | 26 ++++++++++++++++++++++++++
qapi/migration.json | 17 +++++++++++++++++
2 files changed, 43 insertions(+)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index bf7fd24..7bea8ff 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -22,6 +22,19 @@
#include "migration.h"
#include "dirtyrate.h"
+static int CalculatingState = DIRTY_RATE_STATUS_UNSTARTED;
+
+static int dirtyrate_set_state(int *state, int old_state, int new_state)
+{
+ assert(new_state < DIRTY_RATE_STATUS__MAX);
+ if (atomic_cmpxchg(state, old_state, new_state) == old_state) {
+ return 0;
+ } else {
+ return -1;
+ }
+}
+
+
static void calculate_dirtyrate(struct DirtyRateConfig config)
{
/* todo */
@@ -31,8 +44,21 @@ static void calculate_dirtyrate(struct DirtyRateConfig config)
void *get_dirtyrate_thread(void *arg)
{
struct DirtyRateConfig config = *(struct DirtyRateConfig *)arg;
+ int ret;
+
+ ret = dirtyrate_set_state(&CalculatingState, DIRTY_RATE_STATUS_UNSTARTED,
+ DIRTY_RATE_STATUS_MEASURING);
+ if (ret == -1) {
+ error_report("change dirtyrate state failed.");
+ return NULL;
+ }
calculate_dirtyrate(config);
+ ret = dirtyrate_set_state(&CalculatingState, DIRTY_RATE_STATUS_MEASURING,
+ DIRTY_RATE_STATUS_MEASURED);
+ if (ret == -1) {
+ error_report("change dirtyrate state failed.");
+ }
return NULL;
}
diff --git a/qapi/migration.json b/qapi/migration.json
index 5f6b061..061ff25 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1720,3 +1720,20 @@
##
{ 'event': 'UNPLUG_PRIMARY',
'data': { 'device-id': 'str' } }
+
+##
+# @DirtyRateStatus:
+#
+# An enumeration of dirtyrate status.
+#
+# @unstarted: the dirtyrate thread has not been started.
+#
+# @measuring: the dirtyrate thread is measuring.
+#
+# @measured: the dirtyrate thread has measured and results are available.
+#
+# Since: 5.2
+#
+##
+{ 'enum': 'DirtyRateStatus',
+ 'data': [ 'unstarted', 'measuring', 'measured'] }
--
1.8.3.1
next prev parent reply other threads:[~2020-09-16 6:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:21 [PATCH v10 00/12] *** A Method for evaluating dirty page rate *** Chuan Zheng
2020-09-16 6:21 ` [PATCH v10 01/12] migration/dirtyrate: setup up query-dirtyrate framwork Chuan Zheng
2020-09-16 6:21 ` Chuan Zheng [this message]
2020-09-16 6:21 ` [PATCH v10 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info Chuan Zheng
2020-09-16 6:21 ` [PATCH v10 04/12] migration/dirtyrate: Add dirtyrate statistics series functions Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 06/12] migration/dirtyrate: Record hash results for each sampled page Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 07/12] migration/dirtyrate: Compare page hash results for recorded " Chuan Zheng
2020-09-16 14:49 ` Li Qiang
2020-09-16 6:22 ` [PATCH v10 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 09/12] migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid() Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function Chuan Zheng
2020-09-16 6:22 ` [PATCH v10 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function Chuan Zheng
2020-09-17 9:08 ` Dr. David Alan Gilbert
2020-09-23 18:17 ` Eric Blake
2020-09-23 19:03 ` Dr. David Alan Gilbert
2020-09-24 8:42 ` Zheng Chuan
2020-09-16 6:22 ` [PATCH v10 12/12] migration/dirtyrate: Add trace_calls to make it easier to debug Chuan Zheng
2020-09-17 9:15 ` [PATCH v10 00/12] *** A Method for evaluating dirty page rate *** Dr. David Alan Gilbert
2020-09-17 9:22 ` Zheng Chuan
2020-09-17 9:38 ` Dr. David Alan Gilbert
2020-09-17 10:21 ` Zheng Chuan
2020-09-23 18:04 ` Dr. David Alan Gilbert
2020-09-23 18:18 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600237327-33618-3-git-send-email-zhengchuan@huawei.com \
--to=zhengchuan@huawei.com \
--cc=alex.chen@huawei.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=liq3ea@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=xiexiangyou@huawei.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).