Re: [PATCH-for-8.0] gitlab-ci: Remove job building EDK2 firmware binaries

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 13/3/23 10:35, Bin Meng wrote:
> Hi Philippe,
> 
> On Mon, Mar 13, 2023 at 4:51 PM Philippe Mathieu-Daudé
> <philmd@linaro.org> wrote:
>>
>> On 13/3/23 03:09, Bin Meng wrote:
>>> On Fri, Mar 10, 2023 at 9:50 PM Philippe Mathieu-Daudé
>>> <philmd@linaro.org> wrote:
>>>>
>>>> On 10/3/23 14:38, Peter Maydell wrote:
>>>>> On Fri, 10 Mar 2023 at 13:33, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>>>>>
>>>>>> When we introduced this Gitlab-CI job in commit 71920809ce
>>>>>> ("gitlab-ci.yml: Add jobs to build EDK2 firmware binaries"),
>>>>>> the naive plan was to have reproducible binaries by downloading
>>>>>> what this job would build, testing it and eventually committing
>>>>>> it. With retrospective, nothing happened 3 years later and this
>>>>>> job is just bitrotting:
>>>>>>
>>>>>>      Step 1/3 : FROM ubuntu:18.04
>>>>>>      18.04: Pulling from library/ubuntu
>>>>>>      mediaType in manifest should be
>>>>>>      'application/vnd.docker.distribution.manifest.v2+json' not
>>>>>>      'application/vnd.oci.image.manifest.v1+json'
>>>>>>
>>>>>> Remove this job to avoid wasting maintenance and CI ressources.
>>>>>
>>>>> Does the same thing hold for the opensbi job ?
>>>>
>>>> Cc'ing Bin, I have no idea.
>>>>
>>>
>>> The OpenSBI job now builds fine. I have no preference on keeping vs.
>>> removing it.
>>>
>>> I remember our previous goal was to create CI jobs for every pc-bios
>>> image but apparently that never happened.
>>
>> Yes, and I don't see interest in the community (neither worry that
>> pc-bios/ images committed are built on each maintainer workstations).
>>
>> If it isn't consumed by QEMU, then better remove that job and save
>> precious CI minutes. I presume OpenSBI itself is already tested
>> by its mainstream project.
> 
> Not sure what does "consumed" here mean?
> 
> QEMU uses OpenSBI images on RISC-V machines by default.

QEMU repository allows building QEMU system binaries which 'consume'
the following (committed) files:
- pc-bios/opensbi-riscv32-generic-fw_dynamic.bin
- pc-bios/opensbi-riscv64-generic-fw_dynamic.bin

We don't need to run the build-opensbi job to run QEMU: we use the
prebuilt images.