From: leirao <lei.rao@intel.com>
To: chen.zhang@intel.com, lizhijian@cn.fujitsu.com,
jasowang@redhat.com, quintela@redhat.com, dgilbert@redhat.com,
pbonzini@redhat.com
Cc: leirao <lei.rao@intel.com>, qemu-devel@nongnu.org
Subject: [PATCH v2 1/3] Optimize seq_sorter function for colo-compare
Date: Tue, 22 Sep 2020 05:24:48 -0400 [thread overview]
Message-ID: <1600766690-94980-2-git-send-email-lei.rao@intel.com> (raw)
In-Reply-To: <1600766690-94980-1-git-send-email-lei.rao@intel.com>
The seq of tcp has been filled in fill_pkt_tcp_info, it
can be used directly here.
Signed-off-by: leirao <lei.rao@intel.com>
---
net/colo-compare.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 3a45d64..86980ce 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -196,11 +196,7 @@ static void colo_compare_inconsistency_notify(CompareState *s)
static gint seq_sorter(Packet *a, Packet *b, gpointer data)
{
- struct tcp_hdr *atcp, *btcp;
-
- atcp = (struct tcp_hdr *)(a->transport_header);
- btcp = (struct tcp_hdr *)(b->transport_header);
- return ntohl(atcp->th_seq) - ntohl(btcp->th_seq);
+ return a->tcp_seq - b->tcp_seq;
}
static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)
--
1.8.3.1
next prev parent reply other threads:[~2020-09-22 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 9:24 [PATCH v2 0/3] Optimized some code for COLO leirao
2020-09-22 9:24 ` leirao [this message]
2020-09-23 1:20 ` [PATCH v2 1/3] Optimize seq_sorter function for colo-compare Zhang, Chen
2020-09-22 9:24 ` [PATCH v2 2/3] Reduce the time of checkpoint for COLO leirao
2020-09-23 1:25 ` Zhang, Chen
2020-09-23 3:59 ` Li Zhijian
2020-09-22 9:24 ` [PATCH v2 3/3] Fix the qemu crash when guest shutdown in COLO mode leirao
2020-09-23 1:27 ` Zhang, Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600766690-94980-2-git-send-email-lei.rao@intel.com \
--to=lei.rao@intel.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).