* [PATCH v1 1/8] migration: Do not use C99 // comments
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 10:57 ` [PATCH v1 2/8] migration: Don't use '#' flag of printf format Bihong Yu
` (7 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/block.c | 2 +-
migration/rdma.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 737b649..4b8576b 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -40,7 +40,7 @@
#define MAX_IO_BUFFERS 512
#define MAX_PARALLEL_IO 16
-//#define DEBUG_BLK_MIGRATION
+/* #define DEBUG_BLK_MIGRATION */
#ifdef DEBUG_BLK_MIGRATION
#define DPRINTF(fmt, ...) \
diff --git a/migration/rdma.c b/migration/rdma.c
index 0340841..0eb42b7 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1288,7 +1288,7 @@ const char *print_wrid(int wrid)
* workload information or LRU information is available, do not attempt to use
* this feature except for basic testing.
*/
-//#define RDMA_UNREGISTRATION_EXAMPLE
+/* #define RDMA_UNREGISTRATION_EXAMPLE */
/*
* Perform a non-optimized memory unregistration after every transfer
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v1 2/8] migration: Don't use '#' flag of printf format
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
2020-10-11 10:57 ` [PATCH v1 1/8] migration: Do not use C99 // comments Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 18:19 ` Peter Maydell
2020-10-11 10:57 ` [PATCH v1 3/8] migration: Add spaces around operator Bihong Yu
` (6 subsequent siblings)
8 siblings, 1 reply; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/block.c | 2 +-
migration/ram.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/migration/block.c b/migration/block.c
index 4b8576b..399dfb8 100644
--- a/migration/block.c
+++ b/migration/block.c
@@ -998,7 +998,7 @@ static int block_load(QEMUFile *f, void *opaque, int version_id)
(addr == 100) ? '\n' : '\r');
fflush(stdout);
} else if (!(flags & BLK_MIG_FLAG_EOS)) {
- fprintf(stderr, "Unknown block migration flags: %#x\n", flags);
+ fprintf(stderr, "Unknown block migration flags: %0x\n", flags);
return -EINVAL;
}
ret = qemu_file_get_error(f);
diff --git a/migration/ram.c b/migration/ram.c
index 433489d..59bdd15 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3298,7 +3298,7 @@ static int ram_load_postcopy(QEMUFile *f)
multifd_recv_sync_main();
break;
default:
- error_report("Unknown combination of migration flags: %#x"
+ error_report("Unknown combination of migration flags: %0x"
" (postcopy mode)", flags);
ret = -EINVAL;
break;
@@ -3576,7 +3576,7 @@ static int ram_load_precopy(QEMUFile *f)
if (flags & RAM_SAVE_FLAG_HOOK) {
ram_control_load_hook(f, RAM_CONTROL_HOOK, NULL);
} else {
- error_report("Unknown combination of migration flags: %#x",
+ error_report("Unknown combination of migration flags: %0x",
flags);
ret = -EINVAL;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v1 2/8] migration: Don't use '#' flag of printf format
2020-10-11 10:57 ` [PATCH v1 2/8] migration: Don't use '#' flag of printf format Bihong Yu
@ 2020-10-11 18:19 ` Peter Maydell
2020-10-12 12:45 ` Bihong Yu
0 siblings, 1 reply; 14+ messages in thread
From: Peter Maydell @ 2020-10-11 18:19 UTC (permalink / raw)
To: Bihong Yu
Cc: alex.chen, Juan Quintela, QEMU Trivial, QEMU Developers,
Dr. David Alan Gilbert, zhengchuan, wanghao232
On Sun, 11 Oct 2020 at 14:52, Bihong Yu <yubihong@huawei.com> wrote:
> @@ -998,7 +998,7 @@ static int block_load(QEMUFile *f, void *opaque, int version_id)
> (addr == 100) ? '\n' : '\r');
> fflush(stdout);
> } else if (!(flags & BLK_MIG_FLAG_EOS)) {
> - fprintf(stderr, "Unknown block migration flags: %#x\n", flags);
> + fprintf(stderr, "Unknown block migration flags: %0x\n", flags);
This doesn't look right. "%#x" will print a number in hex with a leading '0x'.
To get the same effect without using "#" you need "0x%x" (that is,
the format string provides the 0x characters literally).
What you've written is '%0x", which is a format string where the '0' is
a request to print with zero padding (which is ignored since there's no
field width given), so the result is the same as if you'd just said '%x',
and there is no '0x' in the output.
$ cat /tmp/zz9.c
#include <stdio.h>
int main(void) {
printf("%#x\n", 42);
printf("%0x\n", 42);
printf("0x%x\n", 42);
return 0;
}
$ gcc -g -Wall -o /tmp/zz9 /tmp/zz9.c
$ /tmp/zz9
0x2a
2a
0x2a
> default:
> - error_report("Unknown combination of migration flags: %#x"
> + error_report("Unknown combination of migration flags: %0x"
> " (postcopy mode)", flags);
> ret = -EINVAL;
> break;
> @@ -3576,7 +3576,7 @@ static int ram_load_precopy(QEMUFile *f)
> if (flags & RAM_SAVE_FLAG_HOOK) {
> ram_control_load_hook(f, RAM_CONTROL_HOOK, NULL);
> } else {
> - error_report("Unknown combination of migration flags: %#x",
> + error_report("Unknown combination of migration flags: %0x",
> flags);
> ret = -EINVAL;
> }
These two similarly should be "0x%x".
thanks
-- PMM
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH v1 2/8] migration: Don't use '#' flag of printf format
2020-10-11 18:19 ` Peter Maydell
@ 2020-10-12 12:45 ` Bihong Yu
0 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-12 12:45 UTC (permalink / raw)
To: Peter Maydell
Cc: alex.chen, Juan Quintela, QEMU Trivial, QEMU Developers,
Dr. David Alan Gilbert, zhengchuan, wanghao232
Thank you for your review. OK,I have fixed the problem in v2.
On 2020/10/12 2:19, Peter Maydell wrote:
> On Sun, 11 Oct 2020 at 14:52, Bihong Yu <yubihong@huawei.com> wrote:
>> @@ -998,7 +998,7 @@ static int block_load(QEMUFile *f, void *opaque, int version_id)
>> (addr == 100) ? '\n' : '\r');
>> fflush(stdout);
>> } else if (!(flags & BLK_MIG_FLAG_EOS)) {
>> - fprintf(stderr, "Unknown block migration flags: %#x\n", flags);
>> + fprintf(stderr, "Unknown block migration flags: %0x\n", flags);
>
> This doesn't look right. "%#x" will print a number in hex with a leading '0x'.
> To get the same effect without using "#" you need "0x%x" (that is,
> the format string provides the 0x characters literally).
> What you've written is '%0x", which is a format string where the '0' is
> a request to print with zero padding (which is ignored since there's no
> field width given), so the result is the same as if you'd just said '%x',
> and there is no '0x' in the output.
>
> $ cat /tmp/zz9.c
> #include <stdio.h>
> int main(void) {
> printf("%#x\n", 42);
> printf("%0x\n", 42);
> printf("0x%x\n", 42);
> return 0;
> }
> $ gcc -g -Wall -o /tmp/zz9 /tmp/zz9.c
> $ /tmp/zz9
> 0x2a
> 2a
> 0x2a
>
>> default:
>> - error_report("Unknown combination of migration flags: %#x"
>> + error_report("Unknown combination of migration flags: %0x"
>> " (postcopy mode)", flags);
>> ret = -EINVAL;
>> break;
>> @@ -3576,7 +3576,7 @@ static int ram_load_precopy(QEMUFile *f)
>> if (flags & RAM_SAVE_FLAG_HOOK) {
>> ram_control_load_hook(f, RAM_CONTROL_HOOK, NULL);
>> } else {
>> - error_report("Unknown combination of migration flags: %#x",
>> + error_report("Unknown combination of migration flags: %0x",
>> flags);
>> ret = -EINVAL;
>> }
>
> These two similarly should be "0x%x".
>
> thanks
> -- PMM
> .
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v1 3/8] migration: Add spaces around operator
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
2020-10-11 10:57 ` [PATCH v1 1/8] migration: Do not use C99 // comments Bihong Yu
2020-10-11 10:57 ` [PATCH v1 2/8] migration: Don't use '#' flag of printf format Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 10:57 ` [PATCH v1 4/8] migration: Open brace '{' following struct go on the same line Bihong Yu
` (5 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/migration.c | 4 ++--
migration/postcopy-ram.c | 2 +-
migration/ram.c | 2 +-
migration/savevm.c | 2 +-
migration/vmstate.c | 10 +++++-----
5 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 0575ecb..e050f57 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2478,8 +2478,8 @@ static void migrate_handle_rp_req_pages(MigrationState *ms, const char* rbname,
* Since we currently insist on matching page sizes, just sanity check
* we're being asked for whole host pages.
*/
- if (start & (our_host_ps-1) ||
- (len & (our_host_ps-1))) {
+ if (start & (our_host_ps - 1) ||
+ (len & (our_host_ps - 1))) {
error_report("%s: Misaligned page request, start: " RAM_ADDR_FMT
" len: %zd", __func__, start, len);
mark_source_rp_bad(ms);
diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c
index 0a2f88a8..eea92bb 100644
--- a/migration/postcopy-ram.c
+++ b/migration/postcopy-ram.c
@@ -403,7 +403,7 @@ bool postcopy_ram_supported_by_host(MigrationIncomingState *mis)
strerror(errno));
goto out;
}
- g_assert(((size_t)testarea & (pagesize-1)) == 0);
+ g_assert(((size_t)testarea & (pagesize - 1)) == 0);
reg_struct.range.start = (uintptr_t)testarea;
reg_struct.range.len = pagesize;
diff --git a/migration/ram.c b/migration/ram.c
index 59bdd15..90b277b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1563,7 +1563,7 @@ int ram_save_queue_pages(const char *rbname, ram_addr_t start, ram_addr_t len)
rs->last_req_rb = ramblock;
}
trace_ram_save_queue_pages(ramblock->idstr, start, len);
- if (start+len > ramblock->used_length) {
+ if (start + len > ramblock->used_length) {
error_report("%s request overrun start=" RAM_ADDR_FMT " len="
RAM_ADDR_FMT " blocklen=" RAM_ADDR_FMT,
__func__, start, len, ramblock->used_length);
diff --git a/migration/savevm.c b/migration/savevm.c
index d2e141f..9e95df1 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -521,7 +521,7 @@ static const VMStateDescription vmstate_configuration = {
VMSTATE_VBUFFER_ALLOC_UINT32(name, SaveState, 0, NULL, len),
VMSTATE_END_OF_LIST()
},
- .subsections = (const VMStateDescription*[]) {
+ .subsections = (const VMStateDescription * []) {
&vmstate_target_page_bits,
&vmstate_capabilites,
&vmstate_uuid,
diff --git a/migration/vmstate.c b/migration/vmstate.c
index bafa890..e9d2aef 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -32,13 +32,13 @@ static int vmstate_n_elems(void *opaque, const VMStateField *field)
if (field->flags & VMS_ARRAY) {
n_elems = field->num;
} else if (field->flags & VMS_VARRAY_INT32) {
- n_elems = *(int32_t *)(opaque+field->num_offset);
+ n_elems = *(int32_t *)(opaque + field->num_offset);
} else if (field->flags & VMS_VARRAY_UINT32) {
- n_elems = *(uint32_t *)(opaque+field->num_offset);
+ n_elems = *(uint32_t *)(opaque + field->num_offset);
} else if (field->flags & VMS_VARRAY_UINT16) {
- n_elems = *(uint16_t *)(opaque+field->num_offset);
+ n_elems = *(uint16_t *)(opaque + field->num_offset);
} else if (field->flags & VMS_VARRAY_UINT8) {
- n_elems = *(uint8_t *)(opaque+field->num_offset);
+ n_elems = *(uint8_t *)(opaque + field->num_offset);
}
if (field->flags & VMS_MULTIPLY_ELEMENTS) {
@@ -54,7 +54,7 @@ static int vmstate_size(void *opaque, const VMStateField *field)
int size = field->size;
if (field->flags & VMS_VBUFFER) {
- size = *(int32_t *)(opaque+field->size_offset);
+ size = *(int32_t *)(opaque + field->size_offset);
if (field->flags & VMS_MULTIPLY) {
size *= field->size;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v1 4/8] migration: Open brace '{' following struct go on the same line
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
` (2 preceding siblings ...)
2020-10-11 10:57 ` [PATCH v1 3/8] migration: Add spaces around operator Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 10:57 ` [PATCH v1 5/8] migration: Add braces {} for if statement Bihong Yu
` (4 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/migration.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.h b/migration/migration.h
index deb411a..99784b4 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -124,8 +124,7 @@ struct MigrationClass {
DeviceClass parent_class;
};
-struct MigrationState
-{
+struct MigrationState {
/*< private >*/
DeviceState parent_obj;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v1 5/8] migration: Add braces {} for if statement
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
` (3 preceding siblings ...)
2020-10-11 10:57 ` [PATCH v1 4/8] migration: Open brace '{' following struct go on the same line Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 10:57 ` [PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL Bihong Yu
` (3 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/ram.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 90b277b..12e7296 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -101,14 +101,16 @@ static struct {
static void XBZRLE_cache_lock(void)
{
- if (migrate_use_xbzrle())
+ if (migrate_use_xbzrle()) {
qemu_mutex_lock(&XBZRLE.lock);
+ }
}
static void XBZRLE_cache_unlock(void)
{
- if (migrate_use_xbzrle())
+ if (migrate_use_xbzrle()) {
qemu_mutex_unlock(&XBZRLE.lock);
+ }
}
/**
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
` (4 preceding siblings ...)
2020-10-11 10:57 ` [PATCH v1 5/8] migration: Add braces {} for if statement Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 10:57 ` [PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line Bihong Yu
` (2 subsequent siblings)
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/ram.c | 2 +-
migration/savevm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 12e7296..f71ff2b 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2743,7 +2743,7 @@ static int load_xbzrle(QEMUFile *f, ram_addr_t addr, void *host)
*/
static inline RAMBlock *ram_block_from_stream(QEMUFile *f, int flags)
{
- static RAMBlock *block = NULL;
+ static RAMBlock *block;
char id[256];
uint8_t len;
diff --git a/migration/savevm.c b/migration/savevm.c
index 9e95df1..f808bc2 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -64,7 +64,7 @@
#include "qemu/bitmap.h"
#include "net/announce.h"
-const unsigned int postcopy_ram_discard_version = 0;
+const unsigned int postcopy_ram_discard_version;
/* Subcommands for QEMU_VM_COMMAND */
enum qemu_vm_cmd {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
` (5 preceding siblings ...)
2020-10-11 10:57 ` [PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 10:57 ` [PATCH v1 8/8] migration: Delete redundant spaces Bihong Yu
2020-10-11 14:48 ` [PATCH v1 0/8] Fix some style problems in migration no-reply
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/rdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 0eb42b7..ca4d315 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -273,7 +273,8 @@ static uint64_t htonll(uint64_t v)
return u.llv;
}
-static uint64_t ntohll(uint64_t v) {
+static uint64_t ntohll(uint64_t v)
+{
union { uint32_t lv[2]; uint64_t llv; } u;
u.llv = v;
return ((uint64_t)ntohl(u.lv[0]) << 32) | (uint64_t) ntohl(u.lv[1]);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v1 8/8] migration: Delete redundant spaces
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
` (6 preceding siblings ...)
2020-10-11 10:57 ` [PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line Bihong Yu
@ 2020-10-11 10:57 ` Bihong Yu
2020-10-11 14:48 ` [PATCH v1 0/8] Fix some style problems in migration no-reply
8 siblings, 0 replies; 14+ messages in thread
From: Bihong Yu @ 2020-10-11 10:57 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: yubihong, zhengchuan, quintela, dgilbert, alex.chen, wanghao232
Signed-off-by:Bihong Yu <yubihong@huawei.com>
Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
Signed-off-by: Bihong Yu <yubihong@huawei.com>
---
migration/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index ca4d315..00eac34 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -855,7 +855,7 @@ static int qemu_rdma_broken_ipv6_kernel(struct ibv_context *verbs, Error **errp)
*/
if (!verbs) {
int num_devices, x;
- struct ibv_device ** dev_list = ibv_get_device_list(&num_devices);
+ struct ibv_device **dev_list = ibv_get_device_list(&num_devices);
bool roce_found = false;
bool ib_found = false;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH v1 0/8] Fix some style problems in migration
2020-10-11 10:57 [PATCH v1 0/8] Fix some style problems in migration Bihong Yu
` (7 preceding siblings ...)
2020-10-11 10:57 ` [PATCH v1 8/8] migration: Delete redundant spaces Bihong Yu
@ 2020-10-11 14:48 ` no-reply
8 siblings, 0 replies; 14+ messages in thread
From: no-reply @ 2020-10-11 14:48 UTC (permalink / raw)
To: yubihong
Cc: yubihong, alex.chen, quintela, qemu-trivial, dgilbert, qemu-devel,
zhengchuan, wanghao232
Patchew URL: https://patchew.org/QEMU/1602413863-19513-1-git-send-email-yubihong@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1602413863-19513-1-git-send-email-yubihong@huawei.com
Subject: [PATCH v1 0/8] Fix some style problems in migration
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com -> patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com
- [tag update] patchew/1602413321-22252-1-git-send-email-yubihong@huawei.com -> patchew/1602413321-22252-1-git-send-email-yubihong@huawei.com
* [new tag] patchew/1602413863-19513-1-git-send-email-yubihong@huawei.com -> patchew/1602413863-19513-1-git-send-email-yubihong@huawei.com
Switched to a new branch 'test'
e540883 migration: Delete redundant spaces
ba991ab migration: Open brace '{' following function declarations go on the next line
33cc992 migration: Do not initialise statics and globals to 0 or NULL
ca4a625 migration: Add braces {} for if statement
4f4c641 migration: Open brace '{' following struct go on the same line
abbc199 migration: Add spaces around operator
3395e18 migration: Don't use '#' flag of printf format
528909a migration: Do not use C99 // comments
=== OUTPUT BEGIN ===
1/8 Checking commit 528909ad70b3 (migration: Do not use C99 // comments)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 16 lines checked
Patch 1/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/8 Checking commit 3395e181c39f (migration: Don't use '#' flag of printf format)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 24 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit abbc1992ac91 (migration: Add spaces around operator)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 59 lines checked
Patch 3/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/8 Checking commit 4f4c64176326 (migration: Open brace '{' following struct go on the same line)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 9 lines checked
Patch 4/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/8 Checking commit ca4a625ffe25 (migration: Add braces {} for if statement)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 18 lines checked
Patch 5/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/8 Checking commit 33cc992647bd (migration: Do not initialise statics and globals to 0 or NULL)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 16 lines checked
Patch 6/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/8 Checking commit ba991ab5ea63 (migration: Open brace '{' following function declarations go on the next line)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 9 lines checked
Patch 7/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/8 Checking commit e540883aba9c (migration: Delete redundant spaces)
ERROR: space required after Signed-off-by:
#7:
Signed-off-by:Bihong Yu <yubihong@huawei.com>
total: 1 errors, 0 warnings, 8 lines checked
Patch 8/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1602413863-19513-1-git-send-email-yubihong@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 14+ messages in thread