qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] hw/intc: Move sifive_plic.h to the include directory
@ 2020-10-13  8:30 Bin Meng
  2020-10-14 19:13 ` Alistair Francis
  0 siblings, 1 reply; 2+ messages in thread
From: Bin Meng @ 2020-10-13  8:30 UTC (permalink / raw)
  To: Alistair Francis, Philippe Mathieu-Daudé, qemu-devel,
	qemu-riscv

Since sifive_plic.h is used by hw/intc/sifive_plic.c,
it has to be in the public include directory. Move it.

Fixes: 84fcf3c15111 ("hw/riscv: Move sifive_plic model to hw/intc")
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

---

Changes in v2:
- reword the commit message as Philippe suggested

 {hw => include/hw}/intc/sifive_plic.h | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename {hw => include/hw}/intc/sifive_plic.h (100%)

diff --git a/hw/intc/sifive_plic.h b/include/hw/intc/sifive_plic.h
similarity index 100%
rename from hw/intc/sifive_plic.h
rename to include/hw/intc/sifive_plic.h
-- 
2.7.4



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] hw/intc: Move sifive_plic.h to the include directory
  2020-10-13  8:30 [PATCH v2] hw/intc: Move sifive_plic.h to the include directory Bin Meng
@ 2020-10-14 19:13 ` Alistair Francis
  0 siblings, 0 replies; 2+ messages in thread
From: Alistair Francis @ 2020-10-14 19:13 UTC (permalink / raw)
  To: Bin Meng
  Cc: open list:RISC-V, Alistair Francis, Philippe Mathieu-Daudé,
	qemu-devel@nongnu.org Developers

On Tue, Oct 13, 2020 at 1:31 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> Since sifive_plic.h is used by hw/intc/sifive_plic.c,
> it has to be in the public include directory. Move it.
>
> Fixes: 84fcf3c15111 ("hw/riscv: Move sifive_plic model to hw/intc")
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

>
> ---
>
> Changes in v2:
> - reword the commit message as Philippe suggested
>
>  {hw => include/hw}/intc/sifive_plic.h | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename {hw => include/hw}/intc/sifive_plic.h (100%)
>
> diff --git a/hw/intc/sifive_plic.h b/include/hw/intc/sifive_plic.h
> similarity index 100%
> rename from hw/intc/sifive_plic.h
> rename to include/hw/intc/sifive_plic.h
> --
> 2.7.4
>
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-14 19:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-13  8:30 [PATCH v2] hw/intc: Move sifive_plic.h to the include directory Bin Meng
2020-10-14 19:13 ` Alistair Francis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).