qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Mihai Carabas <mihai.carabas@oracle.com>
To: qemu-devel@nongnu.org
Cc: Mihai Carabas <mihai.carabas@oracle.com>
Subject: [PATCH 6/6] pvpanic: break dependency on ISA_BUS adding PCI
Date: Wed, 28 Oct 2020 15:32:59 +0200	[thread overview]
Message-ID: <1603891979-11961-7-git-send-email-mihai.carabas@oracle.com> (raw)
In-Reply-To: <1603891979-11961-1-git-send-email-mihai.carabas@oracle.com>

pvpanic is supported on ARM VIRT MACHINE as an PCI device, no need for an ISA
bus.

Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
---
 hw/misc/Kconfig   | 2 +-
 hw/misc/pvpanic.c | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
index 3185456..b650982 100644
--- a/hw/misc/Kconfig
+++ b/hw/misc/Kconfig
@@ -117,7 +117,7 @@ config IOTKIT_SYSINFO
 
 config PVPANIC
     bool
-    depends on ISA_BUS
+    depends on ISA_BUS || PCI
 
 config AUX
     bool
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index b0bf7d4..f80cf6c 100644
--- a/hw/misc/pvpanic.c
+++ b/hw/misc/pvpanic.c
@@ -106,6 +106,7 @@ static const MemoryRegionOps pvpanic_ops = {
     },
 };
 
+#ifdef CONFIG_ISA_BUS
 static void pvpanic_isa_initfn(Object *obj)
 {
     PVPanicISAState *s = PVPANIC_ISA_DEVICE(obj);
@@ -153,6 +154,7 @@ static TypeInfo pvpanic_isa_info = {
     .instance_init = pvpanic_isa_initfn,
     .class_init    = pvpanic_isa_class_init,
 };
+#endif
 
 /* pvpanic pci device*/
 
@@ -193,7 +195,9 @@ static TypeInfo pvpanic_pci_info = {
 
 static void pvpanic_register_types(void)
 {
+#ifdef CONFIG_ISA_BUS
     type_register_static(&pvpanic_isa_info);
+#endif
     type_register_static(&pvpanic_pci_info);
 }
 
-- 
1.8.3.1



  parent reply	other threads:[~2020-10-28 14:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 13:32 [PATCH] Add support for pvpanic pci device Mihai Carabas
2020-10-28 13:32 ` [PATCH 1/6] hw/misc/pvpanic: Build the pvpanic device for any machine Mihai Carabas
2020-12-14 10:47   ` Peter Maydell
2020-12-14 10:54     ` Peter Maydell
2020-10-28 13:32 ` [PATCH 2/6] hw/misc/pvpanic: Cosmetic renaming Mihai Carabas
2020-12-14 10:20   ` Peter Maydell
2020-10-28 13:32 ` [PATCH 3/6] hw/misc/pvpanic: Add the PCI interface Mihai Carabas
2020-12-14 10:58   ` Peter Maydell
2020-10-28 13:32 ` [PATCH 4/6] hw/arm/virt: Use the pvpanic pci device Mihai Carabas
2020-12-14 10:24   ` Peter Maydell
2020-10-28 13:32 ` [PATCH 5/6] pvpanic : update pvpanic document Mihai Carabas
2020-12-14 10:30   ` Peter Maydell
2020-10-28 13:32 ` Mihai Carabas [this message]
2020-10-29 12:30 ` [PATCH] Add support for pvpanic pci device Mihai Carabas
2020-11-23 13:42   ` Mihai Carabas
2020-12-14 11:03 ` Peter Maydell
2020-12-14 11:15   ` Mihai Carabas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1603891979-11961-7-git-send-email-mihai.carabas@oracle.com \
    --to=mihai.carabas@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).