* [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support
@ 2020-11-02 19:50 Alejandro Jimenez
2020-11-09 11:40 ` [External] " zhenwei pi
0 siblings, 1 reply; 4+ messages in thread
From: Alejandro Jimenez @ 2020-11-02 19:50 UTC (permalink / raw)
To: qemu-devel; +Cc: pizhenwei
Advertise both types of events supported when the guest OS
queries the pvpanic device. Currently only PVPANIC_PANICKED is
exposed; PVPANIC_CRASHLOADED must also be advertised.
Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling")
Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
Acked-by: Mark Kanda <mark.kanda@oracle.com>
---
hw/misc/pvpanic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index 598d547..a55ce8e 100644
--- a/hw/misc/pvpanic.c
+++ b/hw/misc/pvpanic.c
@@ -66,7 +66,7 @@ struct PVPanicState {
/* return supported events on read */
static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr, unsigned size)
{
- return PVPANIC_PANICKED;
+ return PVPANIC_PANICKED | PVPANIC_CRASHLOADED;
}
static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t val,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [External] [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support
2020-11-02 19:50 [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support Alejandro Jimenez
@ 2020-11-09 11:40 ` zhenwei pi
2020-11-09 13:47 ` Paolo Bonzini
2020-11-09 13:49 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: zhenwei pi @ 2020-11-09 11:40 UTC (permalink / raw)
To: Alejandro Jimenez, Paolo Bonzini; +Cc: qemu-devel
Hi, Paolo
This patch seems getting ignored. Because no maintainers found for
hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you).
About this patch:
Looks good. And also test it, works fine.
Reviewed-by: zhenwei pi <pizhenwei@bytedance.com>
On 11/3/20 3:50 AM, Alejandro Jimenez wrote:
> Advertise both types of events supported when the guest OS
> queries the pvpanic device. Currently only PVPANIC_PANICKED is
> exposed; PVPANIC_CRASHLOADED must also be advertised.
>
> Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling")
> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
> Acked-by: Mark Kanda <mark.kanda@oracle.com>
> ---
> hw/misc/pvpanic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
> index 598d547..a55ce8e 100644
> --- a/hw/misc/pvpanic.c
> +++ b/hw/misc/pvpanic.c
> @@ -66,7 +66,7 @@ struct PVPanicState {
> /* return supported events on read */
> static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr, unsigned size)
> {
> - return PVPANIC_PANICKED;
> + return PVPANIC_PANICKED | PVPANIC_CRASHLOADED;
> }
>
> static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t val,
>
--
zhenwei pi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [External] [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support
2020-11-09 11:40 ` [External] " zhenwei pi
@ 2020-11-09 13:47 ` Paolo Bonzini
2020-11-09 13:49 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-11-09 13:47 UTC (permalink / raw)
To: zhenwei pi, Alejandro Jimenez; +Cc: qemu-devel
On 09/11/20 12:40, zhenwei pi wrote:
> Hi, Paolo
>
> This patch seems getting ignored. Because no maintainers found for
> hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you).
>
>
> About this patch:
> Looks good. And also test it, works fine.
>
> Reviewed-by: zhenwei pi <pizhenwei@bytedance.com>
>
> On 11/3/20 3:50 AM, Alejandro Jimenez wrote:
>> Advertise both types of events supported when the guest OS
>> queries the pvpanic device. Currently only PVPANIC_PANICKED is
>> exposed; PVPANIC_CRASHLOADED must also be advertised.
>>
>> Fixes: 7dc58deea79a ("pvpanic: implement crashloaded event handling")
>> Signed-off-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
>> Acked-by: Mark Kanda <mark.kanda@oracle.com>
>> ---
>> hw/misc/pvpanic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
>> index 598d547..a55ce8e 100644
>> --- a/hw/misc/pvpanic.c
>> +++ b/hw/misc/pvpanic.c
>> @@ -66,7 +66,7 @@ struct PVPanicState {
>> /* return supported events on read */
>> static uint64_t pvpanic_ioport_read(void *opaque, hwaddr addr,
>> unsigned size)
>> {
>> - return PVPANIC_PANICKED;
>> + return PVPANIC_PANICKED | PVPANIC_CRASHLOADED;
>> }
>> static void pvpanic_ioport_write(void *opaque, hwaddr addr, uint64_t
>> val,
>>
>
Queued now, thanks Zhenwei.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [External] [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support
2020-11-09 11:40 ` [External] " zhenwei pi
2020-11-09 13:47 ` Paolo Bonzini
@ 2020-11-09 13:49 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2020-11-09 13:49 UTC (permalink / raw)
To: zhenwei pi, Alejandro Jimenez; +Cc: qemu-devel
On 09/11/20 12:40, zhenwei pi wrote:
> Hi, Paolo
>
> This patch seems getting ignored. Because no maintainers found for
> hw/misc/pvpanic.c, I also send this to you(hope it doesn't disturb you).
Actually it needs compat stuff for old machine types. I'll send v2.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-09 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-02 19:50 [PATCH 1/1] pvpanic: Advertise the PVPANIC_CRASHLOADED event support Alejandro Jimenez
2020-11-09 11:40 ` [External] " zhenwei pi
2020-11-09 13:47 ` Paolo Bonzini
2020-11-09 13:49 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).