From: Joe Komlodi <joe.komlodi@xilinx.com>
To: <qemu-devel@nongnu.org>
Cc: figlesia@xilinx.com, alistair@alistair23.me,
philippe.mathieu.daude@gmail.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: [PATCH v3 1/3] hw/block/m25p80: Fix Numonyx NVCFG DIO and QIO bit polarity
Date: Thu, 5 Nov 2020 17:32:56 -0800 [thread overview]
Message-ID: <1604626378-152352-2-git-send-email-komlodi@xilinx.com> (raw)
In-Reply-To: <1604626378-152352-1-git-send-email-komlodi@xilinx.com>
QIO and DIO modes should be enabled when the bits in NVCFG are set to 0.
This matches the behavior of the other bits in the NVCFG register.
Signed-off-by: Joe Komlodi <komlodi@xilinx.com>
---
hw/block/m25p80.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 483925f..4255a6a 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -783,10 +783,10 @@ static void reset_memory(Flash *s)
s->enh_volatile_cfg |= EVCFG_OUT_DRIVER_STRENGTH_DEF;
s->enh_volatile_cfg |= EVCFG_VPP_ACCELERATOR;
s->enh_volatile_cfg |= EVCFG_RESET_HOLD_ENABLED;
- if (s->nonvolatile_cfg & NVCFG_DUAL_IO_MASK) {
+ if (!(s->nonvolatile_cfg & NVCFG_DUAL_IO_MASK)) {
s->enh_volatile_cfg |= EVCFG_DUAL_IO_ENABLED;
}
- if (s->nonvolatile_cfg & NVCFG_QUAD_IO_MASK) {
+ if (!(s->nonvolatile_cfg & NVCFG_QUAD_IO_MASK)) {
s->enh_volatile_cfg |= EVCFG_QUAD_IO_ENABLED;
}
if (!(s->nonvolatile_cfg & NVCFG_4BYTE_ADDR_MASK)) {
--
2.7.4
next prev parent reply other threads:[~2020-11-06 1:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 1:32 [PATCH v3 0/3] hw/block/m25p80: Numonyx: Fix dummy cycles and check for SPI mode on cmds Joe Komlodi
2020-11-06 1:32 ` Joe Komlodi [this message]
2020-11-09 14:21 ` [PATCH v3 1/3] hw/block/m25p80: Fix Numonyx NVCFG DIO and QIO bit polarity Philippe Mathieu-Daudé
2020-11-10 0:22 ` Joe Komlodi
2020-11-11 14:33 ` Francisco Iglesias
2020-11-13 0:44 ` Joe Komlodi
2020-11-06 1:32 ` [PATCH v3 2/3] hw/block/m25p80: Check SPI mode before running some Numonyx commands Joe Komlodi
2020-11-11 15:22 ` Francisco Iglesias
2020-11-06 1:32 ` [PATCH v3 3/3] hw/block/m25p80: Fix Numonyx fast read dummy cycle count Joe Komlodi
2020-11-11 15:40 ` Francisco Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604626378-152352-2-git-send-email-komlodi@xilinx.com \
--to=joe.komlodi@xilinx.com \
--cc=alistair@alistair23.me \
--cc=figlesia@xilinx.com \
--cc=mreitz@redhat.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).