From: Joe Komlodi <joe.komlodi@xilinx.com>
To: <qemu-devel@nongnu.org>
Cc: figlesia@xilinx.com, alistair@alistair23.me,
philippe.mathieu.daude@gmail.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: [PATCH v4 2/4] hw/block/m25p80: Fix when VCFG XIP bit is set for Numonyx
Date: Thu, 12 Nov 2020 19:10:53 -0800 [thread overview]
Message-ID: <1605237055-393580-3-git-send-email-komlodi@xilinx.com> (raw)
In-Reply-To: <1605237055-393580-1-git-send-email-komlodi@xilinx.com>
VCFG XIP is set (disabled) when the NVCFG XIP bits are all set (disabled).
Signed-off-by: Joe Komlodi <komlodi@xilinx.com>
---
hw/block/m25p80.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 452d252..eb6539f 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -768,7 +768,7 @@ static void reset_memory(Flash *s)
s->volatile_cfg |= VCFG_DUMMY;
s->volatile_cfg |= VCFG_WRAP_SEQUENTIAL;
if ((s->nonvolatile_cfg & NVCFG_XIP_MODE_MASK)
- != NVCFG_XIP_MODE_DISABLED) {
+ == NVCFG_XIP_MODE_DISABLED) {
s->volatile_cfg |= VCFG_XIP_MODE_DISABLED;
}
s->volatile_cfg |= deposit32(s->volatile_cfg,
--
2.7.4
next prev parent reply other threads:[~2020-11-13 3:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 3:10 [PATCH v4 0/4] hw/block/m25p80: Numonyx: Fix dummy cycles and check for SPI mode on cmds Joe Komlodi
2020-11-13 3:10 ` [PATCH v4 1/4] hw/block/m25p80: Make Numonyx config field names more accurate Joe Komlodi
2020-11-16 15:37 ` Francisco Iglesias
2020-11-13 3:10 ` Joe Komlodi [this message]
2020-11-16 15:38 ` [PATCH v4 2/4] hw/block/m25p80: Fix when VCFG XIP bit is set for Numonyx Francisco Iglesias
2020-11-13 3:10 ` [PATCH v4 3/4] hw/block/m25p80: Check SPI mode before running some Numonyx commands Joe Komlodi
2020-11-16 15:58 ` Francisco Iglesias
2020-11-16 19:14 ` Joe Komlodi
2020-11-13 3:10 ` [PATCH v4 4/4] hw/block/m25p80: Fix Numonyx fast read dummy cycle count Joe Komlodi
2020-11-16 16:30 ` Francisco Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605237055-393580-3-git-send-email-komlodi@xilinx.com \
--to=joe.komlodi@xilinx.com \
--cc=alistair@alistair23.me \
--cc=figlesia@xilinx.com \
--cc=mreitz@redhat.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).