From: Andrey Shinkevich via <qemu-devel@nongnu.org>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com,
pbonzini@redhat.com, kwolf@redhat.com, mreitz@redhat.com,
armbru@redhat.com, dgilbert@redhat.com, den@openvz.org,
vsementsov@virtuozzo.com, andrey.shinkevich@virtuozzo.com
Subject: [PATCH v2 0/2] Increase amount of data for monitor to read
Date: Mon, 23 Nov 2020 18:44:32 +0300 [thread overview]
Message-ID: <1606146274-246154-1-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
The subject was discussed here:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg00206.html
This series is a solution for the issue with QMP monitor buffered input.
A JSON little parser is introduced to separate QMP commands read from the
input buffer so that incoming requests do not overwhelm the monitor queue.
A side effect raised in the test #247 was managed in the first patch.
It may be considered as a workaround. Any sane fix suggested will be
appreciated.
Note:
This series goes after the Vladimir's one:
'[PATCH v3 00/25] backup performance: block_status + async"'
To make the test #129 passed, the following patch should be applied first:
'[PATCH v3 01/25] iotests: 129 don't check backup "busy"'.
v2:
02: The static JSONthrottle object was made a member of the Chardev structure.
The fd_chr_read functions were merged.
The monitor thread synchronization was added to protect the input queue
from overflow.
Andrey Shinkevich (2):
iotests: add another bash sleep command to 247
monitor: increase amount of data for monitor to read
chardev/char-fd.c | 35 +++++++++++++++++++++++++++++++++--
chardev/char-socket.c | 42 +++++++++++++++++++++++++++++++++++++++---
chardev/char.c | 41 +++++++++++++++++++++++++++++++++++++++++
include/chardev/char.h | 15 +++++++++++++++
monitor/monitor.c | 2 +-
tests/qemu-iotests/247 | 2 ++
tests/qemu-iotests/247.out | 1 +
7 files changed, 132 insertions(+), 6 deletions(-)
--
1.8.3.1
next reply other threads:[~2020-11-23 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 15:44 Andrey Shinkevich via [this message]
2020-11-23 15:44 ` [PATCH v2 1/2] iotests: add another bash sleep command to 247 Andrey Shinkevich via
2020-11-24 10:04 ` Vladimir Sementsov-Ogievskiy
2020-11-24 12:08 ` Andrey Shinkevich
2020-11-25 10:35 ` Dr. David Alan Gilbert
2020-11-24 12:29 ` Andrey Shinkevich
2020-11-23 15:44 ` [PATCH v2 2/2] monitor: increase amount of data for monitor to read Andrey Shinkevich via
2020-11-24 11:03 ` Vladimir Sementsov-Ogievskiy
2020-11-24 15:04 ` Vladimir Sementsov-Ogievskiy
2020-11-27 13:35 ` Andrey Shinkevich
2020-11-23 16:55 ` [PATCH v2 0/2] Increase " Andrey Shinkevich
2020-11-23 17:13 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1606146274-246154-1-git-send-email-andrey.shinkevich@virtuozzo.com \
--to=qemu-devel@nongnu.org \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).