* [PULL 0/5] Net patches @ 2020-11-24 2:44 Jason Wang 2020-11-24 2:44 ` [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor Jason Wang ` (5 more replies) 0 siblings, 6 replies; 15+ messages in thread From: Jason Wang @ 2020-11-24 2:44 UTC (permalink / raw) To: peter.maydell, qemu-devel; +Cc: Jason Wang The following changes since commit 23895cbd82be95428e90168b12e925d0d3ca2f06: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201123.0' into staging (2020-11-23 18:51:13 +0000) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to 9925990d01a92564af55f6f69d0f5f59b47609b1: net: Use correct default-path macro for downscript (2020-11-24 10:40:17 +0800) ---------------------------------------------------------------- ---------------------------------------------------------------- Keqian Zhu (1): net: Use correct default-path macro for downscript Paolo Bonzini (1): net: do not exit on "netdev_add help" monitor command Prasad J Pandit (1): hw/net/e1000e: advance desc_offset in case of null descriptor Yuri Benditovich (1): net: purge queued rx packets on queue deletion yuanjungong (1): tap: fix a memory leak hw/net/e1000e_core.c | 8 +++--- include/net/net.h | 1 + monitor/hmp-cmds.c | 6 ++++ net/net.c | 80 +++++++++++++++++++++++++++------------------------- net/tap.c | 5 +++- 5 files changed, 57 insertions(+), 43 deletions(-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang @ 2020-11-24 2:44 ` Jason Wang 2020-11-24 2:44 ` [PULL 2/5] net: do not exit on "netdev_add help" monitor command Jason Wang ` (4 subsequent siblings) 5 siblings, 0 replies; 15+ messages in thread From: Jason Wang @ 2020-11-24 2:44 UTC (permalink / raw) To: peter.maydell, qemu-devel; +Cc: Jason Wang, Prasad J Pandit From: Prasad J Pandit <pjp@fedoraproject.org> While receiving packets via e1000e_write_packet_to_guest() routine, 'desc_offset' is advanced only when RX descriptor is processed. And RX descriptor is not processed if it has NULL buffer address. This may lead to an infinite loop condition. Increament 'desc_offset' to process next descriptor in the ring to avoid infinite loop. Reported-by: Cheol-woo Myung <330cjfdn@gmail.com> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> Signed-off-by: Jason Wang <jasowang@redhat.com> --- hw/net/e1000e_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index d8b9e4b..095c01e 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -1596,13 +1596,13 @@ e1000e_write_packet_to_guest(E1000ECore *core, struct NetRxPkt *pkt, (const char *) &fcs_pad, e1000x_fcs_len(core->mac)); } } - desc_offset += desc_size; - if (desc_offset >= total_size) { - is_last = true; - } } else { /* as per intel docs; skip descriptors with null buf addr */ trace_e1000e_rx_null_descriptor(); } + desc_offset += desc_size; + if (desc_offset >= total_size) { + is_last = true; + } e1000e_write_rx_descr(core, desc, is_last ? core->rx_pkt : NULL, rss_info, do_ps ? ps_hdr_len : 0, &bastate.written); -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PULL 2/5] net: do not exit on "netdev_add help" monitor command 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang 2020-11-24 2:44 ` [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor Jason Wang @ 2020-11-24 2:44 ` Jason Wang 2020-11-24 2:44 ` [PULL 3/5] net: purge queued rx packets on queue deletion Jason Wang ` (3 subsequent siblings) 5 siblings, 0 replies; 15+ messages in thread From: Jason Wang @ 2020-11-24 2:44 UTC (permalink / raw) To: peter.maydell, qemu-devel; +Cc: Paolo Bonzini, Jason Wang From: Paolo Bonzini <pbonzini@redhat.com> "netdev_add help" is causing QEMU to exit because the code that invokes show_netdevs is shared between CLI and HMP processing. Move the check to the callers so that exit(0) remains only in the CLI flow. "netdev_add help" is not fixed by this patch; that is left for later work. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com> --- include/net/net.h | 1 + monitor/hmp-cmds.c | 6 +++++ net/net.c | 68 +++++++++++++++++++++++++++--------------------------- 3 files changed, 41 insertions(+), 34 deletions(-) diff --git a/include/net/net.h b/include/net/net.h index 897b2d7..778fc78 100644 --- a/include/net/net.h +++ b/include/net/net.h @@ -199,6 +199,7 @@ extern const char *host_net_devices[]; /* from net.c */ int net_client_parse(QemuOptsList *opts_list, const char *str); +void show_netdevs(void); int net_init_clients(Error **errp); void net_check_clients(void); void net_cleanup(void); diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index a6a6684..65d8ff4 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -24,6 +24,7 @@ #include "qemu/option.h" #include "qemu/timer.h" #include "qemu/sockets.h" +#include "qemu/help_option.h" #include "monitor/monitor-internal.h" #include "qapi/error.h" #include "qapi/clone-visitor.h" @@ -1631,7 +1632,12 @@ void hmp_netdev_add(Monitor *mon, const QDict *qdict) { Error *err = NULL; QemuOpts *opts; + const char *type = qdict_get_try_str(qdict, "type"); + if (type && is_help_option(type)) { + show_netdevs(); + return; + } opts = qemu_opts_from_qdict(qemu_find_opts("netdev"), qdict, &err); if (err) { goto out; diff --git a/net/net.c b/net/net.c index 794c652..6362d30 100644 --- a/net/net.c +++ b/net/net.c @@ -44,6 +44,7 @@ #include "qemu/config-file.h" #include "qemu/ctype.h" #include "qemu/iov.h" +#include "qemu/qemu-print.h" #include "qemu/main-loop.h" #include "qemu/option.h" #include "qapi/error.h" @@ -1025,7 +1026,7 @@ static int net_client_init1(const Netdev *netdev, bool is_netdev, Error **errp) return 0; } -static void show_netdevs(void) +void show_netdevs(void) { int idx; const char *available_netdevs[] = { @@ -1055,9 +1056,9 @@ static void show_netdevs(void) #endif }; - printf("Available netdev backend types:\n"); + qemu_printf("Available netdev backend types:\n"); for (idx = 0; idx < ARRAY_SIZE(available_netdevs); idx++) { - puts(available_netdevs[idx]); + qemu_printf("%s\n", available_netdevs[idx]); } } @@ -1068,42 +1069,35 @@ static int net_client_init(QemuOpts *opts, bool is_netdev, Error **errp) int ret = -1; Visitor *v = opts_visitor_new(opts); - const char *type = qemu_opt_get(opts, "type"); - - if (is_netdev && type && is_help_option(type)) { - show_netdevs(); - exit(0); - } else { - /* Parse convenience option format ip6-net=fec0::0[/64] */ - const char *ip6_net = qemu_opt_get(opts, "ipv6-net"); + /* Parse convenience option format ip6-net=fec0::0[/64] */ + const char *ip6_net = qemu_opt_get(opts, "ipv6-net"); - if (ip6_net) { - char *prefix_addr; - unsigned long prefix_len = 64; /* Default 64bit prefix length. */ + if (ip6_net) { + char *prefix_addr; + unsigned long prefix_len = 64; /* Default 64bit prefix length. */ - substrings = g_strsplit(ip6_net, "/", 2); - if (!substrings || !substrings[0]) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "ipv6-net", - "a valid IPv6 prefix"); - goto out; - } + substrings = g_strsplit(ip6_net, "/", 2); + if (!substrings || !substrings[0]) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "ipv6-net", + "a valid IPv6 prefix"); + goto out; + } - prefix_addr = substrings[0]; + prefix_addr = substrings[0]; - /* Handle user-specified prefix length. */ - if (substrings[1] && - qemu_strtoul(substrings[1], NULL, 10, &prefix_len)) - { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, - "ipv6-prefixlen", "a number"); - goto out; - } - - qemu_opt_set(opts, "ipv6-prefix", prefix_addr, &error_abort); - qemu_opt_set_number(opts, "ipv6-prefixlen", prefix_len, - &error_abort); - qemu_opt_unset(opts, "ipv6-net"); + /* Handle user-specified prefix length. */ + if (substrings[1] && + qemu_strtoul(substrings[1], NULL, 10, &prefix_len)) + { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, + "ipv6-prefixlen", "a number"); + goto out; } + + qemu_opt_set(opts, "ipv6-prefix", prefix_addr, &error_abort); + qemu_opt_set_number(opts, "ipv6-prefixlen", prefix_len, + &error_abort); + qemu_opt_unset(opts, "ipv6-net"); } /* Create an ID for -net if the user did not specify one */ @@ -1421,6 +1415,12 @@ static int net_init_client(void *dummy, QemuOpts *opts, Error **errp) static int net_init_netdev(void *dummy, QemuOpts *opts, Error **errp) { + const char *type = qemu_opt_get(opts, "type"); + + if (type && is_help_option(type)) { + show_netdevs(); + exit(0); + } return net_client_init(opts, true, errp); } -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PULL 3/5] net: purge queued rx packets on queue deletion 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang 2020-11-24 2:44 ` [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor Jason Wang 2020-11-24 2:44 ` [PULL 2/5] net: do not exit on "netdev_add help" monitor command Jason Wang @ 2020-11-24 2:44 ` Jason Wang 2020-11-24 2:44 ` [PULL 4/5] tap: fix a memory leak Jason Wang ` (2 subsequent siblings) 5 siblings, 0 replies; 15+ messages in thread From: Jason Wang @ 2020-11-24 2:44 UTC (permalink / raw) To: peter.maydell, qemu-devel; +Cc: Yuri Benditovich, Jason Wang From: Yuri Benditovich <yuri.benditovich@daynix.com> https://bugzilla.redhat.com/show_bug.cgi?id=1829272 When deleting queue pair, purge pending RX packets if any. Example of problematic flow: 1. Bring up q35 VM with tap (vhost off) and virtio-net or e1000e 2. Run ping flood to the VM NIC ( 1 ms interval) 3. Hot unplug the NIC device (device_del) During unplug process one or more packets come, the NIC can't receive, tap disables read_poll 4. Hot plug the device (device_add) with the same netdev The tap stays with read_poll disabled and does not receive any packets anymore (tap_send never triggered) Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com> Signed-off-by: Jason Wang <jasowang@redhat.com> --- net/net.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/net/net.c b/net/net.c index 6362d30..6a2c3d9 100644 --- a/net/net.c +++ b/net/net.c @@ -412,10 +412,14 @@ void qemu_del_nic(NICState *nic) qemu_macaddr_set_free(&nic->conf->macaddr); - /* If this is a peer NIC and peer has already been deleted, free it now. */ - if (nic->peer_deleted) { - for (i = 0; i < queues; i++) { - qemu_free_net_client(qemu_get_subqueue(nic, i)->peer); + for (i = 0; i < queues; i++) { + NetClientState *nc = qemu_get_subqueue(nic, i); + /* If this is a peer NIC and peer has already been deleted, free it now. */ + if (nic->peer_deleted) { + qemu_free_net_client(nc->peer); + } else if (nc->peer) { + /* if there are RX packets pending, complete them */ + qemu_purge_queued_packets(nc->peer); } } -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PULL 4/5] tap: fix a memory leak 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang ` (2 preceding siblings ...) 2020-11-24 2:44 ` [PULL 3/5] net: purge queued rx packets on queue deletion Jason Wang @ 2020-11-24 2:44 ` Jason Wang 2020-11-24 2:44 ` [PULL 5/5] net: Use correct default-path macro for downscript Jason Wang 2020-11-24 13:33 ` [PULL 0/5] Net patches Peter Maydell 5 siblings, 0 replies; 15+ messages in thread From: Jason Wang @ 2020-11-24 2:44 UTC (permalink / raw) To: peter.maydell, qemu-devel; +Cc: yuanjungong, Jason Wang From: yuanjungong <ruc_gongyuanjun@163.com> Close fd before returning. Buglink: https://bugs.launchpad.net/qemu/+bug/1904486 Signed-off-by: yuanjungong <ruc_gongyuanjun@163.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Jason Wang <jasowang@redhat.com> --- net/tap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/tap.c b/net/tap.c index c46ff66..fe95fa7 100644 --- a/net/tap.c +++ b/net/tap.c @@ -817,6 +817,7 @@ int net_init_tap(const Netdev *netdev, const char *name, if (ret < 0) { error_setg_errno(errp, -ret, "%s: Can't use file descriptor %d", name, fd); + close(fd); return -1; } @@ -831,6 +832,7 @@ int net_init_tap(const Netdev *netdev, const char *name, vhostfdname, vnet_hdr, fd, &err); if (err) { error_propagate(errp, err); + close(fd); return -1; } } else if (tap->has_fds) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PULL 5/5] net: Use correct default-path macro for downscript 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang ` (3 preceding siblings ...) 2020-11-24 2:44 ` [PULL 4/5] tap: fix a memory leak Jason Wang @ 2020-11-24 2:44 ` Jason Wang 2020-11-24 13:33 ` [PULL 0/5] Net patches Peter Maydell 5 siblings, 0 replies; 15+ messages in thread From: Jason Wang @ 2020-11-24 2:44 UTC (permalink / raw) To: peter.maydell, qemu-devel; +Cc: Jason Wang, Keqian Zhu From: Keqian Zhu <zhukeqian1@huawei.com> Fixes: 63c4db4c2e6d (net: relocate paths to helpers and scripts) Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com> Signed-off-by: Jason Wang <jasowang@redhat.com> --- net/tap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index fe95fa7..b751285 100644 --- a/net/tap.c +++ b/net/tap.c @@ -953,7 +953,8 @@ free_fail: script = default_script = get_relocated_path(DEFAULT_NETWORK_SCRIPT); } if (!downscript) { - downscript = default_downscript = get_relocated_path(DEFAULT_NETWORK_SCRIPT); + downscript = default_downscript = + get_relocated_path(DEFAULT_NETWORK_DOWN_SCRIPT); } if (tap->has_ifname) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PULL 0/5] Net patches 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang ` (4 preceding siblings ...) 2020-11-24 2:44 ` [PULL 5/5] net: Use correct default-path macro for downscript Jason Wang @ 2020-11-24 13:33 ` Peter Maydell 5 siblings, 0 replies; 15+ messages in thread From: Peter Maydell @ 2020-11-24 13:33 UTC (permalink / raw) To: Jason Wang; +Cc: QEMU Developers On Tue, 24 Nov 2020 at 02:44, Jason Wang <jasowang@redhat.com> wrote: > > The following changes since commit 23895cbd82be95428e90168b12e925d0d3ca2f06: > > Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20201123.0' into staging (2020-11-23 18:51:13 +0000) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 9925990d01a92564af55f6f69d0f5f59b47609b1: > > net: Use correct default-path macro for downscript (2020-11-24 10:40:17 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.2 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PULL 0/5] Net patches @ 2021-08-02 4:33 Jason Wang 2021-08-02 10:40 ` Peter Maydell 0 siblings, 1 reply; 15+ messages in thread From: Jason Wang @ 2021-08-02 4:33 UTC (permalink / raw) To: qemu-devel, peter.maydell; +Cc: Jason Wang The following changes since commit 0c633cf0c221922a0a9f9d0b8866cbb111f5e192: Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210730' into staging (2021-07-31 21:29:57 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to cfe6d6841ff46b43ec38792422f690813f4ce3bf: hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor (2021-08-02 12:19:18 +0800) ---------------------------------------------------------------- ---------------------------------------------------------------- Christina Wang (3): hw/net: e1000: Correct the initial value of VET register hw/net: e1000e: Correct the initial value of VET register hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor Pavel Pisa (1): hw/net/can: sja1000 fix buff2frame_bas and buff2frame_pel when dlc is out of std CAN 8 bytes Thomas Huth (1): hw/net/vmxnet3: Do not abort QEMU if guest specified bad queue numbers hw/core/machine.c | 2 ++ hw/net/can/can_sja1000.c | 8 ++++++++ hw/net/e1000.c | 17 +++++++++++++++++ hw/net/e1000e.c | 8 +++++++- hw/net/e1000e_core.c | 10 ++++------ hw/net/vmxnet3.c | 34 ++++++++++++++++++++++------------ 6 files changed, 60 insertions(+), 19 deletions(-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PULL 0/5] Net patches 2021-08-02 4:33 Jason Wang @ 2021-08-02 10:40 ` Peter Maydell 0 siblings, 0 replies; 15+ messages in thread From: Peter Maydell @ 2021-08-02 10:40 UTC (permalink / raw) To: Jason Wang; +Cc: QEMU Developers On Mon, 2 Aug 2021 at 05:33, Jason Wang <jasowang@redhat.com> wrote: > > The following changes since commit 0c633cf0c221922a0a9f9d0b8866cbb111f5e192: > > Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210730' into staging (2021-07-31 21:29:57 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to cfe6d6841ff46b43ec38792422f690813f4ce3bf: > > hw/net: e1000e: Don't zero out the VLAN tag in the legacy RX descriptor (2021-08-02 12:19:18 +0800) > > ---------------------------------------------------------------- > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PULL 0/5] Net patches @ 2024-03-29 7:10 Jason Wang 2024-03-31 15:42 ` Peter Maydell 2024-03-31 19:21 ` Michael Tokarev 0 siblings, 2 replies; 15+ messages in thread From: Jason Wang @ 2024-03-29 7:10 UTC (permalink / raw) To: qemu-devel; +Cc: peter.maydell, Jason Wang The following changes since commit 5012e522aca161be5c141596c66e5cc6082538a9: Update version for v9.0.0-rc1 release (2024-03-26 19:46:55 +0000) are available in the Git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to d9b33018a0da51eddceb48c42345cfb351065f3e: Revert "tap: setting error appropriately when calling net_init_tap_one()" (2024-03-29 14:59:07 +0800) ---------------------------------------------------------------- -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEIV1G9IJGaJ7HfzVi7wSWWzmNYhEFAmYGZ7EACgkQ7wSWWzmN YhHvxgf/SDEYYMlxU7PA1SfwlIYtUG8K1zQnwLXNY6ySCJuCn1IdVoITaUt3BtE5 OtrhKI8cW5WwL4qzkElWlL431vyqomGdmJQedF8agwoR2aIo24i/Ue09MHxJxXUB ONEOv3bizDCYWUjz+PMHRdIbo0AiSNaUDnB8iY59yD6HZqSLVMDx8Ia2KVrzUKwc nMuqkDsVIc3gwqFNPbTl3yqVt6k1x+vBCGQUg9BiKE3pkUcONhsJpBYYj4hlY9mn /BPlQBcRUoLHQD7KGSUKVFSODHPYzDg7BsSz2+EpuZucRRI3VEyHlcB5A6LIVhrK fpqd+80Fb7VE9CAxA2gFj7gh5uPJ1A== =shO6 -----END PGP SIGNATURE----- ---------------------------------------------------------------- Akihiko Odaki (5): virtio-net: Fix vhost virtqueue notifiers for RSS ebpf: Fix indirections table setting hw/net/net_tx_pkt: Fix virtio header without checksum offloading tap-win32: Remove unnecessary stubs Revert "tap: setting error appropriately when calling net_init_tap_one()" ebpf/ebpf_rss.c | 9 +++++++-- hw/net/net_tx_pkt.c | 1 + hw/net/virtio-net.c | 4 ++-- include/net/vhost_net.h | 3 --- net/tap-win32.c | 54 ------------------------------------------------- net/tap.c | 22 +++++--------------- 6 files changed, 15 insertions(+), 78 deletions(-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PULL 0/5] Net patches 2024-03-29 7:10 Jason Wang @ 2024-03-31 15:42 ` Peter Maydell 2024-03-31 19:21 ` Michael Tokarev 1 sibling, 0 replies; 15+ messages in thread From: Peter Maydell @ 2024-03-31 15:42 UTC (permalink / raw) To: Jason Wang; +Cc: qemu-devel On Fri, 29 Mar 2024 at 07:11, Jason Wang <jasowang@redhat.com> wrote: > > The following changes since commit 5012e522aca161be5c141596c66e5cc6082538a9: > > Update version for v9.0.0-rc1 release (2024-03-26 19:46:55 +0000) > > are available in the Git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to d9b33018a0da51eddceb48c42345cfb351065f3e: > > Revert "tap: setting error appropriately when calling net_init_tap_one()" (2024-03-29 14:59:07 +0800) > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0 for any user-visible changes. -- PMM ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PULL 0/5] Net patches 2024-03-29 7:10 Jason Wang 2024-03-31 15:42 ` Peter Maydell @ 2024-03-31 19:21 ` Michael Tokarev 2024-04-08 6:42 ` Jason Wang 1 sibling, 1 reply; 15+ messages in thread From: Michael Tokarev @ 2024-03-31 19:21 UTC (permalink / raw) To: Jason Wang, qemu-devel; +Cc: Akihiko Odaki, qemu-stable 29.03.2024 10:10, Jason Wang: > Akihiko Odaki (5): > virtio-net: Fix vhost virtqueue notifiers for RSS > ebpf: Fix indirections table setting > hw/net/net_tx_pkt: Fix virtio header without checksum offloading > tap-win32: Remove unnecessary stubs > Revert "tap: setting error appropriately when calling net_init_tap_one()" From the above, I'm picking up virtio-net: Fix vhost virtqueue notifiers for RSS hw/net/net_tx_pkt: Fix virtio header without checksum offloading for stable. Not yet sure about Revert "tap: setting error appropriately when calling net_init_tap_one()" as it's been with us for a long time. Please Cc: qemu-stable@ for changes which should be picked for stable series. Thanks, /mjt ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PULL 0/5] Net patches 2024-03-31 19:21 ` Michael Tokarev @ 2024-04-08 6:42 ` Jason Wang 0 siblings, 0 replies; 15+ messages in thread From: Jason Wang @ 2024-04-08 6:42 UTC (permalink / raw) To: Michael Tokarev; +Cc: qemu-devel, Akihiko Odaki, qemu-stable On Mon, Apr 1, 2024 at 3:21 AM Michael Tokarev <mjt@tls.msk.ru> wrote: > > 29.03.2024 10:10, Jason Wang: > > > Akihiko Odaki (5): > > virtio-net: Fix vhost virtqueue notifiers for RSS > > ebpf: Fix indirections table setting > > hw/net/net_tx_pkt: Fix virtio header without checksum offloading > > tap-win32: Remove unnecessary stubs > > Revert "tap: setting error appropriately when calling net_init_tap_one()" > > From the above, I'm picking up > > virtio-net: Fix vhost virtqueue notifiers for RSS > hw/net/net_tx_pkt: Fix virtio header without checksum offloading Yes. > > for stable. Not yet sure about > > Revert "tap: setting error appropriately when calling net_init_tap_one()" > > as it's been with us for a long time. It probably isn't worth bothering. > > Please Cc: qemu-stable@ for changes which should be picked for stable > series. > Right. Thanks > Thanks, > > /mjt > ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PULL 0/5] Net patches @ 2025-03-10 12:22 Jason Wang 2025-03-11 5:03 ` Stefan Hajnoczi 0 siblings, 1 reply; 15+ messages in thread From: Jason Wang @ 2025-03-10 12:22 UTC (permalink / raw) To: qemu-devel; +Cc: Jason Wang The following changes since commit d9a4282c4b690e45d25c2b933f318bb41eeb271d: Merge tag 'pull-tcg-20250308' of https://gitlab.com/rth7680/qemu into staging (2025-03-09 11:45:00 +0800) are available in the Git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to ac2ff9b840ce82cc7d5fd9ce4fd3019a434d7dc9: tap-linux: Open ipvtap and macvtap (2025-03-10 17:07:16 +0800) ---------------------------------------------------------------- -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEIV1G9IJGaJ7HfzVi7wSWWzmNYhEFAmfO1zkACgkQ7wSWWzmN YhET+wf+PkaGeFTNUrOtWpl35fSMKlmOVbb1fkPfuhVBmeY2Vh1EIN3OjqnzdV0F wxpuk+wwmFiuV1n6RNuMHQ0nz1mhgsSlZh93N5rArC/PUr3iViaT0cb82RjwxhaI RODBhhy7V9WxEhT9hR8sCP2ky2mrKgcYbjiIEw+IvFZOVQa58rMr2h/cbAb/iH4l 7T9Wba03JBqOS6qgzSFZOMxvqnYdVjhqXN8M6W9ngRJOjPEAkTB6Evwep6anRjcM mCUOgkf2sgQwKve8pYAeTMkzXFctvTc/qCU4ZbN8XcoKVVxe2jllGQqdOpMskPEf slOuINeW5M0K5gyjsb/huqcOTfDI2A== =/Y0+ -----END PGP SIGNATURE----- ---------------------------------------------------------------- Akihiko Odaki (3): util/iov: Do not assert offset is in iov Revert "hw/net/net_tx_pkt: Fix overrun in update_sctp_checksum()" tap-linux: Open ipvtap and macvtap Eugenio Pérez (2): net: parameterize the removing client from nc list net: move backend cleanup to NIC cleanup hw/net/net_tx_pkt.c | 4 ---- include/qemu/iov.h | 5 +++-- net/net.c | 44 ++++++++++++++++++++++++++++++++++---------- net/tap-linux.c | 17 ++++++++++++++--- net/vhost-vdpa.c | 8 -------- util/iov.c | 5 ----- 6 files changed, 51 insertions(+), 32 deletions(-) ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PULL 0/5] Net patches 2025-03-10 12:22 Jason Wang @ 2025-03-11 5:03 ` Stefan Hajnoczi 0 siblings, 0 replies; 15+ messages in thread From: Stefan Hajnoczi @ 2025-03-11 5:03 UTC (permalink / raw) To: Jason Wang; +Cc: qemu-devel, Jason Wang [-- Attachment #1: Type: text/plain, Size: 116 bytes --] Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.0 for any user-visible changes. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2025-03-11 5:05 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-24 2:44 [PULL 0/5] Net patches Jason Wang 2020-11-24 2:44 ` [PULL 1/5] hw/net/e1000e: advance desc_offset in case of null descriptor Jason Wang 2020-11-24 2:44 ` [PULL 2/5] net: do not exit on "netdev_add help" monitor command Jason Wang 2020-11-24 2:44 ` [PULL 3/5] net: purge queued rx packets on queue deletion Jason Wang 2020-11-24 2:44 ` [PULL 4/5] tap: fix a memory leak Jason Wang 2020-11-24 2:44 ` [PULL 5/5] net: Use correct default-path macro for downscript Jason Wang 2020-11-24 13:33 ` [PULL 0/5] Net patches Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2021-08-02 4:33 Jason Wang 2021-08-02 10:40 ` Peter Maydell 2024-03-29 7:10 Jason Wang 2024-03-31 15:42 ` Peter Maydell 2024-03-31 19:21 ` Michael Tokarev 2024-04-08 6:42 ` Jason Wang 2025-03-10 12:22 Jason Wang 2025-03-11 5:03 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).