qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: Alistair Francis <alistair@alistair23.me>,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Bin Meng <bin.meng@windriver.com>
Subject: [PATCH] hw/block: m25p80: Fix fast read for SST flashes
Date: Mon, 30 Nov 2020 10:50:02 +0800	[thread overview]
Message-ID: <1606704602-59435-1-git-send-email-bmeng.cn@gmail.com> (raw)

From: Bin Meng <bin.meng@windriver.com>

SST flashes require a dummy byte after the address bits.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 hw/block/m25p80.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 483925f..9b36762 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -825,6 +825,9 @@ static void decode_fast_read_cmd(Flash *s)
     s->needed_bytes = get_addr_length(s);
     switch (get_man(s)) {
     /* Dummy cycles - modeled with bytes writes instead of bits */
+    case MAN_SST:
+        s->needed_bytes += 1;
+        break;
     case MAN_WINBOND:
         s->needed_bytes += 8;
         break;
-- 
2.7.4



             reply	other threads:[~2020-11-30  2:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30  2:50 Bin Meng [this message]
2020-12-02 19:40 ` [PATCH] hw/block: m25p80: Fix fast read for SST flashes Alistair Francis
2020-12-02 23:09   ` Bin Meng
2020-12-02 23:14     ` Alistair Francis
2020-12-03  8:38   ` Francisco Iglesias
2020-12-04  7:52     ` Bin Meng
2020-12-04 10:46       ` Francisco Iglesias
2020-12-04 10:52         ` Bin Meng
2020-12-04 11:28           ` Francisco Iglesias
2020-12-11  6:07             ` Bin Meng
2020-12-11 15:16               ` Francisco Iglesias
2020-12-11 15:29                 ` Bin Meng
2020-12-11 16:11                   ` Francisco Iglesias
2020-12-12  8:16                     ` Bin Meng
2020-12-12  9:24                       ` Francisco Iglesias
2020-12-12  9:44                         ` Bin Meng
2020-12-15 16:40                           ` Francisco Iglesias
2020-12-16 10:11                             ` Bin Meng
2020-12-22  1:40                               ` Bin Meng
2021-01-06 14:21                                 ` Bin Meng
2021-01-12  1:10                                   ` Bin Meng
2021-01-14 13:38                                     ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1606704602-59435-1-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=alistair@alistair23.me \
    --cc=bin.meng@windriver.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).