From: Steve Sistare <steven.sistare@oracle.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Steve Sistare" <steven.sistare@oracle.com>
Subject: [PATCH V1] gdbstub: suspended state support
Date: Wed, 6 Jan 2021 12:10:15 -0800 [thread overview]
Message-ID: <1609963815-417989-1-git-send-email-steven.sistare@oracle.com> (raw)
Modify the gdb server so a continue command appears to resume execution
when in RUN_STATE_SUSPENDED. Do not print the next gdb prompt, but do not
actually resume instruction fetch. While in this "fake" running mode, a
ctrl-C returns the user to the gdb prompt.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
---
gdbstub.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index f3a318c..2f0d9ff 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -461,7 +461,9 @@ static inline void gdb_continue(void)
#else
if (!runstate_needs_reset()) {
trace_gdbstub_op_continue();
- vm_start();
+ if (!runstate_check(RUN_STATE_SUSPENDED)) {
+ vm_start();
+ }
}
#endif
}
@@ -490,7 +492,7 @@ static int gdb_continue_partial(char *newstates)
int flag = 0;
if (!runstate_needs_reset()) {
- if (vm_prepare_start()) {
+ if (!runstate_check(RUN_STATE_SUSPENDED) && vm_prepare_start()) {
return 0;
}
@@ -2835,6 +2837,9 @@ static void gdb_read_byte(uint8_t ch)
/* when the CPU is running, we cannot do anything except stop
it when receiving a char */
vm_stop(RUN_STATE_PAUSED);
+ } else if (runstate_check(RUN_STATE_SUSPENDED) && ch == 3) {
+ /* Received ctrl-c from gdb */
+ gdb_vm_state_change(0, 0, RUN_STATE_PAUSED);
} else
#endif
{
@@ -3282,6 +3287,8 @@ static void gdb_sigterm_handler(int signal)
{
if (runstate_is_running()) {
vm_stop(RUN_STATE_PAUSED);
+ } else if (runstate_check(RUN_STATE_SUSPENDED)) {
+ gdb_vm_state_change(0, 0, RUN_STATE_PAUSED);
}
}
#endif
--
1.8.3.1
next reply other threads:[~2021-01-06 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 20:10 Steve Sistare [this message]
2021-01-07 12:40 ` [PATCH V1] gdbstub: suspended state support Alex Bennée
2021-01-07 15:05 ` Steven Sistare
2021-01-07 16:02 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609963815-417989-1-git-send-email-steven.sistare@oracle.com \
--to=steven.sistare@oracle.com \
--cc=alex.bennee@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).