Re: [PATCH] tests/functional/test_virtio_balloon: Only use KVM for running this test

[David Hildenbrand <david@redhat.com>]

On 07.03.25 07:39, Thomas Huth wrote:
> The virtio_balloon test is currently hanging for unknown reasons
> when being run on the shared gitlab CI runners (which don't provide
> KVM, thus it's running in TCG mode there). All other functional tests
> that use the same asset (the Fedora 31 kernel) have already been
> marked to work only with KVM in the past, so those other tests are
> skipped on the shared gitlab CI runners. As long as the problem isn't
> fully understood and fixed, let's do the same with the virtio_balloon
> test to avoid that the CI is failing here.

Reviewed-by: David Hildenbrand <david@redhat.com>

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/test_virtio_balloon.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/functional/test_virtio_balloon.py b/tests/functional/test_virtio_balloon.py
> index 082bf08c4e8..5877b6c408c 100755
> --- a/tests/functional/test_virtio_balloon.py
> +++ b/tests/functional/test_virtio_balloon.py
> @@ -110,6 +110,7 @@ def assert_running_stats(self, then):
>   
>       def test_virtio_balloon_stats(self):
>           self.set_machine('q35')
> +        self.require_accelerator("kvm")
>           kernel_path = self.ASSET_KERNEL.fetch()
>           initrd_path = self.ASSET_INITRD.fetch()
>           diskimage_path = self.ASSET_DISKIMAGE.fetch()
> @@ -122,7 +123,7 @@ def test_virtio_balloon_stats(self):
>           # reset, we can reliably catch the clean stats again in BIOS
>           # phase before the guest OS launches
>           self.vm.add_args("-boot", "menu=on")
> -        self.vm.add_args("-machine", "q35,accel=kvm:tcg")
> +        self.vm.add_args("-accel", "kvm")
>           self.vm.add_args("-device", "virtio-balloon,id=balloon")
>           self.vm.add_args('-drive',
>                            f'file={diskimage_path},if=none,id=drv0,snapshot=on')


-- 
Cheers,

David / dhildenb