From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A29DC433E0 for ; Thu, 25 Feb 2021 09:25:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA6B764E90 for ; Thu, 25 Feb 2021 09:25:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA6B764E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFCtx-0005n4-Gd for qemu-devel@archiver.kernel.org; Thu, 25 Feb 2021 04:25:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFCrw-00043Q-6O; Thu, 25 Feb 2021 04:23:37 -0500 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:44647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFCrp-0002ap-0U; Thu, 25 Feb 2021 04:23:35 -0500 Received: by mail-ed1-x535.google.com with SMTP id g3so5876456edb.11; Thu, 25 Feb 2021 01:23:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=MxAg9mEplHYi/WoMH9eGqbZdqmjTbCTLlnsCgEMZaYc=; b=fpkN/tDlPY3zPcBW05/FvpN+ZaWG7NySbIAn+6Xx0h/KAHN63K4+aaXIdcTNZ0oabP iHlsW0nkBT+nAR6mnub9S3B/59lJpIfRP1zpwwB3ZhHDp1KU9jebLIcKYjuJMVLy2Em+ iXW7SQtxlyjoV9x+aB0BuL7qZlrqYo9ovUqUmc6G959Ewq4XEcC8DybVtAcc7UC41j9j FWFvHluIndr8X08zSkFNEP7MKNO3v5kUR+twS3Z7pAxf9kMiVgRMuPHVDzCRI+5jD7OP zCD7VyBiwHcxwpw9Tff0/XRgiexD8ePN/62Z2iQX2WAxLJK5Tuya+wIPs5H+2Yys2nVR u9Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MxAg9mEplHYi/WoMH9eGqbZdqmjTbCTLlnsCgEMZaYc=; b=gFWTwY6S+rRWnSLqJ2tVwzuDOnVfXrZPr4QK5Xf0oL9UHxUanlKv01UflS4AjHXV/k fdosurhZpncmxC9L9wUh3bzTnjGGzHSz2oq3xQ78CvjGMsk1TtTPYeghI6winK7F006B 2rylwkqq61/5ZRKJPO2AdkmVw5tVH40hsWkoGe2VfOAnwYm3wmAqokAAUDy5LD/FUOWM N5YSItUrxxjROG0S1vGjvTAjgJVcKpO1HeuAEPyjLRagBhMTGEMVNSDu//8cZGU2AF2n oxlpo9D6eozUr3OpN0zscLGgGGMvmBZT7hy+/8qPp0MGA1g1YtJzsF4xxFaYMDfSHaOO Hj3A== X-Gm-Message-State: AOAM533SxTNWYixzh6/McRAIbe4ubrShZ6yB0HY6PnmFwN14OWgwg+Sy Bk9OjDl+aprMd7yLQ5juP7k= X-Google-Smtp-Source: ABdhPJz8e+GMKIvAG5+QjvRqB+8lsOd21nEA9pDahwcaT2mO2k4mw8uZ8JVJAyvzPxIGTjkwEzX+VQ== X-Received: by 2002:a05:6402:3121:: with SMTP id dd1mr1924094edb.387.1614245006797; Thu, 25 Feb 2021 01:23:26 -0800 (PST) Received: from pek-vx-bsp2.wrs.com (ec2-44-242-66-180.us-west-2.compute.amazonaws.com. [44.242.66.180]) by smtp.gmail.com with ESMTPSA id k22sm2987368edv.33.2021.02.25.01.23.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Feb 2021 01:23:26 -0800 (PST) From: Bin Meng To: Simon Glass , Alexander Graf , Priyanka Jain Subject: [PATCH v3 00/38] ppc: qemu: Convert qemu-ppce500 to driver model and enable additional driver support Date: Thu, 25 Feb 2021 17:22:21 +0800 Message-Id: <1614244979-48216-1-git-send-email-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.7.4 Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=bmeng.cn@gmail.com; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Rini , Matthias Brugger , qemu-devel@nongnu.org, U-Boot Mailing List , qemu-ppc@nongnu.org, Heiko Schocher , Marek Szyprowski Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" At present when building qemu-ppce500 the following warnings are seen: ===================== WARNING ====================== This board does not use CONFIG_DM. CONFIG_DM will be compulsory starting with the v2020.01 release. Failure to update may result in board removal. UPD include/generated/timestamp_autogenerated.h See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_PCI Please update the board to use CONFIG_DM_PCI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== The conversion of qemu-ppce500 board to driver model is long overdue. When testing the exisitng qemu-ppce500 support, PCI was found broken. This is caused by 2 separate issues: - One issue was caused by U-Boot: Commit e002474158d1 ("pci: pci-uclass: Dynamically allocate the PCI regions") Patch #1 updated the non-DM fsl_pci_init driver to dynamically allocate the PCI regions, to keep in sync with the pci uclass driver - One issue was caused by QEMU: commit e6b4e5f4795b ("PPC: e500: Move CCSR and MMIO space to upper end of address space") commit cb3778a0455a ("PPC: e500 pci host: Add support for ATMUs") Patch #3-4 fixed this issue to keep in sync with latest QEMU upstream Patch #5-8, #34-36 are minor fixes and clean-ups. Starting from patch#9, these are driver model conversion patches. Patch #11-17 are mainly related to CONFIG_ADDR_MAP, a library to support targets that have non-identity virtual-physical address mappings. A new command 'addrmap' is introduced to aid debugging, and a fix to arch/powerpc/asm/include/io.h is made to correct the usage of CONFIG_ADDR_MAP as it can only be used in the post- relocation phase. Also the initialization of this library is moved a bit earlier in the post-relocation phase otherwise device drivers won't work. Patch #19-21 are 85xx PCI driver fixes. It adds support to controller register physical address beyond 32-bit, as well as support to 64-bit bus and cpu address as current upstream QEMU uses 64-bit cpu address. Starting from patch#24, these are additional driver support patches. Patch #24, #26 are minor fix to the 'virtio' command and BLK driver dependency. Patch #25 enables the VirtIO NET support as by default a VirtIO standard PCI networking device is connected as an ethernet interface at PCI address 0.1.0. Patch #27 enables the VirtIO BLK driver support. Patch #28-30 enables the GPIO support. Patch #31-32 enables poweroff via GPIO. Patch #33 enables RTC over the I2C bus. Patch #37 moves the qemu-ppce500 boards codes to board/emulation as that is the place for other QEMU targets like x86, arm, riscv. Patch #38 adds a reST document to describe how to build and run U-Boot for the QEMU ppce500 machine. I hope we can make this series to U-Boot v2021.04 release. This series is available at u-boot-x86/qemu-ppc for testing. This cover letter is cc'ed to QEMU mailing list for a heads-up. A future patch will be sent to QEMU mailing list to bring its in-tree U-Boot source codes up-to-date. Changes in v3: - rebase on top of u-boot/master Changes in v2: - drop the revert patch of commit e002474158d1 - new patch: pci: fsl_pci_init: Dynamically allocate the PCI regions - add more details in the commit message, and put some comments in the codes to explain why - add doc/usage/addrmap.rst - new patch: test: cmd: Add a basic test for 'addrmap' command - new patch: virtio: Fix VirtIO BLK driver dependency - new patch: ppc: qemu: Enable VirtIO BLK support - new patch: ppc: mpc85xx: Add 'gpibe' register to 'struct ccsr_gpio' - new patch: gpio: mpc8xxx: Support controller register physical address beyond 32-bit - new patch: ppc: qemu: Enable GPIO support - new patch: dm: sysreset: Add a Kconfig option for the 'reset' command - new patch: ppc: qemu: Enable support for power off via GPIO - new patch: ppc: qemu: Enable RTC support via I2C - new patch: ppc: qemu: Delete the temporary FDT virtual-physical mapping after U-Boot is relocated - new patch: ppc: qemu: Drop a custom env variable 'fdt_addr_r' - new patch: ppc: qemu: Drop fixed_sdram() - add descriptions for VirtIO BLK, RTC and power off Bin Meng (38): pci: fsl_pci_init: Dynamically allocate the PCI regions ppc: qemu: Update MAINTAINERS for correct email address common: fdt_support: Support special case of PCI address in fdt_read_prop() ppc: qemu: Support non-identity PCI bus address ppc: qemu: Fix CONFIG_SYS_PCI_MAP_END ppc: mpc85xx: Wrap LAW related codes with CONFIG_FSL_LAW ppc: qemu: Drop init_laws() and print_laws() ppc: qemu: Drop board_early_init_f() ppc: qemu: Enable OF_CONTROL ppc: qemu: Enable driver model include: Remove extern from addr_map.h lib: addr_map: Move address_map[] type to the header file cmd: Add a command to display the address map test: cmd: Add a basic test for 'addrmap' command lib: kconfig: Mention CONFIG_ADDR_MAP limitation in the help ppc: io.h: Use addrmap_ translation APIs only in post-relocation phase common: Move initr_addr_map() to a bit earlier ppc: qemu: Switch over to use DM serial pci: mpc85xx: Wrap LAW programming with CONFIG_FSL_LAW pci: mpc85xx: Support controller register physical address beyond 32-bit pci: mpc85xx: Support 64-bit bus and cpu address ppc: qemu: Switch over to use DM ETH and PCI ppc: qemu: Drop CONFIG_OF_BOARD_SETUP cmd: Fix virtio command dependency ppc: qemu: Enable VirtIO NET support virtio: Fix VirtIO BLK driver dependency ppc: qemu: Enable VirtIO BLK support ppc: mpc85xx: Add 'gpibe' register to 'struct ccsr_gpio' gpio: mpc8xxx: Support controller register physical address beyond 32-bit ppc: qemu: Enable GPIO support dm: sysreset: Add a Kconfig option for the 'reset' command ppc: qemu: Enable support for power off via GPIO ppc: qemu: Enable RTC support via I2C ppc: qemu: Delete the temporary FDT virtual-physical mapping after U-Boot is relocated ppc: qemu: Drop a custom env variable 'fdt_addr_r' ppc: qemu: Drop fixed_sdram() ppc: qemu: Move board directory from board/freescale to board/emulation doc: Add a reST document for qemu-ppce500 arch/powerpc/cpu/mpc85xx/Kconfig | 2 +- arch/powerpc/cpu/mpc85xx/cpu.c | 2 + arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 2 + arch/powerpc/include/asm/arch-mpc85xx/gpio.h | 2 +- arch/powerpc/include/asm/immap_85xx.h | 1 + arch/powerpc/include/asm/io.h | 15 +- .../{freescale => emulation}/qemu-ppce500/Kconfig | 2 +- board/emulation/qemu-ppce500/MAINTAINERS | 7 + .../{freescale => emulation}/qemu-ppce500/Makefile | 0 .../qemu-ppce500/qemu-ppce500.c | 178 +++++++-------------- board/freescale/qemu-ppce500/MAINTAINERS | 6 - cmd/Kconfig | 8 + cmd/Makefile | 1 + cmd/addrmap.c | 35 ++++ common/board_r.c | 6 +- common/fdt_support.c | 20 ++- configs/qemu-ppce500_defconfig | 27 +++- doc/board/emulation/index.rst | 1 + doc/board/emulation/qemu-ppce500.rst | 88 ++++++++++ doc/usage/addrmap.rst | 41 +++++ doc/usage/index.rst | 1 + drivers/gpio/mpc8xxx_gpio.c | 7 +- drivers/pci/fsl_pci_init.c | 5 + drivers/pci/pci_mpc85xx.c | 25 +-- drivers/sysreset/Kconfig | 6 + drivers/sysreset/sysreset-uclass.c | 2 + drivers/virtio/Kconfig | 1 + include/addr_map.h | 16 +- include/configs/qemu-ppce500.h | 30 +--- include/test/suites.h | 2 + lib/Kconfig | 2 + lib/addr_map.c | 6 +- test/cmd/Makefile | 1 + test/cmd/addrmap.c | 38 +++++ test/cmd_ut.c | 6 + 35 files changed, 397 insertions(+), 195 deletions(-) rename board/{freescale => emulation}/qemu-ppce500/Kconfig (86%) create mode 100644 board/emulation/qemu-ppce500/MAINTAINERS rename board/{freescale => emulation}/qemu-ppce500/Makefile (100%) rename board/{freescale => emulation}/qemu-ppce500/qemu-ppce500.c (65%) delete mode 100644 board/freescale/qemu-ppce500/MAINTAINERS create mode 100644 cmd/addrmap.c create mode 100644 doc/board/emulation/qemu-ppce500.rst create mode 100644 doc/usage/addrmap.rst create mode 100644 test/cmd/addrmap.c -- 2.7.4