* [PATCH] net: Print the packet size in the debug output
@ 2021-02-26 9:46 Bin Meng
2021-02-26 10:20 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Bin Meng @ 2021-02-26 9:46 UTC (permalink / raw)
To: Jason Wang, qemu-devel; +Cc: Bin Meng
From: Bin Meng <bin.meng@windriver.com>
Printing out the packet size is helpful during debug.
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
net/net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/net.c b/net/net.c
index 32d71c1..b038370 100644
--- a/net/net.c
+++ b/net/net.c
@@ -641,7 +641,7 @@ static ssize_t qemu_send_packet_async_with_flags(NetClientState *sender,
int ret;
#ifdef DEBUG_NET
- printf("qemu_send_packet_async:\n");
+ printf("qemu_send_packet_async: packet size (%d)\n", size);
qemu_hexdump(stdout, "net", buf, size);
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: Print the packet size in the debug output
2021-02-26 9:46 [PATCH] net: Print the packet size in the debug output Bin Meng
@ 2021-02-26 10:20 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-02-26 10:20 UTC (permalink / raw)
To: Bin Meng, Jason Wang, qemu-devel; +Cc: Bin Meng
On 2/26/21 10:46 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> Printing out the packet size is helpful during debug.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> net/net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/net.c b/net/net.c
> index 32d71c1..b038370 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -641,7 +641,7 @@ static ssize_t qemu_send_packet_async_with_flags(NetClientState *sender,
> int ret;
>
> #ifdef DEBUG_NET
> - printf("qemu_send_packet_async:\n");
> + printf("qemu_send_packet_async: packet size (%d)\n", size);
> qemu_hexdump(stdout, "net", buf, size);
At this point better to convert to trace events (see commit
db1e7afa371):
if (trace_event_get_state_backends(TRACE_NET_SEND_PACKET)) {
net_pkt_hexdump(buf, size);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-26 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 9:46 [PATCH] net: Print the packet size in the debug output Bin Meng
2021-02-26 10:20 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).