Re: [Qemu-devel] [PATCH 4/5] checkpatch: bump most warnings to errors

[Paolo Bonzini <pbonzini@redhat.com>]

> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 714a000..ab08ca2 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1289,11 +1289,11 @@ sub process {
> >  			# This is a signoff, if ugly, so do not double report.
> >  			$signoff++;
> >  			if (!($line =~ /^\s*Signed-off-by:/)) {
> > -				WARN("Signed-off-by: is the preferred form\n" .
> > +				ERROR("Signed-off-by: is the preferred form\n" .
> >  					$herecurr);
> >  			}
> 
> If you turn this into an ERROR, it's not the "preferred form" anymore,
> but the "mandated form". So I'd suggest to either keep it as WARN or to
> rephrase the message.

What about:

                                ERROR("Signed-off-by: is spelled with uppercase \"s\"\n" .
                                        $herecurr);

Paolo